All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Jason Wang <jasowang@redhat.com>,
	Heng Qi <hengqi@linux.alibaba.com>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	Yuri Benditovich <yuri.benditovich@daynix.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash
Date: Wed, 28 Jun 2023 13:23:50 -0400	[thread overview]
Message-ID: <20230628132122-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481BA1CDA0942170186CB59DC24A@PH0PR12MB5481.namprd12.prod.outlook.com>

On Wed, Jun 28, 2023 at 05:06:40PM +0000, Parav Pandit wrote:
> > > >
> > > > Please let people just focus on fixing config space instead of
> > > > temporary cvq hacks.
> > >
> > > The ask is to have predictable sizing for existing defined config space field and
> > not keep infinitely growing by two interfaces.
> > 
> > I don't know what "predictable sizing" is or why does it matter.
> > 
> Because when device has two ways to access config space, it always have to account and build the interface that, hey some driver will not use DMA.
> Hence have it always in the MMIO accessible area.

Maybe I get it. You want to use the new features as a carrot to force
drivers to implement DMA? You suspect they will ignore the spec
requirement just because things seem to work?

There's some logic here, for sure. you just might be right.

However, surely we can discuss this small tweak in 1.4 timeframe?

-- 
MST


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Jason Wang <jasowang@redhat.com>,
	Heng Qi <hengqi@linux.alibaba.com>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	Yuri Benditovich <yuri.benditovich@daynix.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash
Date: Wed, 28 Jun 2023 13:23:50 -0400	[thread overview]
Message-ID: <20230628132122-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481BA1CDA0942170186CB59DC24A@PH0PR12MB5481.namprd12.prod.outlook.com>

On Wed, Jun 28, 2023 at 05:06:40PM +0000, Parav Pandit wrote:
> > > >
> > > > Please let people just focus on fixing config space instead of
> > > > temporary cvq hacks.
> > >
> > > The ask is to have predictable sizing for existing defined config space field and
> > not keep infinitely growing by two interfaces.
> > 
> > I don't know what "predictable sizing" is or why does it matter.
> > 
> Because when device has two ways to access config space, it always have to account and build the interface that, hey some driver will not use DMA.
> Hence have it always in the MMIO accessible area.

Maybe I get it. You want to use the new features as a carrot to force
drivers to implement DMA? You suspect they will ignore the spec
requirement just because things seem to work?

There's some logic here, for sure. you just might be right.

However, surely we can discuss this small tweak in 1.4 timeframe?

-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2023-06-28 17:24 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 16:35 [virtio-comment] [PATCH v19] virtio-net: support inner header hash Heng Qi
2023-06-27 16:35 ` [virtio-dev] " Heng Qi
2023-06-28  3:46 ` [virtio-comment] " Jason Wang
2023-06-28  3:46   ` [virtio-dev] " Jason Wang
2023-06-28  4:23   ` [virtio-comment] " Parav Pandit
2023-06-28  4:23     ` [virtio-dev] " Parav Pandit
2023-06-28  5:37     ` [virtio-comment] " Jason Wang
2023-06-28  5:37       ` [virtio-dev] " Jason Wang
2023-06-28 15:59       ` [virtio-comment] " Parav Pandit
2023-06-28 15:59         ` [virtio-dev] " Parav Pandit
2023-06-29  3:17         ` [virtio-comment] " Jason Wang
2023-06-29  3:17           ` [virtio-dev] " Jason Wang
2023-06-30 11:42           ` [virtio-comment] " Parav Pandit
2023-06-30 11:42             ` Parav Pandit
2023-06-28 10:27     ` [virtio-comment] " Michael S. Tsirkin
2023-06-28 10:27       ` [virtio-dev] " Michael S. Tsirkin
2023-06-28 16:18       ` Parav Pandit
2023-06-28 16:18         ` [virtio-dev] " Parav Pandit
2023-06-28 16:45         ` Michael S. Tsirkin
2023-06-28 16:45           ` [virtio-dev] " Michael S. Tsirkin
2023-06-28 17:06           ` Parav Pandit
2023-06-28 17:06             ` [virtio-dev] " Parav Pandit
2023-06-28 17:16             ` Michael S. Tsirkin
2023-06-28 17:16               ` [virtio-dev] " Michael S. Tsirkin
2023-06-28 17:28               ` Parav Pandit
2023-06-28 17:28                 ` [virtio-dev] " Parav Pandit
2023-06-28 17:23             ` Michael S. Tsirkin [this message]
2023-06-28 17:23               ` [virtio-dev] " Michael S. Tsirkin
2023-06-28 17:38               ` Parav Pandit
2023-06-28 17:38                 ` [virtio-dev] " Parav Pandit
2023-06-28 19:44                 ` Michael S. Tsirkin
2023-06-28 19:44                   ` [virtio-dev] " Michael S. Tsirkin
2023-06-29  1:56                   ` Parav Pandit
2023-06-29  1:56                     ` [virtio-dev] " Parav Pandit
2023-06-29  2:05                     ` Heng Qi
2023-06-29  2:05                       ` [virtio-dev] " Heng Qi
2023-06-29 11:48                       ` Michael S. Tsirkin
2023-06-29 11:48                         ` [virtio-dev] " Michael S. Tsirkin
2023-06-29 13:08                         ` [virtio-comment] " Heng Qi
2023-06-29 13:08                           ` Heng Qi
2023-06-29 16:59                         ` Parav Pandit
2023-06-29 16:59                           ` [virtio-dev] " Parav Pandit
2023-06-30  0:54                           ` [virtio-comment] " Heng Qi
2023-06-30  0:54                             ` Heng Qi
2023-06-30  1:36                             ` [virtio-comment] " Parav Pandit
2023-06-30  1:36                               ` Parav Pandit
2023-06-30  1:55                               ` [virtio-comment] " Heng Qi
2023-06-30  1:55                                 ` Heng Qi
2023-06-30  5:59                                 ` [virtio-comment] " Michael S. Tsirkin
2023-06-30  5:59                                   ` [virtio-dev] " Michael S. Tsirkin
2023-06-30  6:15                                   ` [virtio-comment] " Heng Qi
2023-06-30  6:15                                     ` Heng Qi
2023-06-30  8:17                                     ` [virtio-comment] " Michael S. Tsirkin
2023-06-30  8:17                                       ` Michael S. Tsirkin
2023-06-30 14:04                                       ` [virtio-comment] " Heng Qi
2023-06-30 14:04                                         ` [virtio-dev] " Heng Qi
2023-06-30 14:52                                         ` Michael S. Tsirkin
2023-06-30 14:52                                           ` [virtio-dev] " Michael S. Tsirkin
2023-06-30 16:09                                           ` Heng Qi
2023-06-30 16:09                                             ` [virtio-dev] " Heng Qi
2023-06-30 16:56                                             ` Michael S. Tsirkin
2023-06-30 16:56                                               ` [virtio-dev] " Michael S. Tsirkin
2023-06-30 17:33                                               ` Heng Qi
2023-06-30 17:33                                                 ` [virtio-dev] " Heng Qi
2023-06-29  6:03                     ` Michael S. Tsirkin
2023-06-29  6:03                       ` [virtio-dev] " Michael S. Tsirkin
2023-06-29  6:40                     ` Heng Qi
2023-06-29  6:40                       ` [virtio-dev] " Heng Qi
2023-06-29 11:38                       ` Parav Pandit
2023-06-29 11:38                         ` [virtio-dev] " Parav Pandit
2023-06-29 11:46                       ` Michael S. Tsirkin
2023-06-29 11:46                         ` [virtio-dev] " Michael S. Tsirkin
2023-06-29 12:01                         ` Parav Pandit
2023-06-29 12:01                           ` [virtio-dev] " Parav Pandit
2023-06-29  7:07                     ` Michael S. Tsirkin
2023-06-29  7:07                       ` [virtio-dev] " Michael S. Tsirkin
2023-06-30 11:38                       ` [virtio-comment] " Parav Pandit
2023-06-30 11:38                         ` Parav Pandit
2023-06-30 15:30                         ` [virtio-comment] " Michael S. Tsirkin
2023-06-30 15:30                           ` Michael S. Tsirkin
2023-06-28 10:10   ` [virtio-comment] " Michael S. Tsirkin
2023-06-28 10:10     ` [virtio-dev] " Michael S. Tsirkin
2023-06-29  3:31     ` [virtio-comment] " Jason Wang
2023-06-29  3:31       ` [virtio-dev] " Jason Wang
2023-06-29 11:54       ` [virtio-comment] " Michael S. Tsirkin
2023-06-29 11:54         ` [virtio-dev] " Michael S. Tsirkin
2023-06-29 11:55         ` Michael S. Tsirkin
2023-06-29 11:55           ` [virtio-dev] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230628132122-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=hengqi@linux.alibaba.com \
    --cc=jasowang@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.