All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	linux-kernel@vger.kernel.org,
	Robert Moore <robert.moore@intel.com>,
	linux-acpi@vger.kernel.org, Michael Walle <michael@walle.cc>,
	linux-i2c@vger.kernel.org,
	acpica-devel@lists.linuxfoundation.org,
	Len Brown <lenb@kernel.org>
Subject: Re: [Acpica-devel] [PATCH v3 1/4] ACPI: bus: Constify acpi_companion_match() returned value
Date: Thu, 29 Jun 2023 15:52:57 -0000	[thread overview]
Message-ID: <20230629155245.syd6mx2rffbvbkol@intel.intel> (raw)
In-Reply-To: <20230626110026.65825-2-andriy.shevchenko@linux.intel.com>

Hi Andy,

On Mon, Jun 26, 2023 at 02:00:23PM +0300, Andy Shevchenko wrote:
> acpi_companion_match() doesn't alter the contents of the passed
> parameter, so we don't expect that returned value can be altered
> either. So constify it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I guess I'm late for adding my

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

here.

Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-i2c@vger.kernel.org,
	acpica-devel@lists.linuxfoundation.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Robert Moore <robert.moore@intel.com>,
	Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v3 1/4] ACPI: bus: Constify acpi_companion_match() returned value
Date: Thu, 29 Jun 2023 17:52:45 +0200	[thread overview]
Message-ID: <20230629155245.syd6mx2rffbvbkol@intel.intel> (raw)
In-Reply-To: <20230626110026.65825-2-andriy.shevchenko@linux.intel.com>

Hi Andy,

On Mon, Jun 26, 2023 at 02:00:23PM +0300, Andy Shevchenko wrote:
> acpi_companion_match() doesn't alter the contents of the passed
> parameter, so we don't expect that returned value can be altered
> either. So constify it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I guess I'm late for adding my

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

here.

Andi

  parent reply	other threads:[~2023-06-29 15:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26 11:00 [PATCH v3 0/4] ACPI: platform: Fix SMB0001 enumeration on Kontron devices Andy Shevchenko
2023-06-26 11:00 ` [Acpica-devel] " Andy Shevchenko
2023-06-26 11:00 ` [Acpica-devel] [PATCH v3 2/4] ACPI: bus: Introduce acpi_match_acpi_device() helper Andy Shevchenko
2023-06-26 11:00   ` Andy Shevchenko
2023-06-29  8:44   ` Rafael J. Wysocki
2023-06-29  8:45     ` [Acpica-devel] " Rafael J. Wysocki
2023-06-26 11:00 ` [Acpica-devel] [PATCH v3 4/4] ACPI: platform: Move SMB0001 HID to the header and reuse Andy Shevchenko
2023-06-26 11:00   ` Andy Shevchenko
2023-06-26 11:00 ` [PATCH v3 1/4] ACPI: bus: Constify acpi_companion_match() returned value Andy Shevchenko
2023-06-26 11:00   ` [Acpica-devel] " Andy Shevchenko
2023-06-29  8:49   ` Rafael J. Wysocki
2023-06-29  8:49     ` [Acpica-devel] " Rafael J. Wysocki
2023-06-29  9:08     ` Andy Shevchenko
2023-06-29  9:08       ` [Acpica-devel] " Andy Shevchenko
2023-06-29  9:43       ` Rafael J. Wysocki
2023-06-29  9:43         ` [Acpica-devel] " Rafael J. Wysocki
2023-06-29 15:52   ` Andi Shyti [this message]
2023-06-29 15:52     ` Andi Shyti
2023-06-26 11:00 ` [Acpica-devel] [PATCH v3 3/4] ACPI: platform: Ignore SMB0001 only when it has resources Andy Shevchenko
2023-06-26 11:00   ` Andy Shevchenko
2023-06-29 15:59   ` Andi Shyti
2023-06-29 16:00     ` [Acpica-devel] " Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230629155245.syd6mx2rffbvbkol@intel.intel \
    --to=andi.shyti@kernel.org \
    --cc=acpica-devel@lists.linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.