From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Andi Shyti <andi.shyti@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org,
Robert Moore <robert.moore@intel.com>,
linux-acpi@vger.kernel.org, Michael Walle <michael@walle.cc>,
linux-i2c@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
Len Brown <lenb@kernel.org>
Subject: Re: [Acpica-devel] [PATCH v3 1/4] ACPI: bus: Constify acpi_companion_match() returned value
Date: Thu, 29 Jun 2023 09:08:51 -0000 [thread overview]
Message-ID: <ZJ1KHJW6Jhma/rHc@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0jqP0N3=TB3w+HMwGMzctpRCjKa3a5iHKePP113T3CK-g@mail.gmail.com>
On Thu, Jun 29, 2023 at 10:49:17AM +0200, Rafael J. Wysocki wrote:
> On Mon, Jun 26, 2023 at 1:00 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > acpi_companion_match() doesn't alter the contents of the passed
> > parameter, so we don't expect that returned value can be altered
> > either. So constify it.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> This makes sense even without the rest of the series, so I can queue
> it up right away if you want me to do that.
Please, go ahead and thank you!
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
Len Brown <lenb@kernel.org>, Andi Shyti <andi.shyti@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v3 1/4] ACPI: bus: Constify acpi_companion_match() returned value
Date: Thu, 29 Jun 2023 12:08:44 +0300 [thread overview]
Message-ID: <ZJ1KHJW6Jhma/rHc@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0jqP0N3=TB3w+HMwGMzctpRCjKa3a5iHKePP113T3CK-g@mail.gmail.com>
On Thu, Jun 29, 2023 at 10:49:17AM +0200, Rafael J. Wysocki wrote:
> On Mon, Jun 26, 2023 at 1:00 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > acpi_companion_match() doesn't alter the contents of the passed
> > parameter, so we don't expect that returned value can be altered
> > either. So constify it.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> This makes sense even without the rest of the series, so I can queue
> it up right away if you want me to do that.
Please, go ahead and thank you!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-29 9:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 11:00 [PATCH v3 0/4] ACPI: platform: Fix SMB0001 enumeration on Kontron devices Andy Shevchenko
2023-06-26 11:00 ` [Acpica-devel] " Andy Shevchenko
2023-06-26 11:00 ` [Acpica-devel] [PATCH v3 2/4] ACPI: bus: Introduce acpi_match_acpi_device() helper Andy Shevchenko
2023-06-26 11:00 ` Andy Shevchenko
2023-06-29 8:44 ` Rafael J. Wysocki
2023-06-29 8:45 ` [Acpica-devel] " Rafael J. Wysocki
2023-06-26 11:00 ` [PATCH v3 1/4] ACPI: bus: Constify acpi_companion_match() returned value Andy Shevchenko
2023-06-26 11:00 ` [Acpica-devel] " Andy Shevchenko
2023-06-29 8:49 ` Rafael J. Wysocki
2023-06-29 8:49 ` [Acpica-devel] " Rafael J. Wysocki
2023-06-29 9:08 ` Andy Shevchenko [this message]
2023-06-29 9:08 ` Andy Shevchenko
2023-06-29 9:43 ` Rafael J. Wysocki
2023-06-29 9:43 ` [Acpica-devel] " Rafael J. Wysocki
2023-06-29 15:52 ` Andi Shyti
2023-06-29 15:52 ` [Acpica-devel] " Andi Shyti
2023-06-26 11:00 ` [Acpica-devel] [PATCH v3 4/4] ACPI: platform: Move SMB0001 HID to the header and reuse Andy Shevchenko
2023-06-26 11:00 ` Andy Shevchenko
2023-06-26 11:00 ` [Acpica-devel] [PATCH v3 3/4] ACPI: platform: Ignore SMB0001 only when it has resources Andy Shevchenko
2023-06-26 11:00 ` Andy Shevchenko
2023-06-29 15:59 ` Andi Shyti
2023-06-29 16:00 ` [Acpica-devel] " Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ1KHJW6Jhma/rHc@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=andi.shyti@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.