From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Pintu Agarwal <pintu.ping@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-fsdevel@kvack.org, ezequiel@collabora.com, bjorn@mork.no
Subject: Re: MTD: Lots of mtdblock warnings on bootup logs
Date: Wed, 12 Jul 2023 16:22:13 +0200 [thread overview]
Message-ID: <20230712162213.79bc889c@xps-13> (raw)
In-Reply-To: <CAOuPNLizjBp_8ceKq=RLznXdsHD-+N55RoPh_D7_Mpkg7M-BwQ@mail.gmail.com>
Hi Pintu,
pintu.ping@gmail.com wrote on Wed, 12 Jul 2023 19:29:39 +0530:
> Hi,
>
> We are getting below warning messages in dmesg logs on a NAND device
> for every raw partition.
> Kernel: 5.15 ; arm64 ; NAND + ubi + squashfs
> We have some RAW partitions and one UBI partition (with ubifs/squashfs volumes).
>
> We are seeing large numbers of these logs on the serial console that
> impact the boot time.
> [....]
> [ 9.667240][ T9] Creating 58 MTD partitions on "1c98000.nand":
> [....]
> [ 39.975707][ T519] mtdblock: MTD device 'uefi_a' is NAND, please
> consider using UBI block devices instead.
> [ 39.975707][ T519] mtdblock: MTD device 'uefi_b' is NAND, please
> consider using UBI block devices instead.
> [....]
>
> This was added as part of this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/mtd/mtdblock.c?h=v5.15.120&id=f41c9418c5898c01634675150696da290fb86796
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/mtd/mtdblock.c?h=v5.15.120&id=e07403a8c6be01857ff75060b2df9a1aa8320fe5
>
> I think this warning was decided after my last year's discussion about
> mtdblock vs ubiblock for squashfs.
>
> But these are raw NAND partitions and not mounted by us.
>
> What is the exact meaning of these warnings ?
mtdblock is legacy, ubiblock is better (on NAND devices).
> We have both these configs enabled:
> CONFIG_MTD_BLOCK=y
> CONFIG_MTD_UBI_BLOCK=y
>
> Through this warning, are we telling that only one of the above config
> should be enabled ?
If you don't need both, then yes.
> And the recommendation is to use ubi_block and disable mtd_block ?
Yes.
> We are already using ubiblock for mounting squashfs volumes.
> But how to get rid of these warnings for raw NAND partitions ?
>
> Is there a way to avoid or we are missing something which we are not aware of?
>
In theory the warning should only appear if you open the device (IOW,
only if you use it). For this to happen, you need:
96a3295c351d ("mtdblock: warn if opened on NAND")
This commit was maybe not backported to stable kernels, you can send it
to stable@vger.kernel.org in order to ask for that. I also see that the
mtdblock_ro path was not corrected, maybe that's also a problem in your
case? Same, you can adapt the above patch and send it upstream.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Pintu Agarwal <pintu.ping@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-fsdevel@kvack.org, ezequiel@collabora.com, bjorn@mork.no
Subject: Re: MTD: Lots of mtdblock warnings on bootup logs
Date: Wed, 12 Jul 2023 16:22:13 +0200 [thread overview]
Message-ID: <20230712162213.79bc889c@xps-13> (raw)
In-Reply-To: <CAOuPNLizjBp_8ceKq=RLznXdsHD-+N55RoPh_D7_Mpkg7M-BwQ@mail.gmail.com>
Hi Pintu,
pintu.ping@gmail.com wrote on Wed, 12 Jul 2023 19:29:39 +0530:
> Hi,
>
> We are getting below warning messages in dmesg logs on a NAND device
> for every raw partition.
> Kernel: 5.15 ; arm64 ; NAND + ubi + squashfs
> We have some RAW partitions and one UBI partition (with ubifs/squashfs volumes).
>
> We are seeing large numbers of these logs on the serial console that
> impact the boot time.
> [....]
> [ 9.667240][ T9] Creating 58 MTD partitions on "1c98000.nand":
> [....]
> [ 39.975707][ T519] mtdblock: MTD device 'uefi_a' is NAND, please
> consider using UBI block devices instead.
> [ 39.975707][ T519] mtdblock: MTD device 'uefi_b' is NAND, please
> consider using UBI block devices instead.
> [....]
>
> This was added as part of this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/mtd/mtdblock.c?h=v5.15.120&id=f41c9418c5898c01634675150696da290fb86796
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/mtd/mtdblock.c?h=v5.15.120&id=e07403a8c6be01857ff75060b2df9a1aa8320fe5
>
> I think this warning was decided after my last year's discussion about
> mtdblock vs ubiblock for squashfs.
>
> But these are raw NAND partitions and not mounted by us.
>
> What is the exact meaning of these warnings ?
mtdblock is legacy, ubiblock is better (on NAND devices).
> We have both these configs enabled:
> CONFIG_MTD_BLOCK=y
> CONFIG_MTD_UBI_BLOCK=y
>
> Through this warning, are we telling that only one of the above config
> should be enabled ?
If you don't need both, then yes.
> And the recommendation is to use ubi_block and disable mtd_block ?
Yes.
> We are already using ubiblock for mounting squashfs volumes.
> But how to get rid of these warnings for raw NAND partitions ?
>
> Is there a way to avoid or we are missing something which we are not aware of?
>
In theory the warning should only appear if you open the device (IOW,
only if you use it). For this to happen, you need:
96a3295c351d ("mtdblock: warn if opened on NAND")
This commit was maybe not backported to stable kernels, you can send it
to stable@vger.kernel.org in order to ask for that. I also see that the
mtdblock_ro path was not corrected, maybe that's also a problem in your
case? Same, you can adapt the above patch and send it upstream.
Thanks,
Miquèl
next prev parent reply other threads:[~2023-07-12 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 13:59 MTD: Lots of mtdblock warnings on bootup logs Pintu Agarwal
2023-07-12 13:59 ` Pintu Agarwal
2023-07-12 14:22 ` Miquel Raynal [this message]
2023-07-12 14:22 ` Miquel Raynal
2023-07-12 14:28 ` Bjørn Mork
2023-07-12 14:28 ` Bjørn Mork
2023-07-12 18:25 ` Pintu Agarwal
2023-07-12 18:25 ` Pintu Agarwal
2023-07-12 19:11 ` Bjørn Mork
2023-07-12 19:11 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712162213.79bc889c@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=bjorn@mork.no \
--cc=ezequiel@collabora.com \
--cc=linux-fsdevel@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pintu.ping@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.