From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: "Liviu Dudau" <liviu.dudau@arm.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Liu Ying" <victor.liu@nxp.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Inki Dae" <inki.dae@samsung.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Russell King" <linux+etnaviv@armlinux.org.uk>,
"Christian Gmeiner" <christian.gmeiner@gmail.com>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Xinliang Liu" <xinliang.liu@linaro.org>,
"Tian Tao" <tiantao6@hisilicon.com>,
"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Yongqin Liu" <yongqin.liu@linaro.org>,
"John Stultz" <jstultz@google.com>,
"Laurentiu Palcu" <laurentiu.palcu@oss.nxp.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Qiang Yu" <yuq825@gmail.com>,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Rob Clark" <robdclark@gmail.com>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Sean Paul" <sean@poorly.run>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Marek Vasut" <marex@denx.de>, "Stefan Agner" <stefan@agner.ch>,
"Jerry Han" <hanxu5@huaqin.corp-partner.google.com>,
"Icenowy Zheng" <icenowy@aosc.io>, "Ondrej Jirman" <megi@xff.cz>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Guido Günther" <agx@sigxcpu.org>,
"Purism Kernel Team" <kernel@puri.sm>,
"Jianhua Lu" <lujianhua000@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Artur Weber" <aweber.kernel@gmail.com>,
"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
"Steven Price" <steven.price@arm.com>,
"Alyssa Rosenzweig" <alyssa.rosenzweig@collabora.com>,
"Emma Anholt" <emma@anholt.net>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Alain Volmat" <alain.volmat@foss.st.com>,
"Yannick Fertre" <yannick.fertre@foss.st.com>,
"Raphael Gallais-Pou" <raphael.gallais-pou@foss.st.com>,
"Philippe Cornu" <philippe.cornu@foss.st.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Mikko Perttunen" <mperttunen@nvidia.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Jyri Sarha" <jyri.sarha@iki.fi>,
"Tomi Valkeinen" <tomba@kernel.org>,
"Oleksandr Andrushchenko" <oleksandr_andrushchenko@epam.com>,
"Ondrej Jirman" <megous@megous.com>,
devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, etnaviv@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org,
freedreno@lists.freedesktop.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: Explicitly include correct DT includes
Date: Sat, 15 Jul 2023 22:19:08 +0200 [thread overview]
Message-ID: <20230715201908.GA321950@ravnborg.org> (raw)
In-Reply-To: <20230714174545.4056287-1-robh@kernel.org>
Hi Rob,
On Fri, Jul 14, 2023 at 11:45:34AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: "Xinliang Liu" <xinliang.liu@linaro.org>,
dri-devel@lists.freedesktop.org,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Steven Price" <steven.price@arm.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
"Robert Foss" <rfoss@kernel.org>,
"Samuel Holland" <samuel@sholland.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
linux-rockchip@lists.infradead.org,
"Guido Günther" <agx@sigxcpu.org>,
"Raphael Gallais-Pou" <raphael.gallais-pou@foss.st.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
etnaviv@lists.freedesktop.org, "Sean Paul" <sean@poorly.run>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
linux-kernel@vger.kernel.org, "Ondrej Jirman" <megi@xff.cz>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Icenowy Zheng" <icenowy@aosc.io>,
freedreno@lists.freedesktop.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Yongqin Liu" <yongqin.liu@linaro.org>,
lima@lists.freedesktop.org,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Liu Ying" <victor.liu@nxp.com>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Russell King" <linux+etnaviv@armlinux.org.uk>,
"Alain Volmat" <alain.volmat@foss.st.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
linux-arm-msm@vger.kernel.org,
"Maxime Ripard" <mripard@kernel.org>,
"Jianhua Lu" <lujianhua000@gmail.com>,
linux-rpi-kernel@lists.infradead.org,
"Tian Tao" <tiantao6@hisilicon.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
"Sandy Huang" <hjc@rock-chips.com>,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
linux-tegra@vger.kernel.org,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Alyssa Rosenzweig" <alyssa.rosenzweig@collabora.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
xen-devel@lists.xenproject.org,
"Tomi Valkeinen" <tomba@kernel.org>,
linux-sunxi@lists.linux.dev,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"John Stultz" <jstultz@google.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Ondrej Jirman" <megous@megous.com>,
linux-stm32@st-md-mailman.stormreply.com,
"Emma Anholt" <emma@anholt.net>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Mikko Perttunen" <mperttunen@nvidia.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Marek Vasut" <marex@denx.de>,
linux-renesas-soc@vger.kernel.org,
"Artur Weber" <aweber.kernel@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Oleksandr Andrushchenko" <oleksandr_andrushchenko@epam.com>,
"Jerry Han" <hanxu5@huaqin.corp-partner.google.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Qiang Yu" <yuq825@gmail.com>,
devicetree@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
linux-mediatek@lists.infradead.org,
"Laurentiu Palcu" <laurentiu.palcu@oss.nxp.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Purism Kernel Team" <kernel@puri.sm>,
"Yannick Fertre" <yannick.fertre@foss.st.com>,
linux-mips@vger.kernel.org,
"Philippe Cornu" <philippe.cornu@foss.st.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Jyri Sarha" <jyri.sarha@iki.fi>
Subject: Re: [PATCH] drm: Explicitly include correct DT includes
Date: Sat, 15 Jul 2023 22:19:08 +0200 [thread overview]
Message-ID: <20230715201908.GA321950@ravnborg.org> (raw)
In-Reply-To: <20230714174545.4056287-1-robh@kernel.org>
Hi Rob,
On Fri, Jul 14, 2023 at 11:45:34AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2023-07-15 20:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 17:45 [PATCH] drm: Explicitly include correct DT includes Rob Herring
2023-07-14 17:45 ` Rob Herring
2023-07-15 20:19 ` Sam Ravnborg [this message]
2023-07-15 20:19 ` Sam Ravnborg
2023-07-16 9:25 ` Heiko Stuebner
2023-07-16 9:25 ` Heiko Stuebner
2023-07-17 14:27 ` Rob Herring
2023-07-17 14:27 ` Rob Herring
2023-07-17 15:39 ` Robert Foss
2023-07-17 15:39 ` Robert Foss
2023-07-17 8:19 ` Steven Price
2023-07-17 8:19 ` Steven Price
2023-07-17 11:07 ` Liviu Dudau
2023-07-17 11:07 ` Liviu Dudau
2023-07-17 11:35 ` Kieran Bingham
2023-07-17 11:35 ` Kieran Bingham
2023-07-21 10:15 ` Thierry Reding
2023-07-21 10:15 ` Thierry Reding
2023-07-21 10:15 ` Thierry Reding
2023-07-21 10:15 ` Thierry Reding
2023-07-21 10:15 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230715201908.GA321950@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=agx@sigxcpu.org \
--cc=airlied@gmail.com \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aweber.kernel@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christian.gmeiner@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=etnaviv@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=freedreno@lists.freedesktop.org \
--cc=hanxu5@huaqin.corp-partner.google.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=icenowy@aosc.io \
--cc=inki.dae@samsung.com \
--cc=jagan@amarulasolutions.com \
--cc=javierm@redhat.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jonathanh@nvidia.com \
--cc=jstultz@google.com \
--cc=jyri.sarha@iki.fi \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=khilman@baylibre.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=laurentiu.palcu@oss.nxp.com \
--cc=lima@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lujianhua000@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=marijn.suijten@somainline.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=megi@xff.cz \
--cc=megous@megous.com \
--cc=mperttunen@nvidia.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=orsonzhai@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=paul@crapouillou.net \
--cc=philippe.cornu@foss.st.com \
--cc=quic_abhinavk@quicinc.com \
--cc=raphael.gallais-pou@foss.st.com \
--cc=rfoss@kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=steven.price@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tiantao6@hisilicon.com \
--cc=tomba@kernel.org \
--cc=tomeu.vizoso@collabora.com \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
--cc=wens@csie.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xinliang.liu@linaro.org \
--cc=yannick.fertre@foss.st.com \
--cc=yongqin.liu@linaro.org \
--cc=yuq825@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.