* [Buildroot] [PATCH v2 1/1] package/piglit: bump version
@ 2023-07-23 7:43 Bernd Kuhls
2023-07-23 15:25 ` Yann E. MORIN
[not found] ` <20230723152533.GH2503916__38229.4022989058$1690125967$gmane$org@scaer>
0 siblings, 2 replies; 5+ messages in thread
From: Bernd Kuhls @ 2023-07-23 7:43 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour
Disable Vulkan tests due to missing dependency libvulkan:
https://gitlab.freedesktop.org/mesa/piglit/-/commit/2519c330fba55ce6efd0dbee07aa67c703124d4f
Fixes python related build error:
AttributeError: module 'collections' has no attribute 'MutableMapping'
This build error first occured in the autobuilder logs on Jan 13, 2022:
http://autobuild.buildroot.net/results/ff6/ff6efa43102a56bb4b87401cd425a5241f0920cd/
The cause for this error is unknown as it seems unrelated to the piglit
version which was last bumped in 2020 with commit
9061fd7bf6855431939bdace7e3091d4e1c48e53.
Fixes:
http://autobuild.buildroot.net/results/ed3/ed3c5806458efdb9db78732d3709e1d6ec441bcb/
Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
v2: added known information about the build error (Thomas)
package/piglit/piglit.hash | 2 +-
package/piglit/piglit.mk | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/package/piglit/piglit.hash b/package/piglit/piglit.hash
index 923569a6f3..b10645c7a6 100644
--- a/package/piglit/piglit.hash
+++ b/package/piglit/piglit.hash
@@ -1,5 +1,5 @@
# Locally calculated
-sha256 ec2a80c49f10761980334f1591be54ee6f365165d7ac637270b4ca15a12ad674 piglit-2affee53f3ad7a96f5b397a2b6d6408af8a374b0-br1.tar.gz
+sha256 3505bbd3170cdb7cae0284613025ad31285e021fb4d09bcc6570ee05503b3314 piglit-ed58dfbd12be34fa3dab97a7a2987b890e0637f1-br1.tar.gz
sha256 dcc398730859aee7cc1d6aa57f526f8d181b47bb3a49830e85b5723d5bc2c3bc COPYING
sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 licences/GPL-2
sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 licences/GPL-3
diff --git a/package/piglit/piglit.mk b/package/piglit/piglit.mk
index 4d17405d10..da34d156ac 100644
--- a/package/piglit/piglit.mk
+++ b/package/piglit/piglit.mk
@@ -4,7 +4,7 @@
#
################################################################################
-PIGLIT_VERSION = 2affee53f3ad7a96f5b397a2b6d6408af8a374b0
+PIGLIT_VERSION = ed58dfbd12be34fa3dab97a7a2987b890e0637f1
PIGLIT_SITE = https://gitlab.freedesktop.org/mesa/piglit.git
PIGLIT_SITE_METHOD = git
PIGLIT_LICENSE = MIT (code), \
@@ -29,6 +29,7 @@ PIGLIT_DEPENDENCIES = host-pkgconf \
PIGLIT_CONF_OPTS += \
-DPIGLIT_USE_WAFFLE=ON \
-DPIGLIT_BUILD_CL_TESTS=OFF \
+ -DPIGLIT_BUILD_VK_TESTS=OFF \
-DPIGLIT_BUILD_WGL_TESTS=OFF \
-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH v2 1/1] package/piglit: bump version
2023-07-23 7:43 [Buildroot] [PATCH v2 1/1] package/piglit: bump version Bernd Kuhls
@ 2023-07-23 15:25 ` Yann E. MORIN
[not found] ` <20230723152533.GH2503916__38229.4022989058$1690125967$gmane$org@scaer>
1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2023-07-23 15:25 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: Romain Naour, buildroot
Bernd, All,
On 2023-07-23 09:43 +0200, Bernd Kuhls spake thusly:
> Disable Vulkan tests due to missing dependency libvulkan:
> https://gitlab.freedesktop.org/mesa/piglit/-/commit/2519c330fba55ce6efd0dbee07aa67c703124d4f
>
> Fixes python related build error:
> AttributeError: module 'collections' has no attribute 'MutableMapping'
>
> This build error first occured in the autobuilder logs on Jan 13, 2022:
> http://autobuild.buildroot.net/results/ff6/ff6efa43102a56bb4b87401cd425a5241f0920cd/
> The cause for this error is unknown
It is not unknown. A bit of searhing around turns up:
- https://stackoverflow.com/questions/69464512/django-rest-error-attributeerror-module-collections-has-no-attribute-mutab
- https://github.com/python/cpython/commit/c66f9f8d3909f588c251957d499599a1680e2320
- https://bugs.python.org/issue25988
So guess what hapenned not too long before 2022-01-13 when this piglit
issue first popped up? We bumped python from 3.9 to 3.10, which stopped
emitting deprecation warnings, and defeinitely dropped the ABCs imports
from collections, which now raise AttributeError, so now one must import
the ABCs from collections.abc.
So, it is not unknown; it is due to the python 3.10 bump.
Yet...
> as it seems unrelated to the piglit
> version which was last bumped in 2020 with commit
> 9061fd7bf6855431939bdace7e3091d4e1c48e53.
>
> Fixes:
> http://autobuild.buildroot.net/results/ed3/ed3c5806458efdb9db78732d3709e1d6ec441bcb/
This build failure is from 2022-10-04, almost a year ago now. Since
then, we haven't had such a failure again...
I'm OK for fixing a old build failure, but I'd like to understand why
it suddenly stopped appearing when nothing changed in the package, and
when python certainly did not reinstate MutableMapping in collections,
and so we should still hit it (at least once in a while).
Do you have a defconfig that still exhibit the issue? Do you know why
the autobuilders no longer report that issue?
Regards,
Yann E. MORIN.
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> v2: added known information about the build error (Thomas)
>
> package/piglit/piglit.hash | 2 +-
> package/piglit/piglit.mk | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/package/piglit/piglit.hash b/package/piglit/piglit.hash
> index 923569a6f3..b10645c7a6 100644
> --- a/package/piglit/piglit.hash
> +++ b/package/piglit/piglit.hash
> @@ -1,5 +1,5 @@
> # Locally calculated
> -sha256 ec2a80c49f10761980334f1591be54ee6f365165d7ac637270b4ca15a12ad674 piglit-2affee53f3ad7a96f5b397a2b6d6408af8a374b0-br1.tar.gz
> +sha256 3505bbd3170cdb7cae0284613025ad31285e021fb4d09bcc6570ee05503b3314 piglit-ed58dfbd12be34fa3dab97a7a2987b890e0637f1-br1.tar.gz
> sha256 dcc398730859aee7cc1d6aa57f526f8d181b47bb3a49830e85b5723d5bc2c3bc COPYING
> sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 licences/GPL-2
> sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 licences/GPL-3
> diff --git a/package/piglit/piglit.mk b/package/piglit/piglit.mk
> index 4d17405d10..da34d156ac 100644
> --- a/package/piglit/piglit.mk
> +++ b/package/piglit/piglit.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -PIGLIT_VERSION = 2affee53f3ad7a96f5b397a2b6d6408af8a374b0
> +PIGLIT_VERSION = ed58dfbd12be34fa3dab97a7a2987b890e0637f1
> PIGLIT_SITE = https://gitlab.freedesktop.org/mesa/piglit.git
> PIGLIT_SITE_METHOD = git
> PIGLIT_LICENSE = MIT (code), \
> @@ -29,6 +29,7 @@ PIGLIT_DEPENDENCIES = host-pkgconf \
> PIGLIT_CONF_OPTS += \
> -DPIGLIT_USE_WAFFLE=ON \
> -DPIGLIT_BUILD_CL_TESTS=OFF \
> + -DPIGLIT_BUILD_VK_TESTS=OFF \
> -DPIGLIT_BUILD_WGL_TESTS=OFF \
> -DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3
>
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <20230723152533.GH2503916__38229.4022989058$1690125967$gmane$org@scaer>]
* Re: [Buildroot] [PATCH v2 1/1] package/piglit: bump version
[not found] ` <20230723152533.GH2503916__38229.4022989058$1690125967$gmane$org@scaer>
@ 2023-07-23 16:24 ` Bernd Kuhls
0 siblings, 0 replies; 5+ messages in thread
From: Bernd Kuhls @ 2023-07-23 16:24 UTC (permalink / raw)
To: buildroot
Hi Yann,
Am Sun, 23 Jul 2023 17:25:33 +0200 schrieb Yann E. MORIN:
> It is not unknown. A bit of searhing around turns up:
at least it was unknown for me ;) Thanks for the insight.
> Yet...
>
>> as it seems unrelated to the piglit version which was last bumped in
>> 2020 with commit 9061fd7bf6855431939bdace7e3091d4e1c48e53.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/ed3/
ed3c5806458efdb9db78732d3709e1d6ec441bcb/
>
> This build failure is from 2022-10-04, almost a year ago now. Since
> then, we haven't had such a failure again...
>
[...]
> Do you have a defconfig that still exhibit the issue?
Yes, the one from the autobuilder error mentioned above. A couple of
minutes ago I could reproduce the build error with that defconfig.
> Do you know why the autobuilders no longer report that issue?
Just guessing: The dependencies of piglit are so complicated (waffle + glx
& co.) that random defconfigs seldomly produce a defconfig with piglit
enabled, especially since https://git.busybox.net/buildroot/commit/utils/
genrandconfig?id=0e64537917a5b27565b8c479fda83508a6da7b86
Regards, Bernd
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/piglit: bump version
@ 2025-12-28 12:43 Bernd Kuhls
2025-12-28 23:07 ` Julien Olivain via buildroot
0 siblings, 1 reply; 5+ messages in thread
From: Bernd Kuhls @ 2025-12-28 12:43 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour
Disabled vulkan tests added by upstream commit:
https://gitlab.freedesktop.org/mesa/piglit/-/commit/2519c330fba55ce6efd0dbee07aa67c703124d4f
Added X11-related configure options due to upstream commit:
https://gitlab.freedesktop.org/mesa/piglit/-/commit/d958b70d1fc5c2ee039363d862b14ca498a50e82
Added configure options to fix build errors without libdrm and with
libegl/libgles enabled but without X11.
These build errors were not seen before due to other build errors
unfixed since the bump of python3 to 3.10 with buildroot commit
25b1fc2898d68ddf2674b14c738045875fc5a2dc:
https://patchwork.ozlabs.org/project/buildroot/patch/20230723074303.603364-1-bernd@kuhls.net/
Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
v2: added more build fixes (Julien)
bumped version to current HEAD
package/piglit/piglit.hash | 2 +-
package/piglit/piglit.mk | 15 +++++++++++++--
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/package/piglit/piglit.hash b/package/piglit/piglit.hash
index 2c0b6aa52a..a778401253 100644
--- a/package/piglit/piglit.hash
+++ b/package/piglit/piglit.hash
@@ -1,5 +1,5 @@
# Locally calculated
-sha256 ba4d1839038905f3833e9ab23b385913e08d552533dd222cc203c79c10e09918 piglit-2affee53f3ad7a96f5b397a2b6d6408af8a374b0-git4.tar.gz
+sha256 0553524e1bfce646771560805cbe523204c59dcee20dc58bb9baa87134a50ea1 piglit-62d499d63d2b8b29a67efd9d93ed9b6a94d4950e-git4.tar.gz
sha256 dcc398730859aee7cc1d6aa57f526f8d181b47bb3a49830e85b5723d5bc2c3bc COPYING
sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 licences/GPL-2
sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 licences/GPL-3
diff --git a/package/piglit/piglit.mk b/package/piglit/piglit.mk
index 4d17405d10..360bddd40e 100644
--- a/package/piglit/piglit.mk
+++ b/package/piglit/piglit.mk
@@ -4,7 +4,7 @@
#
################################################################################
-PIGLIT_VERSION = 2affee53f3ad7a96f5b397a2b6d6408af8a374b0
+PIGLIT_VERSION = 62d499d63d2b8b29a67efd9d93ed9b6a94d4950e
PIGLIT_SITE = https://gitlab.freedesktop.org/mesa/piglit.git
PIGLIT_SITE_METHOD = git
PIGLIT_LICENSE = MIT (code), \
@@ -29,16 +29,27 @@ PIGLIT_DEPENDENCIES = host-pkgconf \
PIGLIT_CONF_OPTS += \
-DPIGLIT_USE_WAFFLE=ON \
-DPIGLIT_BUILD_CL_TESTS=OFF \
+ -DPIGLIT_BUILD_VK_TESTS=OFF \
-DPIGLIT_BUILD_WGL_TESTS=OFF \
-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3
ifeq ($(BR2_PACKAGE_XORG7),y)
# libxcb for xcb-dri2
+PIGLIT_CONF_OPTS += -DPIGLIT_USE_X11=ON
PIGLIT_DEPENDENCIES += \
xlib_libX11 \
xlib_libXext \
xorgproto \
$(if $(BR2_PACKAGE_LIBXCB),libxcb)
+else
+PIGLIT_CONF_OPTS += -DPIGLIT_USE_X11=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_HAS_LIBDRM),y)
+PIGLIT_DEPENDENCIES += libdrm
+PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_DMA_BUF_TESTS=ON
+else
+PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_DMA_BUF_TESTS=OFF
endif
ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
@@ -54,7 +65,7 @@ else
PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_GLX_TESTS=OFF
endif
-ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yy)
+ifeq ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yyy)
PIGLIT_DEPENDENCIES += libegl
PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_GLES1_TESTS=ON \
-DPIGLIT_BUILD_GLES2_TESTS=ON \
--
2.47.3
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH v2 1/1] package/piglit: bump version
2025-12-28 12:43 Bernd Kuhls
@ 2025-12-28 23:07 ` Julien Olivain via buildroot
0 siblings, 0 replies; 5+ messages in thread
From: Julien Olivain via buildroot @ 2025-12-28 23:07 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: buildroot, Romain Naour
Hi Bernd,
Thanks for the updated patch.
On 28/12/2025 13:43, Bernd Kuhls wrote:
> Disabled vulkan tests added by upstream commit:
> https://gitlab.freedesktop.org/mesa/piglit/-/commit/2519c330fba55ce6efd0dbee07aa67c703124d4f
>
> Added X11-related configure options due to upstream commit:
> https://gitlab.freedesktop.org/mesa/piglit/-/commit/d958b70d1fc5c2ee039363d862b14ca498a50e82
>
> Added configure options to fix build errors without libdrm and with
> libegl/libgles enabled but without X11.
> These build errors were not seen before due to other build errors
> unfixed since the bump of python3 to 3.10 with buildroot commit
> 25b1fc2898d68ddf2674b14c738045875fc5a2dc:
> https://patchwork.ozlabs.org/project/buildroot/patch/20230723074303.603364-1-bernd@kuhls.net/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> v2: added more build fixes (Julien)
> bumped version to current HEAD
[...]
> diff --git a/package/piglit/piglit.mk b/package/piglit/piglit.mk
> index 4d17405d10..360bddd40e 100644
> --- a/package/piglit/piglit.mk
> +++ b/package/piglit/piglit.mk
> @@ -4,7 +4,7 @@
> #
>
> ################################################################################
>
> -PIGLIT_VERSION = 2affee53f3ad7a96f5b397a2b6d6408af8a374b0
> +PIGLIT_VERSION = 62d499d63d2b8b29a67efd9d93ed9b6a94d4950e
> PIGLIT_SITE = https://gitlab.freedesktop.org/mesa/piglit.git
> PIGLIT_SITE_METHOD = git
> PIGLIT_LICENSE = MIT (code), \
> @@ -29,16 +29,27 @@ PIGLIT_DEPENDENCIES = host-pkgconf \
> PIGLIT_CONF_OPTS += \
> -DPIGLIT_USE_WAFFLE=ON \
> -DPIGLIT_BUILD_CL_TESTS=OFF \
> + -DPIGLIT_BUILD_VK_TESTS=OFF \
> -DPIGLIT_BUILD_WGL_TESTS=OFF \
> -DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3
>
> ifeq ($(BR2_PACKAGE_XORG7),y)
> # libxcb for xcb-dri2
> +PIGLIT_CONF_OPTS += -DPIGLIT_USE_X11=ON
> PIGLIT_DEPENDENCIES += \
> xlib_libX11 \
> xlib_libXext \
> xorgproto \
> $(if $(BR2_PACKAGE_LIBXCB),libxcb)
> +else
> +PIGLIT_CONF_OPTS += -DPIGLIT_USE_X11=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_HAS_LIBDRM),y)
Here, the "utils/check-symbols" script reports the error:
package/piglit/piglit.mk:48: BR2_PACKAGE_HAS_LIBDRM referenced but not
defined
I believe you meant "BR2_PACKAGE_LIBDRM".
Also, fixing this symbol name alone does not seem sufficient.
When testing with the following commands:
cat >.config <<EOF
BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_PACKAGE_PIGLIT=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SOFTPIPE=y
BR2_PACKAGE_MESA3D_OPENGL_EGL=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_WESTON=y
BR2_PACKAGE_PYTHON3=y
EOF
make olddefconfig
make piglit
The piglit meson configuration fails with error:
CMake Error at CMakeLists.txt:271 (message):
PIGLIT_BUILD_DMA_BUF_TESTS require libdrm, gbm_bo_map(),
libdrm>=2.4.98 and
xcb-dri2
So maybe this line should rather be:
ifeq ($(BR2_PACKAGE_LIBDRM)$(BR2_PACKAGE_LIBXCB),yy)
> +PIGLIT_DEPENDENCIES += libdrm
> +PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_DMA_BUF_TESTS=ON
> +else
> +PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_DMA_BUF_TESTS=OFF
> endif
>
> ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
> @@ -54,7 +65,7 @@ else
> PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_GLX_TESTS=OFF
> endif
>
> -ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yy)
> +ifeq
> ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yyy)
> PIGLIT_DEPENDENCIES += libegl
> PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_GLES1_TESTS=ON \
> -DPIGLIT_BUILD_GLES2_TESTS=ON \
> --
> 2.47.3
Could you confirm and send an updated patch, please?
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-12-28 23:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-23 7:43 [Buildroot] [PATCH v2 1/1] package/piglit: bump version Bernd Kuhls
2023-07-23 15:25 ` Yann E. MORIN
[not found] ` <20230723152533.GH2503916__38229.4022989058$1690125967$gmane$org@scaer>
2023-07-23 16:24 ` Bernd Kuhls
-- strict thread matches above, loose matches on Subject: below --
2025-12-28 12:43 Bernd Kuhls
2025-12-28 23:07 ` Julien Olivain via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.