All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Atul Raut <rauji.raut@gmail.com>
Cc: Larysa Zaremba <larysa.zaremba@intel.com>,
	netdev@vger.kernel.org, avem@davemloft.net, rafal@milecki.pl,
	pabeni@redhat.com,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] net/macmace: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
Date: Tue, 1 Aug 2023 14:51:15 -0700	[thread overview]
Message-ID: <20230801145115.153f3629@kernel.org> (raw)
In-Reply-To: <ZMkSIfUEnvYvHyZx@lincoln>

On Tue, 1 Aug 2023 16:09:37 +0200 Larysa Zaremba wrote:
> > > -	u8	data[1];
> > > +	DECLARE_FLEX_ARRAY(u8, data);  
> > 
> > But data[1] is not zero-length array.
> 
> So, please, if you are certain that data should be a flexible array,
> send v2 without calling data a zero-length array. Also, with such change, I 
> think driver code could be improved in many places in the same patchset.

Atul, you should respond to reviewers promptly. These are legit
questions.
On closer inspection the patch looks fine so to avoid clogging up 
the review queue and wasting more time on it I'm just going to apply it.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Atul Raut <rauji.raut@gmail.com>
Cc: Larysa Zaremba <larysa.zaremba@intel.com>, <avem@davemloft.net>,
	<netdev@vger.kernel.org>, <pabeni@redhat.com>, <rafal@milecki.pl>,
	<linux-kernel-mentees@lists.linuxfoundation.org>
Subject: Re: [PATCH] net/macmace: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
Date: Tue, 1 Aug 2023 14:51:15 -0700	[thread overview]
Message-ID: <20230801145115.153f3629@kernel.org> (raw)
In-Reply-To: <ZMkSIfUEnvYvHyZx@lincoln>

On Tue, 1 Aug 2023 16:09:37 +0200 Larysa Zaremba wrote:
> > > -	u8	data[1];
> > > +	DECLARE_FLEX_ARRAY(u8, data);  
> > 
> > But data[1] is not zero-length array.
> 
> So, please, if you are certain that data should be a flexible array,
> send v2 without calling data a zero-length array. Also, with such change, I 
> think driver code could be improved in many places in the same patchset.

Atul, you should respond to reviewers promptly. These are legit
questions.
On closer inspection the patch looks fine so to avoid clogging up 
the review queue and wasting more time on it I'm just going to apply it.

  reply	other threads:[~2023-08-01 21:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-30 23:14 [PATCH] net/macmace: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Atul Raut
2023-07-30 23:14 ` Atul Raut
2023-07-31  7:38 ` Leon Romanovsky
2023-07-31  7:38   ` Leon Romanovsky
2023-08-01 14:09   ` Larysa Zaremba
2023-08-01 14:09     ` Larysa Zaremba
2023-08-01 21:51     ` Jakub Kicinski [this message]
2023-08-01 21:51       ` Jakub Kicinski
2023-08-01 22:00 ` patchwork-bot+netdevbpf
2023-08-01 22:00   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230801145115.153f3629@kernel.org \
    --to=kuba@kernel.org \
    --cc=avem@davemloft.net \
    --cc=larysa.zaremba@intel.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rafal@milecki.pl \
    --cc=rauji.raut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.