From: Larysa Zaremba <larysa.zaremba@intel.com>
To: Atul Raut <rauji.raut@gmail.com>
Cc: Larysa Zaremba <larysa.zaremba@intel.com>,
netdev@vger.kernel.org, avem@davemloft.net, rafal@milecki.pl,
Atul Raut <rauji.raut@gmail.com>,
kuba@kernel.org, pabeni@redhat.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] net/macmace: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
Date: Tue, 1 Aug 2023 16:09:37 +0200 [thread overview]
Message-ID: <ZMkSIfUEnvYvHyZx@lincoln> (raw)
In-Reply-To: <20230731073801.GA87829@unreal>
On Mon, Jul 31, 2023 at 10:38:01AM +0300, Leon Romanovsky wrote:
> On Sun, Jul 30, 2023 at 04:14:42PM -0700, Atul Raut wrote:
> > Since zero-length arrays are deprecated, we are replacing
> > them with C99 flexible-array members. As a result, instead
> > of declaring a zero-length array, use the new
> > DECLARE_FLEX_ARRAY() helper macro.
> >
> > This fixes warnings such as:
> > ./drivers/net/ethernet/apple/macmace.c:80:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> >
> > Signed-off-by: Atul Raut <rauji.raut@gmail.com>
> > ---
> > drivers/net/ethernet/apple/macmace.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/apple/macmace.c b/drivers/net/ethernet/apple/macmace.c
> > index 8fcaf1639920..8775c3234e91 100644
> > --- a/drivers/net/ethernet/apple/macmace.c
> > +++ b/drivers/net/ethernet/apple/macmace.c
> > @@ -77,7 +77,7 @@ struct mace_frame {
> > u8 pad4;
> > u32 pad5;
> > u32 pad6;
> > - u8 data[1];
> > + DECLARE_FLEX_ARRAY(u8, data);
>
> But data[1] is not zero-length array.
>
So, please, if you are certain that data should be a flexible array,
send v2 without calling data a zero-length array. Also, with such change, I
think driver code could be improved in many places in the same patchset.
> > /* And frame continues.. */
> > };
> >
> > --
> > 2.34.1
> >
> >
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Larysa Zaremba <larysa.zaremba@intel.com>
To: Atul Raut <rauji.raut@gmail.com>
Cc: Larysa Zaremba <larysa.zaremba@intel.com>,
Atul Raut <rauji.raut@gmail.com>, <avem@davemloft.net>,
<netdev@vger.kernel.org>, <kuba@kernel.org>, <pabeni@redhat.com>,
<rafal@milecki.pl>,
<linux-kernel-mentees@lists.linuxfoundation.org>
Subject: Re: [PATCH] net/macmace: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
Date: Tue, 1 Aug 2023 16:09:37 +0200 [thread overview]
Message-ID: <ZMkSIfUEnvYvHyZx@lincoln> (raw)
In-Reply-To: <20230731073801.GA87829@unreal>
On Mon, Jul 31, 2023 at 10:38:01AM +0300, Leon Romanovsky wrote:
> On Sun, Jul 30, 2023 at 04:14:42PM -0700, Atul Raut wrote:
> > Since zero-length arrays are deprecated, we are replacing
> > them with C99 flexible-array members. As a result, instead
> > of declaring a zero-length array, use the new
> > DECLARE_FLEX_ARRAY() helper macro.
> >
> > This fixes warnings such as:
> > ./drivers/net/ethernet/apple/macmace.c:80:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> >
> > Signed-off-by: Atul Raut <rauji.raut@gmail.com>
> > ---
> > drivers/net/ethernet/apple/macmace.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/apple/macmace.c b/drivers/net/ethernet/apple/macmace.c
> > index 8fcaf1639920..8775c3234e91 100644
> > --- a/drivers/net/ethernet/apple/macmace.c
> > +++ b/drivers/net/ethernet/apple/macmace.c
> > @@ -77,7 +77,7 @@ struct mace_frame {
> > u8 pad4;
> > u32 pad5;
> > u32 pad6;
> > - u8 data[1];
> > + DECLARE_FLEX_ARRAY(u8, data);
>
> But data[1] is not zero-length array.
>
So, please, if you are certain that data should be a flexible array,
send v2 without calling data a zero-length array. Also, with such change, I
think driver code could be improved in many places in the same patchset.
> > /* And frame continues.. */
> > };
> >
> > --
> > 2.34.1
> >
> >
>
next prev parent reply other threads:[~2023-08-01 14:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 23:14 [PATCH] net/macmace: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Atul Raut
2023-07-30 23:14 ` Atul Raut
2023-07-31 7:38 ` Leon Romanovsky
2023-07-31 7:38 ` Leon Romanovsky
2023-08-01 14:09 ` Larysa Zaremba [this message]
2023-08-01 14:09 ` Larysa Zaremba
2023-08-01 21:51 ` Jakub Kicinski
2023-08-01 21:51 ` Jakub Kicinski
2023-08-01 22:00 ` patchwork-bot+netdevbpf
2023-08-01 22:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMkSIfUEnvYvHyZx@lincoln \
--to=larysa.zaremba@intel.com \
--cc=avem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
--cc=rauji.raut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.