From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ashwin Dayanand Kamat <kashwindayan@vmware.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Wen Gong <wgong@codeaurora.org>,
Jouni Malinen <jouni@codeaurora.org>,
Johannes Berg <johannes.berg@intel.com>,
davem@davemloft.net, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
akaher@vmware.com, vsirnapalli@vmware.com, tkundu@vmware.com,
namit@vmware.com
Subject: Re: [PATCH v4.19.y] ath10k: Fix TKIP Michael MIC verification for PCIe
Date: Fri, 4 Aug 2023 12:28:18 +0200 [thread overview]
Message-ID: <2023080408-squad-pony-2638@gregkh> (raw)
In-Reply-To: <1690971733-22270-1-git-send-email-kashwindayan@vmware.com>
On Wed, Aug 02, 2023 at 03:52:13PM +0530, Ashwin Dayanand Kamat wrote:
> From: Wen Gong <wgong@codeaurora.org>
>
> commit 0dc267b13f3a7e8424a898815dd357211b737330 upstream.
>
> TKIP Michael MIC was not verified properly for PCIe cases since the
> validation steps in ieee80211_rx_h_michael_mic_verify() in mac80211 did
> not get fully executed due to unexpected flag values in
> ieee80211_rx_status.
>
> Fix this by setting the flags property to meet mac80211 expectations for
> performing Michael MIC validation there. This fixes CVE-2020-26141. It
> does the same as ath10k_htt_rx_proc_rx_ind_hl() for SDIO which passed
> MIC verification case. This applies only to QCA6174/QCA9377 PCIe.
>
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
> Link: https://lore.kernel.org/r/20210511200110.c3f1d42c6746.I795593fcaae941c471425b8c7d5f7bb185d29142@changeid
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Ashwin Dayanand Kamat <kashwindayan@vmware.com>
> ---
> drivers/net/wireless/ath/ath10k/htt_rx.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Now queued up, thanks.
greg k-h
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ashwin Dayanand Kamat <kashwindayan@vmware.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Wen Gong <wgong@codeaurora.org>,
Jouni Malinen <jouni@codeaurora.org>,
Johannes Berg <johannes.berg@intel.com>,
davem@davemloft.net, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
akaher@vmware.com, vsirnapalli@vmware.com, tkundu@vmware.com,
namit@vmware.com
Subject: Re: [PATCH v4.19.y] ath10k: Fix TKIP Michael MIC verification for PCIe
Date: Fri, 4 Aug 2023 12:28:18 +0200 [thread overview]
Message-ID: <2023080408-squad-pony-2638@gregkh> (raw)
In-Reply-To: <1690971733-22270-1-git-send-email-kashwindayan@vmware.com>
On Wed, Aug 02, 2023 at 03:52:13PM +0530, Ashwin Dayanand Kamat wrote:
> From: Wen Gong <wgong@codeaurora.org>
>
> commit 0dc267b13f3a7e8424a898815dd357211b737330 upstream.
>
> TKIP Michael MIC was not verified properly for PCIe cases since the
> validation steps in ieee80211_rx_h_michael_mic_verify() in mac80211 did
> not get fully executed due to unexpected flag values in
> ieee80211_rx_status.
>
> Fix this by setting the flags property to meet mac80211 expectations for
> performing Michael MIC validation there. This fixes CVE-2020-26141. It
> does the same as ath10k_htt_rx_proc_rx_ind_hl() for SDIO which passed
> MIC verification case. This applies only to QCA6174/QCA9377 PCIe.
>
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
> Link: https://lore.kernel.org/r/20210511200110.c3f1d42c6746.I795593fcaae941c471425b8c7d5f7bb185d29142@changeid
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Ashwin Dayanand Kamat <kashwindayan@vmware.com>
> ---
> drivers/net/wireless/ath/ath10k/htt_rx.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2023-08-04 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 10:22 [PATCH v4.19.y] ath10k: Fix TKIP Michael MIC verification for PCIe Ashwin Dayanand Kamat
2023-08-02 10:22 ` Ashwin Dayanand Kamat
2023-08-04 10:28 ` Greg Kroah-Hartman [this message]
2023-08-04 10:28 ` Greg Kroah-Hartman
2023-08-04 10:42 ` Greg Kroah-Hartman
2023-08-04 10:42 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080408-squad-pony-2638@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akaher@vmware.com \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=johannes.berg@intel.com \
--cc=jouni@codeaurora.org \
--cc=kashwindayan@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=namit@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tkundu@vmware.com \
--cc=vsirnapalli@vmware.com \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.