From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-nvme@lists.infradead.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Wen Xiong <wenxiong@linux.ibm.com>,
Keith Busch <kbusch@kernel.org>,
linuxppc-dev@lists.ozlabs.org, Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Baoquan He <bhe@redhat.com>, Pingfan Liu <piliu@redhat.com>
Subject: Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()
Date: Fri, 11 Aug 2023 15:10:49 +0200 [thread overview]
Message-ID: <20230811131049.GA20991@lst.de> (raw)
In-Reply-To: <ZNQqt1C0pXspGl3d@fedora>
On Thu, Aug 10, 2023 at 08:09:27AM +0800, Ming Lei wrote:
> 1) some archs support 'nr_cpus=1' for kdump kernel, which is fine, since
> num_possible_cpus becomes 1.
>
> 2) some archs do not support 'nr_cpus=1', and have to rely on
> 'max_cpus=1', so num_possible_cpus isn't changed, and kernel just boots
> with single online cpu. That causes trouble because blk-mq limits single
> queue.
And we need to fix case 2. We need to drop the is_kdump support, and
if they want to force less cpus they need to make nr_cpus=1 work.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-nvme@lists.infradead.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Wen Xiong <wenxiong@linux.ibm.com>,
Keith Busch <kbusch@kernel.org>,
linuxppc-dev@lists.ozlabs.org, Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Baoquan He <bhe@redhat.com>, Pingfan Liu <piliu@redhat.com>
Subject: Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()
Date: Fri, 11 Aug 2023 15:10:49 +0200 [thread overview]
Message-ID: <20230811131049.GA20991@lst.de> (raw)
In-Reply-To: <ZNQqt1C0pXspGl3d@fedora>
On Thu, Aug 10, 2023 at 08:09:27AM +0800, Ming Lei wrote:
> 1) some archs support 'nr_cpus=1' for kdump kernel, which is fine, since
> num_possible_cpus becomes 1.
>
> 2) some archs do not support 'nr_cpus=1', and have to rely on
> 'max_cpus=1', so num_possible_cpus isn't changed, and kernel just boots
> with single online cpu. That causes trouble because blk-mq limits single
> queue.
And we need to fix case 2. We need to drop the is_kdump support, and
if they want to force less cpus they need to make nr_cpus=1 work.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Pingfan Liu <piliu@redhat.com>,
Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Wen Xiong <wenxiong@linux.ibm.com>, Baoquan He <bhe@redhat.com>,
Keith Busch <kbusch@kernel.org>,
linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()
Date: Fri, 11 Aug 2023 15:10:49 +0200 [thread overview]
Message-ID: <20230811131049.GA20991@lst.de> (raw)
In-Reply-To: <ZNQqt1C0pXspGl3d@fedora>
On Thu, Aug 10, 2023 at 08:09:27AM +0800, Ming Lei wrote:
> 1) some archs support 'nr_cpus=1' for kdump kernel, which is fine, since
> num_possible_cpus becomes 1.
>
> 2) some archs do not support 'nr_cpus=1', and have to rely on
> 'max_cpus=1', so num_possible_cpus isn't changed, and kernel just boots
> with single online cpu. That causes trouble because blk-mq limits single
> queue.
And we need to fix case 2. We need to drop the is_kdump support, and
if they want to force less cpus they need to make nr_cpus=1 work.
next prev parent reply other threads:[~2023-08-11 13:11 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 10:42 [PATCH V3 0/14] blk-mq: fix wrong queue mapping for kdump kernel Ming Lei
2023-08-08 10:42 ` [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues() Ming Lei
2023-08-09 13:44 ` Christoph Hellwig
2023-08-10 0:09 ` Ming Lei
2023-08-10 0:09 ` Ming Lei
2023-08-10 0:09 ` Ming Lei
2023-08-10 1:18 ` Baoquan He
2023-08-10 1:18 ` Baoquan He
2023-08-10 1:18 ` Baoquan He
2023-08-10 2:06 ` Ming Lei
2023-08-10 2:06 ` Ming Lei
2023-08-10 2:06 ` Ming Lei
2023-08-10 3:01 ` Baoquan He
2023-08-10 3:01 ` Baoquan He
2023-08-10 3:01 ` Baoquan He
2023-08-11 7:53 ` Hari Bathini
2023-08-11 7:53 ` Hari Bathini
2023-08-11 7:53 ` Hari Bathini
2023-09-05 5:03 ` Baoquan He
2023-09-05 5:03 ` Baoquan He
2023-09-05 5:03 ` Baoquan He
2023-08-11 13:10 ` Christoph Hellwig [this message]
2023-08-11 13:10 ` Christoph Hellwig
2023-08-11 13:10 ` Christoph Hellwig
2023-08-08 10:42 ` [PATCH V3 02/14] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues Ming Lei
2023-08-08 10:42 ` [PATCH V3 03/14] ublk: limit max allowed nr_hw_queues Ming Lei
2023-08-08 10:42 ` [PATCH V3 04/14] virtio-blk: limit max allowed submit queues Ming Lei
2023-08-08 10:42 ` Ming Lei
2023-08-10 19:23 ` Michael S. Tsirkin
2023-08-10 19:23 ` Michael S. Tsirkin
2023-08-08 10:42 ` [PATCH V3 05/14] scsi: core: add helper of scsi_max_nr_hw_queues() Ming Lei
2023-08-08 10:42 ` [PATCH V3 06/14] scsi: lpfc: use blk_mq_max_nr_hw_queues() to calculate io vectors Ming Lei
2023-08-08 10:42 ` [PATCH V3 07/14] scsi: mpi3mr: take blk_mq_max_nr_hw_queues() into account for calculating " Ming Lei
2023-08-08 10:42 ` [PATCH V3 08/14] scsi: megaraid: " Ming Lei
2023-08-08 10:42 ` [PATCH V3 09/14] scsi: mpt3sas: " Ming Lei
2023-08-08 10:42 ` [PATCH V3 10/14] scsi: pm8001: " Ming Lei
2023-08-08 10:42 ` [PATCH V3 11/14] scsi: hisi: " Ming Lei
2023-08-08 10:42 ` [PATCH V3 12/14] scsi: ufs: limit max allowed nr_hw_queues Ming Lei
2023-08-08 10:42 ` [PATCH V3 13/14] scsi: storvsc: " Ming Lei
2023-08-08 10:42 ` [PATCH V3 14/14] blk-mq: add helpers for treating kdump kernel Ming Lei
2023-08-10 8:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811131049.GA20991@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kbusch@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=piliu@redhat.com \
--cc=wenxiong@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.