[intel-lts:4.14/yocto/base 5042/28962] drivers/media/i2c/max9286.c:758:4: warning: no previous declaration for 'get_output_link_order'

[intel-lts:4.14/yocto/base 5042/28962] drivers/media/i2c/max9286.c:758:4: warning: no previous declaration for 'get_output_link_order'

[kernel test robot]

Hi kbandi,

FYI, the error/warning still remains.

tree:   https://github.com/intel/linux-intel-lts.git 4.14/yocto/base
head:   65b8aaa4ae7a568d08d64eeee7b09f26f711c78f
commit: 9cef7f9b88549f0e9b46631edd29e5f619afa928 [5042/28962] media: intel-ipu: Merge IPU kernel driver into 4.14 kernel
config: i386-randconfig-i011-20230811 (https://download.01.org/0day-ci/archive/20230811/202308111828.Rosp39bL-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce: (https://download.01.org/0day-ci/archive/20230811/202308111828.Rosp39bL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308111828.Rosp39bL-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/i2c/max9286.c: In function 'max96705_write_register':
   drivers/media/i2c/max9286.c:115:11: warning: comparison is always false due to limited range of data type [-Wtype-limits]
      if (val < 0)
              ^
   drivers/media/i2c/max9286.c:108:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     int ret;
         ^~~
   drivers/media/i2c/max9286.c: At top level:
>> drivers/media/i2c/max9286.c:758:4: warning: no previous declaration for 'get_output_link_order' [-Wmissing-declarations]
    u8 get_output_link_order(struct max9286 *max)
       ^~~~~~~~~~~~~~~~~~~~~


vim +/get_output_link_order +758 drivers/media/i2c/max9286.c

   749	
   750	/*
   751	 * Get the output link order
   752	 * By default:
   753	 * bits[7:6] 11: Link 3 is 4th in the CSI-2 output order
   754	 * bits[5:4] 10: Link 2 is 3rd in the CSI-2 output order
   755	 * bits[3:2] 01: Link 1 is 2nd in the CSI-2 output order
   756	 * bits[1:0] 00: Link 0 is 1st in the CSI-2 output order
   757	 */
 > 758	u8 get_output_link_order(struct max9286 *max)
   759	{
   760		u8 val = 0xE4, i;
   761		u8 order_config[14][3] = {
   762			{1, 8, 0x27},
   763			{1, 4, 0xC6},
   764			{1, 2, 0xE1},
   765			{1, 1, 0xE4},
   766			{2, 0xC, 0x4E},
   767			{2, 0xA, 0x72},
   768			{2, 0x9, 0x78},
   769			{2, 0x6, 0xD2},
   770			{2, 0x5, 0xD8},
   771			{2, 0x3, 0xE4},
   772			{3, 0xE, 0x93},
   773			{3, 0xD, 0x9C},
   774			{3, 0xB, 0xB4},
   775			{3, 0x7, 0xE4},
   776		};
   777	
   778		if (max->total_sensor_num < 4) {
   779			for (i = 0; i < 14; i++) {
   780				if ((max->total_sensor_num == order_config[i][0])
   781					&& (max->sensor_present == order_config[i][1]))
   782					return  order_config[i][2];
   783			}
   784		}
   785	
   786		/* sensor_num = 4 will return 0xE4 */
   787		return val;
   788	}
   789	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki