From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Ben Skeggs <bskeggs@redhat.com>,
Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH 2/2][next] nouveau/svm: Split assignment from if conditional
Date: Wed, 16 Aug 2023 13:38:58 -0700 [thread overview]
Message-ID: <202308161338.C7162E7@keescook> (raw)
In-Reply-To: <6b900e80b5587187c68efc788f5b042ca747d374.1692208802.git.gustavoars@kernel.org>
On Wed, Aug 16, 2023 at 12:05:06PM -0600, Gustavo A. R. Silva wrote:
> Fix checkpatch.pl ERROR: do not use assignment in if condition.
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Ben Skeggs <bskeggs@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>,
linux-hardening@vger.kernel.org
Subject: Re: [Nouveau] [PATCH 2/2][next] nouveau/svm: Split assignment from if conditional
Date: Wed, 16 Aug 2023 13:38:58 -0700 [thread overview]
Message-ID: <202308161338.C7162E7@keescook> (raw)
In-Reply-To: <6b900e80b5587187c68efc788f5b042ca747d374.1692208802.git.gustavoars@kernel.org>
On Wed, Aug 16, 2023 at 12:05:06PM -0600, Gustavo A. R. Silva wrote:
> Fix checkpatch.pl ERROR: do not use assignment in if condition.
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Karol Herbst <kherbst@redhat.com>,
nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Ben Skeggs <bskeggs@redhat.com>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 2/2][next] nouveau/svm: Split assignment from if conditional
Date: Wed, 16 Aug 2023 13:38:58 -0700 [thread overview]
Message-ID: <202308161338.C7162E7@keescook> (raw)
In-Reply-To: <6b900e80b5587187c68efc788f5b042ca747d374.1692208802.git.gustavoars@kernel.org>
On Wed, Aug 16, 2023 at 12:05:06PM -0600, Gustavo A. R. Silva wrote:
> Fix checkpatch.pl ERROR: do not use assignment in if condition.
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-08-16 20:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 18:03 [PATCH 0/2][next] nouveau/svm: Replace one-element array with flexible-array member Gustavo A. R. Silva
2023-08-16 18:03 ` Gustavo A. R. Silva
2023-08-16 18:03 ` [Nouveau] " Gustavo A. R. Silva
2023-08-16 18:04 ` [PATCH 1/2][next] nouveau/svm: Replace one-element array with flexible-array member in struct nouveau_svm Gustavo A. R. Silva
2023-08-16 18:04 ` Gustavo A. R. Silva
2023-08-16 18:04 ` [Nouveau] " Gustavo A. R. Silva
2023-08-16 20:38 ` Kees Cook
2023-08-16 20:38 ` Kees Cook
2023-08-16 20:38 ` [Nouveau] " Kees Cook
2023-08-16 18:05 ` [PATCH 2/2][next] nouveau/svm: Split assignment from if conditional Gustavo A. R. Silva
2023-08-16 18:05 ` Gustavo A. R. Silva
2023-08-16 18:05 ` [Nouveau] " Gustavo A. R. Silva
2023-08-16 20:38 ` Kees Cook [this message]
2023-08-16 20:38 ` Kees Cook
2023-08-16 20:38 ` [Nouveau] " Kees Cook
2023-09-29 18:20 ` [PATCH 0/2][next] nouveau/svm: Replace one-element array with flexible-array member Kees Cook
2023-09-29 18:20 ` Kees Cook
2023-09-29 18:20 ` [Nouveau] " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308161338.C7162E7@keescook \
--to=keescook@chromium.org \
--cc=airlied@gmail.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=kherbst@redhat.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.