All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
	Matt Roper <matthew.d.roper@intel.com>
Subject: [Intel-xe] [PATCH v2 02/15] drm/xe/xe2: Add GT topology readout
Date: Fri, 18 Aug 2023 15:08:11 -0700	[thread overview]
Message-ID: <20230818220824.700519-3-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20230818220824.700519-1-lucas.demarchi@intel.com>

From: Matt Roper <matthew.d.roper@intel.com>

Xe2 platforms have three DSS fuse registers for both geometry and
compute.

Bspec: 67171, 67537, 67401, 67536
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Atwood <matthew.s.atwood@intel.com>
Reviewed-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
---
 drivers/gpu/drm/xe/regs/xe_gt_regs.h |  3 +++
 drivers/gpu/drm/xe/xe_gt_topology.c  | 16 +++++++++++-----
 drivers/gpu/drm/xe/xe_gt_types.h     |  2 +-
 3 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
index baa00557f114..55367dcca603 100644
--- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
@@ -162,6 +162,9 @@
 #define XELP_GT_GEOMETRY_DSS_ENABLE		XE_REG(0x913c)
 #define XEHP_GT_COMPUTE_DSS_ENABLE		XE_REG(0x9144)
 #define XEHPC_GT_COMPUTE_DSS_ENABLE_EXT		XE_REG(0x9148)
+#define XE2_GT_COMPUTE_DSS_2			XE_REG(0x914c)
+#define XE2_GT_GEOMETRY_DSS_1			XE_REG(0x9150)
+#define XE2_GT_GEOMETRY_DSS_2			XE_REG(0x9154)
 
 #define GDRST					XE_REG(0x941c)
 #define   GRDOM_GUC				REG_BIT(3)
diff --git a/drivers/gpu/drm/xe/xe_gt_topology.c b/drivers/gpu/drm/xe/xe_gt_topology.c
index d4bbd0a835c2..a8d7f272c30a 100644
--- a/drivers/gpu/drm/xe/xe_gt_topology.c
+++ b/drivers/gpu/drm/xe/xe_gt_topology.c
@@ -65,7 +65,10 @@ load_eu_mask(struct xe_gt *gt, xe_eu_mask_t mask)
 static void
 get_num_dss_regs(struct xe_device *xe, int *geometry_regs, int *compute_regs)
 {
-	if (GRAPHICS_VERx100(xe) == 1260) {
+	if (GRAPHICS_VER(xe) > 20) {
+		*geometry_regs = 3;
+		*compute_regs = 3;
+	} else if (GRAPHICS_VERx100(xe) == 1260) {
 		*geometry_regs = 0;
 		*compute_regs = 2;
 	} else if (GRAPHICS_VERx100(xe) >= 1250) {
@@ -90,15 +93,18 @@ xe_gt_topology_init(struct xe_gt *gt)
 	 * Register counts returned shouldn't exceed the number of registers
 	 * passed as parameters below.
 	 */
-	drm_WARN_ON(&xe->drm, num_geometry_regs > 1);
-	drm_WARN_ON(&xe->drm, num_compute_regs > 2);
+	drm_WARN_ON(&xe->drm, num_geometry_regs > 3);
+	drm_WARN_ON(&xe->drm, num_compute_regs > 3);
 
 	load_dss_mask(gt, gt->fuse_topo.g_dss_mask,
 		      num_geometry_regs,
-		      XELP_GT_GEOMETRY_DSS_ENABLE);
+		      XELP_GT_GEOMETRY_DSS_ENABLE,
+		      XE2_GT_GEOMETRY_DSS_1,
+		      XE2_GT_GEOMETRY_DSS_2);
 	load_dss_mask(gt, gt->fuse_topo.c_dss_mask, num_compute_regs,
 		      XEHP_GT_COMPUTE_DSS_ENABLE,
-		      XEHPC_GT_COMPUTE_DSS_ENABLE_EXT);
+		      XEHPC_GT_COMPUTE_DSS_ENABLE_EXT,
+		      XE2_GT_COMPUTE_DSS_2);
 	load_eu_mask(gt, gt->fuse_topo.eu_mask_per_dss);
 
 	xe_gt_topology_dump(gt, &p);
diff --git a/drivers/gpu/drm/xe/xe_gt_types.h b/drivers/gpu/drm/xe/xe_gt_types.h
index 35b8c19fa8bf..48fd698ff62a 100644
--- a/drivers/gpu/drm/xe/xe_gt_types.h
+++ b/drivers/gpu/drm/xe/xe_gt_types.h
@@ -24,7 +24,7 @@ enum xe_gt_type {
 	XE_GT_TYPE_MEDIA,
 };
 
-#define XE_MAX_DSS_FUSE_REGS	2
+#define XE_MAX_DSS_FUSE_REGS	3
 #define XE_MAX_EU_FUSE_REGS	1
 
 typedef unsigned long xe_dss_mask_t[BITS_TO_LONGS(32 * XE_MAX_DSS_FUSE_REGS)];
-- 
2.40.1


  parent reply	other threads:[~2023-08-18 22:08 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 22:08 [Intel-xe] [PATCH v2 00/15] Add Lunar Lake support Lucas De Marchi
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 01/15] drm/xe/xe2: Update render/compute context image sizes Lucas De Marchi
2023-08-18 22:08 ` Lucas De Marchi [this message]
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 03/15] drm/xe/xe2: Add MCR register steering for primary GT Lucas De Marchi
2023-08-21 14:32   ` Balasubramani Vivekanandan
2023-08-22 16:55     ` Matt Atwood
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 04/15] drm/xe/xe2: Add MCR register steering for media GT Lucas De Marchi
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 05/15] drm/xe/xe2: Update context image layouts Lucas De Marchi
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 06/15] drm/xe/xe2: Handle fused-off CCS engines Lucas De Marchi
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 07/15] drm/xe/xe2: AuxCCS is no longer used Lucas De Marchi
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 08/15] drm/xe/xe2: Define Xe2_LPG IP features Lucas De Marchi
2023-08-21 14:58   ` Balasubramani Vivekanandan
2023-08-21 16:03     ` Lucas De Marchi
2023-08-22  5:38       ` Balasubramani Vivekanandan
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 09/15] drm/xe/xe2: Define Xe2_LPM " Lucas De Marchi
2023-08-21 14:23   ` Matt Roper
2023-08-21 18:46     ` Lucas De Marchi
2023-08-22  5:41   ` Balasubramani Vivekanandan
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 10/15] drm/xe/xe2: Track VA bits independently of max page table level Lucas De Marchi
2023-08-22  5:54   ` Balasubramani Vivekanandan
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 11/15] drm/xe/xe2: Add MOCS table Lucas De Marchi
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 12/15] drm/xe/xe2: Program GuC's MOCS on Xe2 and beyond Lucas De Marchi
2023-08-22  6:27   ` Balasubramani Vivekanandan
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 13/15] drm/xe/lnl: Add LNL platform definition Lucas De Marchi
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 14/15] drm/xe/lnl: Add GuC firmware definition Lucas De Marchi
2023-08-18 22:08 ` [Intel-xe] [PATCH v2 15/15] drm/xe/lnl: Hook up MOCS table Lucas De Marchi
2023-08-18 22:11 ` [Intel-xe] ✓ CI.Patch_applied: success for Add Lunar Lake support (rev2) Patchwork
2023-08-18 22:11 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-18 22:12 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-18 22:16 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-18 22:17 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-18 22:17 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-18 22:44 ` [Intel-xe] ✓ CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230818220824.700519-3-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.