All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Yujie Liu <yujie.liu@intel.com>,
	rust-for-linux@vger.kernel.org,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	llvm@lists.linux.dev, Philip Li <philip.li@intel.com>,
	netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	linux-hardening@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
	Kees Cook <keescook@chromium.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v3 1/7] overflow: add DEFINE_FLEX() for on-stack allocs
Date: Sat, 19 Aug 2023 12:06:09 +0200	[thread overview]
Message-ID: <2023081940-linguist-pantomime-ebc2@gregkh> (raw)
In-Reply-To: <CANiq72m9ZEVkP76FMFOnPYkA8ih4Mq72HtW9AbrJ-JPy9ku3jw@mail.gmail.com>

On Fri, Aug 18, 2023 at 01:10:07PM +0200, Miguel Ojeda wrote:
> On Fri, Aug 18, 2023 at 12:38 PM Przemek Kitszel
> <przemyslaw.kitszel@intel.com> wrote:
> >
> > Rust folks, could you please tell me if this is something I should fix,
> > or I just uncovered some existing bug in "unstable" thing?
> >
> > Perhaps it is worth to mention, diff of v3 vs v2 is:
> > move dummy implementation of __has_builtin() macro to the top of
> > compiler_types.h, just before `#ifndef ASSEMBLY`
> 
> Nothing you need to worry about, it is an issue with old `bindgen` and
> LLVM >= 16, fixed in commit 08ab786556ff ("rust: bindgen: upgrade to
> 0.65.1") which is in `rust-next` at the moment. Sorry about that, and
> thanks for pinging us!
> 
> LKP / Yujie / Philip: since we got a few reports on this, would it be
> possible to avoid LLVM >= 16 for Rust-enabled builds for any branch
> that does not include the new `bindgen` or at least 08ab786556ff? Or,
> if Greg is OK with that, I guess we could also backport the upgrade,
> but perhaps it is a bit too much for stable?

Commit is tiny enough for stable backports if it fixes a real issue that
everyone needs to address, so I have no objection to taking it for
stable releases once it hits Linus's tree.

thanks,

greg k-h
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	kernel test robot <lkp@intel.com>,
	Yujie Liu <yujie.liu@intel.com>, Philip Li <philip.li@intel.com>,
	rust-for-linux@vger.kernel.org, llvm@lists.linux.dev,
	oe-kbuild-all@lists.linux.dev,
	Jacob Keller <jacob.e.keller@intel.com>,
	intel-wired-lan@lists.osuosl.org,
	Alexander Lobakin <aleksander.lobakin@intel.com>,
	linux-hardening@vger.kernel.org,
	Kees Cook <keescook@chromium.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/7] overflow: add DEFINE_FLEX() for on-stack allocs
Date: Sat, 19 Aug 2023 12:06:09 +0200	[thread overview]
Message-ID: <2023081940-linguist-pantomime-ebc2@gregkh> (raw)
In-Reply-To: <CANiq72m9ZEVkP76FMFOnPYkA8ih4Mq72HtW9AbrJ-JPy9ku3jw@mail.gmail.com>

On Fri, Aug 18, 2023 at 01:10:07PM +0200, Miguel Ojeda wrote:
> On Fri, Aug 18, 2023 at 12:38 PM Przemek Kitszel
> <przemyslaw.kitszel@intel.com> wrote:
> >
> > Rust folks, could you please tell me if this is something I should fix,
> > or I just uncovered some existing bug in "unstable" thing?
> >
> > Perhaps it is worth to mention, diff of v3 vs v2 is:
> > move dummy implementation of __has_builtin() macro to the top of
> > compiler_types.h, just before `#ifndef ASSEMBLY`
> 
> Nothing you need to worry about, it is an issue with old `bindgen` and
> LLVM >= 16, fixed in commit 08ab786556ff ("rust: bindgen: upgrade to
> 0.65.1") which is in `rust-next` at the moment. Sorry about that, and
> thanks for pinging us!
> 
> LKP / Yujie / Philip: since we got a few reports on this, would it be
> possible to avoid LLVM >= 16 for Rust-enabled builds for any branch
> that does not include the new `bindgen` or at least 08ab786556ff? Or,
> if Greg is OK with that, I guess we could also backport the upgrade,
> but perhaps it is a bit too much for stable?

Commit is tiny enough for stable backports if it fixes a real issue that
everyone needs to address, so I have no objection to taking it for
stable releases once it hits Linus's tree.

thanks,

greg k-h

  parent reply	other threads:[~2023-08-19 10:06 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 14:06 [Intel-wired-lan] [PATCH net-next v3 0/7] introduce DEFINE_FLEX() macro Przemek Kitszel
2023-08-16 14:06 ` Przemek Kitszel
2023-08-16 14:06 ` [Intel-wired-lan] [PATCH net-next v3 1/7] overflow: add DEFINE_FLEX() for on-stack allocs Przemek Kitszel
2023-08-16 14:06   ` Przemek Kitszel
2023-08-16 16:35   ` [Intel-wired-lan] " kernel test robot
2023-08-16 16:35     ` kernel test robot
2023-08-18 10:37     ` [Intel-wired-lan] " Przemek Kitszel
2023-08-18 10:37       ` Przemek Kitszel
2023-08-18 11:10       ` [Intel-wired-lan] " Miguel Ojeda
2023-08-18 11:10         ` Miguel Ojeda
2023-08-18 12:07         ` [Intel-wired-lan] " Philip Li
2023-08-18 12:07           ` Philip Li
2023-08-19 10:06         ` Greg KH [this message]
2023-08-19 10:06           ` Greg KH
2023-08-16 20:38   ` [Intel-wired-lan] " Kees Cook
2023-08-16 20:38     ` Kees Cook
2023-08-17 14:35   ` [Intel-wired-lan] " David Laight
2023-08-17 14:35     ` David Laight
2023-08-17 17:00     ` [Intel-wired-lan] " Kees Cook
2023-08-17 17:00       ` Kees Cook
2023-08-18  7:14       ` [Intel-wired-lan] " David Laight
2023-08-18  7:14         ` David Laight
2023-08-18 10:28         ` [Intel-wired-lan] " Przemek Kitszel
2023-08-18 10:28           ` Przemek Kitszel
2023-08-18 10:49           ` [Intel-wired-lan] " David Laight
2023-08-18 10:49             ` David Laight
2023-08-23 20:52             ` [Intel-wired-lan] " Przemek Kitszel
2023-08-23 20:52               ` Przemek Kitszel
2023-08-28 14:41               ` [Intel-wired-lan] " Przemek Kitszel
2023-08-28 14:41                 ` Przemek Kitszel
2023-08-16 14:06 ` [Intel-wired-lan] [PATCH net-next v3 2/7] ice: ice_sched_remove_elems: replace 1 elem array param by u32 Przemek Kitszel
2023-08-16 14:06   ` Przemek Kitszel
2023-08-16 14:06 ` [Intel-wired-lan] [PATCH net-next v3 3/7] ice: drop two params of ice_aq_move_sched_elems() Przemek Kitszel
2023-08-16 14:06   ` Przemek Kitszel
2023-08-16 14:06 ` [Intel-wired-lan] [PATCH net-next v3 4/7] ice: make use of DEFINE_FLEX() in ice_ddp.c Przemek Kitszel
2023-08-16 14:06   ` Przemek Kitszel
2023-08-16 14:06 ` [Intel-wired-lan] [PATCH net-next v3 5/7] ice: make use of DEFINE_FLEX() for struct ice_aqc_add_tx_qgrp Przemek Kitszel
2023-08-16 14:06   ` Przemek Kitszel
2023-08-16 14:06 ` [Intel-wired-lan] [PATCH net-next v3 6/7] ice: make use of DEFINE_FLEX() for struct ice_aqc_dis_txq_item Przemek Kitszel
2023-08-16 14:06   ` Przemek Kitszel
2023-08-16 14:06 ` [Intel-wired-lan] [PATCH net-next v3 7/7] ice: make use of DEFINE_FLEX() in ice_switch.c Przemek Kitszel
2023-08-16 14:06   ` Przemek Kitszel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023081940-linguist-pantomime-ebc2@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=philip.li@intel.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=yujie.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.