All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references
@ 2023-08-20  0:47 Tree Davies
  2023-08-20  0:47 ` [PATCH v3 01/16] Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba() Tree Davies
                   ` (16 more replies)
  0 siblings, 17 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

The goal of this series is to fix checkpatch warning Avoid CamelCase,
for all references of struct rx_ts_record. In most cases renames the
references to, ts, to make the naming consistent.

The first 8 patches have been sent before, and versioned appropriately.

Thank you in advance to the reviewers,
~ Tree

Tree Davies (16):
  Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba()
  Staging: rtl8192e: Rename variable pTS in function
    rtllib_rx_ADDBAReq()
  Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA()
  Staging: rtl8192e: Rename variable pRxTs in function
    rtllib_ts_init_del_ba()
  Staging: rtl8192e: Rename variable pRxTs in function
    rtllib_rx_ba_inact_timeout()
  Staging: rtl8192e: Rename variable pRxTs in function
    RxPktPendingTimeout()
  Staging: rtl8192e: Rename variable pTS in function ResetRxTsEntry()
  Staging: rtl8192e: Rename variable pRxTS in function TSInitialize()
  Staging: rtl8192e: Rename variable tmp in function GetTs()
  Staging: rtl8192e: Rename variable pRxTS in function RemoveTsEntry()
  Staging: rtl8192e: Rename variable pTS in function prototype
    rtllib_FlushRxTsPendingPkts()
  Staging: rtl8192e: Rename variable pTS in function AddReorderEntry()
  Staging: rtl8192e: Rename variable pTS in function
    rtllib_FlushRxTsPendingPkts()
  Staging: rtl8192e: Rename variable pTS in function
    RxReorderIndicatePacket()
  Staging: rtl8192e: Rename variable pRxTS in function
    rtllib_rx_check_duplicate()
  Staging: rtl8192e: Rename variable pTS in function
    rtllib_rx_InfraAdhoc()

 drivers/staging/rtl8192e/rtl819x_BAProc.c | 36 ++++-----
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 73 +++++++++---------
 drivers/staging/rtl8192e/rtllib.h         |  2 +-
 drivers/staging/rtl8192e/rtllib_rx.c      | 94 +++++++++++------------
 4 files changed, 102 insertions(+), 103 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH v3 01/16] Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-22 13:50   ` Greg KH
  2023-08-20  0:47 ` [PATCH v3 02/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_ADDBAReq() Tree Davies
                   ` (15 subsequent siblings)
  16 siblings, 1 reply; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pRxTs in function rx_ts_delete_ba() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v3:Resend as 16 patch series - no longer throttled by email provider, fix commit msg
v2:Resending in smaller patch series
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 0e3372868f97..da29163f3022 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -41,9 +41,9 @@ static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record *pTxTs
 	return bSendDELBA;
 }
 
-static u8 rx_ts_delete_ba(struct rtllib_device *ieee, struct rx_ts_record *pRxTs)
+static u8 rx_ts_delete_ba(struct rtllib_device *ieee, struct rx_ts_record *ts)
 {
-	struct ba_record *pBa = &pRxTs->rx_admitted_ba_record;
+	struct ba_record *pBa = &ts->rx_admitted_ba_record;
 	u8			bSendDELBA = false;
 
 	if (pBa->b_valid) {
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v3 02/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_ADDBAReq()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
  2023-08-20  0:47 ` [PATCH v3 01/16] Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH v3 03/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA() Tree Davies
                   ` (14 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pTS in function rtllib_rx_ADDBAReq() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v3:Resend as 16 patch series - no longer throttled by email provider
v2:Resending in smaller patch series
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index da29163f3022..03d76765e85f 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -220,7 +220,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
 	union ba_param_set *pBaParamSet = NULL;
 	u16 *pBaTimeoutVal = NULL;
 	union sequence_control *pBaStartSeqCtrl = NULL;
-	struct rx_ts_record *pTS = NULL;
+	struct rx_ts_record *ts = NULL;
 
 	if (skb->len < sizeof(struct rtllib_hdr_3addr) + 9) {
 		netdev_warn(ieee->dev, "Invalid skb len in BAREQ(%d / %d)\n",
@@ -253,13 +253,13 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
 			    ieee->ht_info->bCurrentHTSupport);
 		goto OnADDBAReq_Fail;
 	}
-	if (!GetTs(ieee, (struct ts_common_info **)&pTS, dst,
+	if (!GetTs(ieee, (struct ts_common_info **)&ts, dst,
 		   (u8)(pBaParamSet->field.tid), RX_DIR, true)) {
 		rc = ADDBA_STATUS_REFUSED;
 		netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__);
 		goto OnADDBAReq_Fail;
 	}
-	pBA = &pTS->rx_admitted_ba_record;
+	pBA = &ts->rx_admitted_ba_record;
 
 	if (pBaParamSet->field.ba_policy == BA_POLICY_DELAYED) {
 		rc = ADDBA_STATUS_INVALID_PARAM;
@@ -268,7 +268,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
 		goto OnADDBAReq_Fail;
 	}
 
-	rtllib_FlushRxTsPendingPkts(ieee, pTS);
+	rtllib_FlushRxTsPendingPkts(ieee, ts);
 
 	deactivate_ba_entry(ieee, pBA);
 	pBA->dialog_token = *pDialogToken;
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v3 03/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
  2023-08-20  0:47 ` [PATCH v3 01/16] Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba() Tree Davies
  2023-08-20  0:47 ` [PATCH v3 02/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_ADDBAReq() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH v3 04/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_ts_init_del_ba() Tree Davies
                   ` (13 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pRxTs in function rtllib_rx_DELBA() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v3:Resend as 16 patch series - no longer throttled by email provider
v2:Resending in smaller patch series
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 03d76765e85f..c584e9ec48b6 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -430,9 +430,9 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
 	pDelBaParamSet = (union delba_param_set *)&delba->payload[2];
 
 	if (pDelBaParamSet->field.initiator == 1) {
-		struct rx_ts_record *pRxTs;
+		struct rx_ts_record *ts;
 
-		if (!GetTs(ieee, (struct ts_common_info **)&pRxTs, dst,
+		if (!GetTs(ieee, (struct ts_common_info **)&ts, dst,
 			   (u8)pDelBaParamSet->field.tid, RX_DIR, false)) {
 			netdev_warn(ieee->dev,
 				    "%s(): can't get TS for RXTS. dst:%pM TID:%d\n",
@@ -441,7 +441,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
 			return -1;
 		}
 
-		rx_ts_delete_ba(ieee, pRxTs);
+		rx_ts_delete_ba(ieee, ts);
 	} else {
 		struct tx_ts_record *pTxTs;
 
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v3 04/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_ts_init_del_ba()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (2 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH v3 03/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH v3 05/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_ba_inact_timeout() Tree Davies
                   ` (12 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pRxTs in function rtllib_ts_init_del_ba() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v3:Resend as 16 patch series - no longer throttled by email provider
v2:Resending in smaller patch series
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index c584e9ec48b6..2aa624bcbfd1 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -499,11 +499,11 @@ void rtllib_ts_init_del_ba(struct rtllib_device *ieee,
 					(&pTxTs->TxPendingBARecord),
 					 TxRxSelect, DELBA_REASON_END_BA);
 	} else if (TxRxSelect == RX_DIR) {
-		struct rx_ts_record *pRxTs =
+		struct rx_ts_record *ts =
 				 (struct rx_ts_record *)pTsCommonInfo;
-		if (rx_ts_delete_ba(ieee, pRxTs))
+		if (rx_ts_delete_ba(ieee, ts))
 			rtllib_send_DELBA(ieee, pTsCommonInfo->Addr,
-					  &pRxTs->rx_admitted_ba_record,
+					  &ts->rx_admitted_ba_record,
 					  TxRxSelect, DELBA_REASON_END_BA);
 	}
 }
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v3 05/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_ba_inact_timeout()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (3 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH v3 04/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_ts_init_del_ba() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH v3 06/16] Staging: rtl8192e: Rename variable pRxTs in function RxPktPendingTimeout() Tree Davies
                   ` (11 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename varialbe pRxTs in function rtllib_rx_ba_inact_timeout() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v3:Resend as 16 patch series - no longer throttled by email provider
v2:Resending in smaller patch series
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 2aa624bcbfd1..bc6f9e8c5dd8 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -532,13 +532,13 @@ void rtllib_tx_ba_inact_timeout(struct timer_list *t)
 
 void rtllib_rx_ba_inact_timeout(struct timer_list *t)
 {
-	struct rx_ts_record *pRxTs = from_timer(pRxTs, t,
+	struct rx_ts_record *ts = from_timer(ts, t,
 					      rx_admitted_ba_record.timer);
-	struct rtllib_device *ieee = container_of(pRxTs, struct rtllib_device,
-				     RxTsRecord[pRxTs->num]);
+	struct rtllib_device *ieee = container_of(ts, struct rtllib_device,
+				     RxTsRecord[ts->num]);
 
-	rx_ts_delete_ba(ieee, pRxTs);
-	rtllib_send_DELBA(ieee, pRxTs->ts_common_info.Addr,
-			  &pRxTs->rx_admitted_ba_record, RX_DIR,
+	rx_ts_delete_ba(ieee, ts);
+	rtllib_send_DELBA(ieee, ts->ts_common_info.Addr,
+			  &ts->rx_admitted_ba_record, RX_DIR,
 			  DELBA_REASON_TIMEOUT);
 }
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v3 06/16] Staging: rtl8192e: Rename variable pRxTs in function RxPktPendingTimeout()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (4 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH v3 05/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_ba_inact_timeout() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH v2 07/16] Staging: rtl8192e: Rename variable pTS in function ResetRxTsEntry() Tree Davies
                   ` (10 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pRxTs in function RxPktPendingTimeout() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v3:Resend as 16 patch series - no longer throttled by email provider
v2:Resending in smaller patch series
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 33 +++++++++++------------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 24a8b9fc0168..75bf59d267c2 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -10,10 +10,9 @@
 
 static void RxPktPendingTimeout(struct timer_list *t)
 {
-	struct rx_ts_record *pRxTs = from_timer(pRxTs, t,
-						     rx_pkt_pending_timer);
-	struct rtllib_device *ieee = container_of(pRxTs, struct rtllib_device,
-						  RxTsRecord[pRxTs->num]);
+	struct rx_ts_record *ts = from_timer(ts, t, rx_pkt_pending_timer);
+	struct rtllib_device *ieee = container_of(ts, struct rtllib_device,
+						  RxTsRecord[ts->num]);
 
 	struct rx_reorder_entry *pReorderEntry = NULL;
 
@@ -22,24 +21,24 @@ static void RxPktPendingTimeout(struct timer_list *t)
 	bool bPktInBuf = false;
 
 	spin_lock_irqsave(&(ieee->reorder_spinlock), flags);
-	if (pRxTs->rx_timeout_indicate_seq != 0xffff) {
-		while (!list_empty(&pRxTs->rx_pending_pkt_list)) {
+	if (ts->rx_timeout_indicate_seq != 0xffff) {
+		while (!list_empty(&ts->rx_pending_pkt_list)) {
 			pReorderEntry = (struct rx_reorder_entry *)
-					list_entry(pRxTs->rx_pending_pkt_list.prev,
+					list_entry(ts->rx_pending_pkt_list.prev,
 					struct rx_reorder_entry, List);
 			if (index == 0)
-				pRxTs->rx_indicate_seq = pReorderEntry->SeqNum;
+				ts->rx_indicate_seq = pReorderEntry->SeqNum;
 
 			if (SN_LESS(pReorderEntry->SeqNum,
-				    pRxTs->rx_indicate_seq) ||
+				    ts->rx_indicate_seq) ||
 			    SN_EQUAL(pReorderEntry->SeqNum,
-				     pRxTs->rx_indicate_seq)) {
+				     ts->rx_indicate_seq)) {
 				list_del_init(&pReorderEntry->List);
 
 				if (SN_EQUAL(pReorderEntry->SeqNum,
-				    pRxTs->rx_indicate_seq))
-					pRxTs->rx_indicate_seq =
-					      (pRxTs->rx_indicate_seq + 1) % 4096;
+				    ts->rx_indicate_seq))
+					ts->rx_indicate_seq =
+					      (ts->rx_indicate_seq + 1) % 4096;
 
 				netdev_dbg(ieee->dev,
 					   "%s(): Indicate SeqNum: %d\n",
@@ -58,7 +57,7 @@ static void RxPktPendingTimeout(struct timer_list *t)
 	}
 
 	if (index > 0) {
-		pRxTs->rx_timeout_indicate_seq = 0xffff;
+		ts->rx_timeout_indicate_seq = 0xffff;
 
 		if (index > REORDER_WIN_SIZE) {
 			netdev_warn(ieee->dev,
@@ -72,9 +71,9 @@ static void RxPktPendingTimeout(struct timer_list *t)
 		bPktInBuf = false;
 	}
 
-	if (bPktInBuf && (pRxTs->rx_timeout_indicate_seq == 0xffff)) {
-		pRxTs->rx_timeout_indicate_seq = pRxTs->rx_indicate_seq;
-		mod_timer(&pRxTs->rx_pkt_pending_timer,  jiffies +
+	if (bPktInBuf && (ts->rx_timeout_indicate_seq == 0xffff)) {
+		ts->rx_timeout_indicate_seq = ts->rx_indicate_seq;
+		mod_timer(&ts->rx_pkt_pending_timer,  jiffies +
 			  msecs_to_jiffies(ieee->ht_info->rx_reorder_pending_time)
 			  );
 	}
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 07/16] Staging: rtl8192e: Rename variable pTS in function ResetRxTsEntry()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (5 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH v3 06/16] Staging: rtl8192e: Rename variable pRxTs in function RxPktPendingTimeout() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH v2 08/16] Staging: rtl8192e: Rename variable pRxTS in function TSInitialize() Tree Davies
                   ` (9 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pTS in function ResetRxTsEntry() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v2:Resend as 16 patch series - no longer throttled by email provider
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 75bf59d267c2..c892fe044f29 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -112,12 +112,12 @@ static void ResetTxTsEntry(struct tx_ts_record *pTS)
 	rtllib_reset_ba_entry(&pTS->TxPendingBARecord);
 }
 
-static void ResetRxTsEntry(struct rx_ts_record *pTS)
+static void ResetRxTsEntry(struct rx_ts_record *ts)
 {
-	ResetTsCommonInfo(&pTS->ts_common_info);
-	pTS->rx_indicate_seq = 0xffff;
-	pTS->rx_timeout_indicate_seq = 0xffff;
-	rtllib_reset_ba_entry(&pTS->rx_admitted_ba_record);
+	ResetTsCommonInfo(&ts->ts_common_info);
+	ts->rx_indicate_seq = 0xffff;
+	ts->rx_timeout_indicate_seq = 0xffff;
+	rtllib_reset_ba_entry(&ts->rx_admitted_ba_record);
 }
 
 void TSInitialize(struct rtllib_device *ieee)
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 08/16] Staging: rtl8192e: Rename variable pRxTS in function TSInitialize()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (6 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH v2 07/16] Staging: rtl8192e: Rename variable pTS in function ResetRxTsEntry() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH 09/16] Staging: rtl8192e: Rename variable tmp in function GetTs() Tree Davies
                   ` (8 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pRxTS in function TSInitialize() to rxts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v2:Resend as 16 patch series - no longer throttled by email provider
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index c892fe044f29..ac97b6d627da 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -123,7 +123,7 @@ static void ResetRxTsEntry(struct rx_ts_record *ts)
 void TSInitialize(struct rtllib_device *ieee)
 {
 	struct tx_ts_record *pTxTS  = ieee->TxTsRecord;
-	struct rx_ts_record *pRxTS  = ieee->RxTsRecord;
+	struct rx_ts_record *rxts  = ieee->RxTsRecord;
 	struct rx_reorder_entry *pRxReorderEntry = ieee->RxReorderEntry;
 	u8				count = 0;
 
@@ -150,17 +150,17 @@ void TSInitialize(struct rtllib_device *ieee)
 	INIT_LIST_HEAD(&ieee->Rx_TS_Pending_List);
 	INIT_LIST_HEAD(&ieee->Rx_TS_Unused_List);
 	for (count = 0; count < TOTAL_TS_NUM; count++) {
-		pRxTS->num = count;
-		INIT_LIST_HEAD(&pRxTS->rx_pending_pkt_list);
-		timer_setup(&pRxTS->rx_admitted_ba_record.timer,
+		rxts->num = count;
+		INIT_LIST_HEAD(&rxts->rx_pending_pkt_list);
+		timer_setup(&rxts->rx_admitted_ba_record.timer,
 			    rtllib_rx_ba_inact_timeout, 0);
 
-		timer_setup(&pRxTS->rx_pkt_pending_timer, RxPktPendingTimeout, 0);
+		timer_setup(&rxts->rx_pkt_pending_timer, RxPktPendingTimeout, 0);
 
-		ResetRxTsEntry(pRxTS);
-		list_add_tail(&pRxTS->ts_common_info.List,
+		ResetRxTsEntry(rxts);
+		list_add_tail(&rxts->ts_common_info.List,
 			      &ieee->Rx_TS_Unused_List);
-		pRxTS++;
+		rxts++;
 	}
 	INIT_LIST_HEAD(&ieee->RxReorder_Unused_List);
 	for (count = 0; count < REORDER_ENTRY_NUM; count++) {
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 09/16] Staging: rtl8192e: Rename variable tmp in function GetTs()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (7 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH v2 08/16] Staging: rtl8192e: Rename variable pRxTS in function TSInitialize() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH 10/16] Staging: rtl8192e: Rename variable pRxTS in function RemoveTsEntry() Tree Davies
                   ` (7 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable tmp in function GetTs() to ts in order
to make the name consistent with other references of type
struct rx_ts_record.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index ac97b6d627da..131a5d7b4599 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -325,11 +325,11 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
 				TsCommonInfo);
 			ResetTxTsEntry(tmp);
 		} else {
-			struct rx_ts_record *tmp =
+			struct rx_ts_record *ts =
 				 container_of(*ppTS,
 				 struct rx_ts_record,
 				 ts_common_info);
-			ResetRxTsEntry(tmp);
+			ResetRxTsEntry(ts);
 		}
 
 		netdev_dbg(ieee->dev,
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 10/16] Staging: rtl8192e: Rename variable pRxTS in function RemoveTsEntry()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (8 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH 09/16] Staging: rtl8192e: Rename variable tmp in function GetTs() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH 11/16] Staging: rtl8192e: Rename variable pTS in function prototype rtllib_FlushRxTsPendingPkts() Tree Davies
                   ` (6 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pRxTS in function RemoveTsEntry() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 131a5d7b4599..944970272801 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -364,14 +364,14 @@ static void RemoveTsEntry(struct rtllib_device *ieee,
 
 	if (TxRxSelect == RX_DIR) {
 		struct rx_reorder_entry *pRxReorderEntry;
-		struct rx_ts_record *pRxTS = (struct rx_ts_record *)pTs;
+		struct rx_ts_record *ts = (struct rx_ts_record *)pTs;
 
-		if (timer_pending(&pRxTS->rx_pkt_pending_timer))
-			del_timer_sync(&pRxTS->rx_pkt_pending_timer);
+		if (timer_pending(&ts->rx_pkt_pending_timer))
+			del_timer_sync(&ts->rx_pkt_pending_timer);
 
-		while (!list_empty(&pRxTS->rx_pending_pkt_list)) {
+		while (!list_empty(&ts->rx_pending_pkt_list)) {
 			pRxReorderEntry = (struct rx_reorder_entry *)
-					list_entry(pRxTS->rx_pending_pkt_list.prev,
+					list_entry(ts->rx_pending_pkt_list.prev,
 					struct rx_reorder_entry, List);
 			netdev_dbg(ieee->dev,  "%s(): Delete SeqNum %d!\n",
 				   __func__, pRxReorderEntry->SeqNum);
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 11/16] Staging: rtl8192e: Rename variable pTS in function prototype rtllib_FlushRxTsPendingPkts()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (9 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH 10/16] Staging: rtl8192e: Rename variable pRxTS in function RemoveTsEntry() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH 12/16] Staging: rtl8192e: Rename variable pTS in function AddReorderEntry() Tree Davies
                   ` (5 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pTS in function prototype rtllib_FlushRxTsPendingPkts()
to ts, to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtllib.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 0c812eb02ba6..9c2817e8a5d4 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -2039,7 +2039,7 @@ bool rtllib_MgntDisconnect(struct rtllib_device *rtllib, u8 asRsn);
  * ieee handler to refer to it.
  */
 void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee,
-				 struct rx_ts_record *pTS);
+				 struct rx_ts_record *ts);
 int rtllib_parse_info_param(struct rtllib_device *ieee,
 			    struct rtllib_info_element *info_element,
 			    u16 length,
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 12/16] Staging: rtl8192e: Rename variable pTS in function AddReorderEntry()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (10 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH 11/16] Staging: rtl8192e: Rename variable pTS in function prototype rtllib_FlushRxTsPendingPkts() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH 13/16] Staging: rtl8192e: Rename variable pTS in function rtllib_FlushRxTsPendingPkts() Tree Davies
                   ` (4 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pTS in function AddReorderEntry() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 8a4029f26835..1d41f62fa346 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -435,12 +435,12 @@ static int is_duplicate_packet(struct rtllib_device *ieee,
 	return 1;
 }
 
-static bool AddReorderEntry(struct rx_ts_record *pTS,
+static bool AddReorderEntry(struct rx_ts_record *ts,
 			    struct rx_reorder_entry *pReorderEntry)
 {
-	struct list_head *pList = &pTS->rx_pending_pkt_list;
+	struct list_head *pList = &ts->rx_pending_pkt_list;
 
-	while (pList->next != &pTS->rx_pending_pkt_list) {
+	while (pList->next != &ts->rx_pending_pkt_list) {
 		if (SN_LESS(pReorderEntry->SeqNum, ((struct rx_reorder_entry *)
 		    list_entry(pList->next, struct rx_reorder_entry,
 		    List))->SeqNum))
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 13/16] Staging: rtl8192e: Rename variable pTS in function rtllib_FlushRxTsPendingPkts()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (11 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH 12/16] Staging: rtl8192e: Rename variable pTS in function AddReorderEntry() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH 14/16] Staging: rtl8192e: Rename variable pTS in function RxReorderIndicatePacket() Tree Davies
                   ` (3 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pTS in function rtllib_FlushRxTsPendingPkts() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 1d41f62fa346..4907468ddaa5 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -520,13 +520,13 @@ void rtllib_indicate_packets(struct rtllib_device *ieee,
 }
 
 void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee,
-				 struct rx_ts_record *pTS)
+				 struct rx_ts_record *ts)
 {
 	struct rx_reorder_entry *pRxReorderEntry;
 	u8 RfdCnt = 0;
 
-	del_timer_sync(&pTS->rx_pkt_pending_timer);
-	while (!list_empty(&pTS->rx_pending_pkt_list)) {
+	del_timer_sync(&ts->rx_pkt_pending_timer);
+	while (!list_empty(&ts->rx_pending_pkt_list)) {
 		if (RfdCnt >= REORDER_WIN_SIZE) {
 			netdev_info(ieee->dev,
 				    "-------------->%s() error! RfdCnt >= REORDER_WIN_SIZE\n",
@@ -535,7 +535,7 @@ void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee,
 		}
 
 		pRxReorderEntry = (struct rx_reorder_entry *)
-				  list_entry(pTS->rx_pending_pkt_list.prev,
+				  list_entry(ts->rx_pending_pkt_list.prev,
 					     struct rx_reorder_entry, List);
 		netdev_dbg(ieee->dev, "%s(): Indicate SeqNum %d!\n", __func__,
 			   pRxReorderEntry->SeqNum);
@@ -549,7 +549,7 @@ void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee,
 	}
 	rtllib_indicate_packets(ieee, ieee->RfdArray, RfdCnt);
 
-	pTS->rx_indicate_seq = 0xffff;
+	ts->rx_indicate_seq = 0xffff;
 }
 
 static void RxReorderIndicatePacket(struct rtllib_device *ieee,
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 14/16] Staging: rtl8192e: Rename variable pTS in function RxReorderIndicatePacket()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (12 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH 13/16] Staging: rtl8192e: Rename variable pTS in function rtllib_FlushRxTsPendingPkts() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH 15/16] Staging: rtl8192e: Rename variable pRxTS in function rtllib_rx_check_duplicate() Tree Davies
                   ` (2 subsequent siblings)
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pTS in function RxReorderIndicatePacket() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 58 ++++++++++++++--------------
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 4907468ddaa5..e97debe6a7d2 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -554,7 +554,7 @@ void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee,
 
 static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 				    struct rtllib_rxb *prxb,
-				    struct rx_ts_record *pTS, u16 SeqNum)
+				    struct rx_ts_record *ts, u16 SeqNum)
 {
 	struct rt_hi_throughput *ht_info = ieee->ht_info;
 	struct rx_reorder_entry *pReorderEntry = NULL;
@@ -565,21 +565,21 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 	unsigned long flags;
 
 	netdev_dbg(ieee->dev,
-		   "%s(): Seq is %d, pTS->rx_indicate_seq is %d, WinSize is %d\n",
-		   __func__, SeqNum, pTS->rx_indicate_seq, WinSize);
+		   "%s(): Seq is %d, ts->rx_indicate_seq is %d, WinSize is %d\n",
+		   __func__, SeqNum, ts->rx_indicate_seq, WinSize);
 
 	spin_lock_irqsave(&(ieee->reorder_spinlock), flags);
 
-	WinEnd = (pTS->rx_indicate_seq + WinSize - 1) % 4096;
+	WinEnd = (ts->rx_indicate_seq + WinSize - 1) % 4096;
 	/* Rx Reorder initialize condition.*/
-	if (pTS->rx_indicate_seq == 0xffff)
-		pTS->rx_indicate_seq = SeqNum;
+	if (ts->rx_indicate_seq == 0xffff)
+		ts->rx_indicate_seq = SeqNum;
 
 	/* Drop out the packet which SeqNum is smaller than WinStart */
-	if (SN_LESS(SeqNum, pTS->rx_indicate_seq)) {
+	if (SN_LESS(SeqNum, ts->rx_indicate_seq)) {
 		netdev_dbg(ieee->dev,
 			   "Packet Drop! IndicateSeq: %d, NewSeq: %d\n",
-			   pTS->rx_indicate_seq, SeqNum);
+			   ts->rx_indicate_seq, SeqNum);
 		ht_info->rx_reorder_drop_counter++;
 		{
 			int i;
@@ -597,18 +597,18 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 	 * 1. Incoming SeqNum is equal to WinStart =>Window shift 1
 	 * 2. Incoming SeqNum is larger than the WinEnd => Window shift N
 	 */
-	if (SN_EQUAL(SeqNum, pTS->rx_indicate_seq)) {
-		pTS->rx_indicate_seq = (pTS->rx_indicate_seq + 1) % 4096;
+	if (SN_EQUAL(SeqNum, ts->rx_indicate_seq)) {
+		ts->rx_indicate_seq = (ts->rx_indicate_seq + 1) % 4096;
 		bMatchWinStart = true;
 	} else if (SN_LESS(WinEnd, SeqNum)) {
 		if (SeqNum >= (WinSize - 1))
-			pTS->rx_indicate_seq = SeqNum + 1 - WinSize;
+			ts->rx_indicate_seq = SeqNum + 1 - WinSize;
 		else
-			pTS->rx_indicate_seq = 4095 -
+			ts->rx_indicate_seq = 4095 -
 					     (WinSize - (SeqNum + 1)) + 1;
 		netdev_dbg(ieee->dev,
 			   "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
-			   pTS->rx_indicate_seq, SeqNum);
+			   ts->rx_indicate_seq, SeqNum);
 	}
 
 	/* Indication process.
@@ -625,7 +625,7 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 		/* Current packet is going to be indicated.*/
 		netdev_dbg(ieee->dev,
 			   "Packets indication! IndicateSeq: %d, NewSeq: %d\n",
-			   pTS->rx_indicate_seq, SeqNum);
+			   ts->rx_indicate_seq, SeqNum);
 		ieee->prxbIndicateArray[0] = prxb;
 		index = 1;
 	} else {
@@ -642,12 +642,12 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 			pReorderEntry->SeqNum = SeqNum;
 			pReorderEntry->prxb = prxb;
 
-			if (!AddReorderEntry(pTS, pReorderEntry)) {
+			if (!AddReorderEntry(ts, pReorderEntry)) {
 				int i;
 
 				netdev_dbg(ieee->dev,
 					   "%s(): Duplicate packet is dropped. IndicateSeq: %d, NewSeq: %d\n",
-					   __func__, pTS->rx_indicate_seq,
+					   __func__, ts->rx_indicate_seq,
 					   SeqNum);
 				list_add_tail(&pReorderEntry->List,
 					      &ieee->RxReorder_Unused_List);
@@ -659,7 +659,7 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 			} else {
 				netdev_dbg(ieee->dev,
 					   "Pkt insert into struct buffer. IndicateSeq: %d, NewSeq: %d\n",
-					   pTS->rx_indicate_seq, SeqNum);
+					   ts->rx_indicate_seq, SeqNum);
 			}
 		} else {
 			/* Packets are dropped if there are not enough reorder
@@ -682,16 +682,16 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 	}
 
 	/* Check if there is any packet need indicate.*/
-	while (!list_empty(&pTS->rx_pending_pkt_list)) {
+	while (!list_empty(&ts->rx_pending_pkt_list)) {
 		netdev_dbg(ieee->dev, "%s(): start RREORDER indicate\n",
 			   __func__);
 
 		pReorderEntry = (struct rx_reorder_entry *)
-					list_entry(pTS->rx_pending_pkt_list.prev,
+					list_entry(ts->rx_pending_pkt_list.prev,
 						   struct rx_reorder_entry,
 						   List);
-		if (SN_LESS(pReorderEntry->SeqNum, pTS->rx_indicate_seq) ||
-		    SN_EQUAL(pReorderEntry->SeqNum, pTS->rx_indicate_seq)) {
+		if (SN_LESS(pReorderEntry->SeqNum, ts->rx_indicate_seq) ||
+		    SN_EQUAL(pReorderEntry->SeqNum, ts->rx_indicate_seq)) {
 			/* This protect struct buffer from overflow. */
 			if (index >= REORDER_WIN_SIZE) {
 				netdev_err(ieee->dev,
@@ -703,8 +703,8 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 
 			list_del_init(&pReorderEntry->List);
 
-			if (SN_EQUAL(pReorderEntry->SeqNum, pTS->rx_indicate_seq))
-				pTS->rx_indicate_seq = (pTS->rx_indicate_seq + 1) %
+			if (SN_EQUAL(pReorderEntry->SeqNum, ts->rx_indicate_seq))
+				ts->rx_indicate_seq = (ts->rx_indicate_seq + 1) %
 						     4096;
 
 			ieee->prxbIndicateArray[index] = pReorderEntry->prxb;
@@ -724,9 +724,9 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 	 * Rx buffering.
 	 */
 	if (index > 0) {
-		if (timer_pending(&pTS->rx_pkt_pending_timer))
-			del_timer_sync(&pTS->rx_pkt_pending_timer);
-		pTS->rx_timeout_indicate_seq = 0xffff;
+		if (timer_pending(&ts->rx_pkt_pending_timer))
+			del_timer_sync(&ts->rx_pkt_pending_timer);
+		ts->rx_timeout_indicate_seq = 0xffff;
 
 		if (index > REORDER_WIN_SIZE) {
 			netdev_err(ieee->dev,
@@ -740,10 +740,10 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 		bPktInBuf = false;
 	}
 
-	if (bPktInBuf && pTS->rx_timeout_indicate_seq == 0xffff) {
+	if (bPktInBuf && ts->rx_timeout_indicate_seq == 0xffff) {
 		netdev_dbg(ieee->dev, "%s(): SET rx timeout timer\n", __func__);
-		pTS->rx_timeout_indicate_seq = pTS->rx_indicate_seq;
-		mod_timer(&pTS->rx_pkt_pending_timer, jiffies +
+		ts->rx_timeout_indicate_seq = ts->rx_indicate_seq;
+		mod_timer(&ts->rx_pkt_pending_timer, jiffies +
 			  msecs_to_jiffies(ht_info->rx_reorder_pending_time));
 	}
 	spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags);
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 15/16] Staging: rtl8192e: Rename variable pRxTS in function rtllib_rx_check_duplicate()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (13 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH 14/16] Staging: rtl8192e: Rename variable pTS in function RxReorderIndicatePacket() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  0:47 ` [PATCH 16/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_InfraAdhoc() Tree Davies
  2023-08-20  4:40 ` [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Philipp Hortmann
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pRxTS in function rtllib_rx_check_duplicate() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index e97debe6a7d2..491789ebcc08 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -922,15 +922,15 @@ static int rtllib_rx_check_duplicate(struct rtllib_device *ieee,
 				return -1;
 		}
 	} else {
-		struct rx_ts_record *pRxTS = NULL;
+		struct rx_ts_record *ts = NULL;
 
-		if (GetTs(ieee, (struct ts_common_info **)&pRxTS, hdr->addr2,
+		if (GetTs(ieee, (struct ts_common_info **)&ts, hdr->addr2,
 			(u8)Frame_QoSTID((u8 *)(skb->data)), RX_DIR, true)) {
-			if ((fc & (1 << 11)) && (frag == pRxTS->rx_last_frag_num) &&
-			    (WLAN_GET_SEQ_SEQ(sc) == pRxTS->rx_last_seq_num))
+			if ((fc & (1 << 11)) && (frag == ts->rx_last_frag_num) &&
+			    (WLAN_GET_SEQ_SEQ(sc) == ts->rx_last_seq_num))
 				return -1;
-			pRxTS->rx_last_frag_num = frag;
-			pRxTS->rx_last_seq_num = WLAN_GET_SEQ_SEQ(sc);
+			ts->rx_last_frag_num = frag;
+			ts->rx_last_seq_num = WLAN_GET_SEQ_SEQ(sc);
 		} else {
 			netdev_warn(ieee->dev, "%s(): No TS! Skip the check!\n",
 				    __func__);
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 16/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_InfraAdhoc()
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (14 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH 15/16] Staging: rtl8192e: Rename variable pRxTS in function rtllib_rx_check_duplicate() Tree Davies
@ 2023-08-20  0:47 ` Tree Davies
  2023-08-20  4:40 ` [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Philipp Hortmann
  16 siblings, 0 replies; 19+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pTS in function rtllib_rx_InfraAdhoc() to ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 491789ebcc08..53ec4f077bd8 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -1280,7 +1280,7 @@ static int rtllib_rx_InfraAdhoc(struct rtllib_device *ieee, struct sk_buff *skb,
 	struct rtllib_hdr_4addr *hdr = (struct rtllib_hdr_4addr *)skb->data;
 	struct lib80211_crypt_data *crypt = NULL;
 	struct rtllib_rxb *rxb = NULL;
-	struct rx_ts_record *pTS = NULL;
+	struct rx_ts_record *ts = NULL;
 	u16 fc, sc, SeqNum = 0;
 	u8 type, stype, multicast = 0, unicast = 0, nr_subframes = 0, TID = 0;
 	u8 dst[ETH_ALEN];
@@ -1386,7 +1386,7 @@ static int rtllib_rx_InfraAdhoc(struct rtllib_device *ieee, struct sk_buff *skb,
 		&& (!bToOtherSTA)) {
 		TID = Frame_QoSTID(skb->data);
 		SeqNum = WLAN_GET_SEQ_SEQ(sc);
-		GetTs(ieee, (struct ts_common_info **)&pTS, hdr->addr2, TID,
+		GetTs(ieee, (struct ts_common_info **)&ts, hdr->addr2, TID,
 		      RX_DIR, true);
 		if (TID != 0 && TID != 3)
 			ieee->bis_any_nonbepkts = true;
@@ -1425,10 +1425,10 @@ static int rtllib_rx_InfraAdhoc(struct rtllib_device *ieee, struct sk_buff *skb,
 	}
 
 	/* Indicate packets to upper layer or Rx Reorder */
-	if (!ieee->ht_info->cur_rx_reorder_enable || pTS == NULL || bToOtherSTA)
+	if (!ieee->ht_info->cur_rx_reorder_enable || ts == NULL || bToOtherSTA)
 		rtllib_rx_indicate_pkt_legacy(ieee, rx_stats, rxb, dst, src);
 	else
-		RxReorderIndicatePacket(ieee, rxb, pTS, SeqNum);
+		RxReorderIndicatePacket(ieee, rxb, ts, SeqNum);
 
 	dev_kfree_skb(skb);
 
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references
  2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (15 preceding siblings ...)
  2023-08-20  0:47 ` [PATCH 16/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_InfraAdhoc() Tree Davies
@ 2023-08-20  4:40 ` Philipp Hortmann
  16 siblings, 0 replies; 19+ messages in thread
From: Philipp Hortmann @ 2023-08-20  4:40 UTC (permalink / raw)
  To: Tree Davies, gregkh, anjan; +Cc: linux-staging, linux-kernel

On 8/20/23 02:47, Tree Davies wrote:
> The goal of this series is to fix checkpatch warning Avoid CamelCase,
> for all references of struct rx_ts_record. In most cases renames the
> references to, ts, to make the naming consistent.
> 
> The first 8 patches have been sent before, and versioned appropriately.
> 
> Thank you in advance to the reviewers,
> ~ Tree
> 
> Tree Davies (16):
>    Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba()
>    Staging: rtl8192e: Rename variable pTS in function
>      rtllib_rx_ADDBAReq()
>    Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA()
>    Staging: rtl8192e: Rename variable pRxTs in function
>      rtllib_ts_init_del_ba()
>    Staging: rtl8192e: Rename variable pRxTs in function
>      rtllib_rx_ba_inact_timeout()
>    Staging: rtl8192e: Rename variable pRxTs in function
>      RxPktPendingTimeout()
>    Staging: rtl8192e: Rename variable pTS in function ResetRxTsEntry()
>    Staging: rtl8192e: Rename variable pRxTS in function TSInitialize()
>    Staging: rtl8192e: Rename variable tmp in function GetTs()
>    Staging: rtl8192e: Rename variable pRxTS in function RemoveTsEntry()
>    Staging: rtl8192e: Rename variable pTS in function prototype
>      rtllib_FlushRxTsPendingPkts()
>    Staging: rtl8192e: Rename variable pTS in function AddReorderEntry()
>    Staging: rtl8192e: Rename variable pTS in function
>      rtllib_FlushRxTsPendingPkts()
>    Staging: rtl8192e: Rename variable pTS in function
>      RxReorderIndicatePacket()
>    Staging: rtl8192e: Rename variable pRxTS in function
>      rtllib_rx_check_duplicate()
>    Staging: rtl8192e: Rename variable pTS in function
>      rtllib_rx_InfraAdhoc()
> 
>   drivers/staging/rtl8192e/rtl819x_BAProc.c | 36 ++++-----
>   drivers/staging/rtl8192e/rtl819x_TSProc.c | 73 +++++++++---------
>   drivers/staging/rtl8192e/rtllib.h         |  2 +-
>   drivers/staging/rtl8192e/rtllib_rx.c      | 94 +++++++++++------------
>   4 files changed, 102 insertions(+), 103 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>




^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v3 01/16] Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba()
  2023-08-20  0:47 ` [PATCH v3 01/16] Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba() Tree Davies
@ 2023-08-22 13:50   ` Greg KH
  0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2023-08-22 13:50 UTC (permalink / raw)
  To: Tree Davies; +Cc: philipp.g.hortmann, anjan, linux-staging, linux-kernel

On Sat, Aug 19, 2023 at 05:47:29PM -0700, Tree Davies wrote:
> Rename variable pRxTs in function rx_ts_delete_ba() to ts
> to fix checkpatch warning Avoid CamelCase.
> 
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> ---
> v3:Resend as 16 patch series - no longer throttled by email provider, fix commit msg
> v2:Resending in smaller patch series
>  drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 0e3372868f97..da29163f3022 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -41,9 +41,9 @@ static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record *pTxTs
>  	return bSendDELBA;
>  }

This patch series is named very strange.  Some commits have "v3", some
have "v2" and some none at all.

A patchset itself is versioned, I can't keep track of which commit in
the series is newer than which, sorry.  What would you do if you saw
this email thread in your inbox to review?  :)

Can you resend the whole thing, as a v4 series, with the Tested-by tag
added to the patches?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2023-08-22 13:50 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-20  0:47 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
2023-08-20  0:47 ` [PATCH v3 01/16] Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba() Tree Davies
2023-08-22 13:50   ` Greg KH
2023-08-20  0:47 ` [PATCH v3 02/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_ADDBAReq() Tree Davies
2023-08-20  0:47 ` [PATCH v3 03/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA() Tree Davies
2023-08-20  0:47 ` [PATCH v3 04/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_ts_init_del_ba() Tree Davies
2023-08-20  0:47 ` [PATCH v3 05/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_ba_inact_timeout() Tree Davies
2023-08-20  0:47 ` [PATCH v3 06/16] Staging: rtl8192e: Rename variable pRxTs in function RxPktPendingTimeout() Tree Davies
2023-08-20  0:47 ` [PATCH v2 07/16] Staging: rtl8192e: Rename variable pTS in function ResetRxTsEntry() Tree Davies
2023-08-20  0:47 ` [PATCH v2 08/16] Staging: rtl8192e: Rename variable pRxTS in function TSInitialize() Tree Davies
2023-08-20  0:47 ` [PATCH 09/16] Staging: rtl8192e: Rename variable tmp in function GetTs() Tree Davies
2023-08-20  0:47 ` [PATCH 10/16] Staging: rtl8192e: Rename variable pRxTS in function RemoveTsEntry() Tree Davies
2023-08-20  0:47 ` [PATCH 11/16] Staging: rtl8192e: Rename variable pTS in function prototype rtllib_FlushRxTsPendingPkts() Tree Davies
2023-08-20  0:47 ` [PATCH 12/16] Staging: rtl8192e: Rename variable pTS in function AddReorderEntry() Tree Davies
2023-08-20  0:47 ` [PATCH 13/16] Staging: rtl8192e: Rename variable pTS in function rtllib_FlushRxTsPendingPkts() Tree Davies
2023-08-20  0:47 ` [PATCH 14/16] Staging: rtl8192e: Rename variable pTS in function RxReorderIndicatePacket() Tree Davies
2023-08-20  0:47 ` [PATCH 15/16] Staging: rtl8192e: Rename variable pRxTS in function rtllib_rx_check_duplicate() Tree Davies
2023-08-20  0:47 ` [PATCH 16/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_InfraAdhoc() Tree Davies
2023-08-20  4:40 ` [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Philipp Hortmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.