From: Steven Rostedt <rostedt@goodmis.org>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jakub Kicinski <kuba@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
ksummit@lists.linux.dev, Jeff Layton <jlayton@kernel.org>,
Song Liu <song@kernel.org>
Subject: Re: [MAINTAINERS SUMMIT] Maintainer burnout
Date: Tue, 29 Aug 2023 08:54:05 -0400 [thread overview]
Message-ID: <20230829085405.5faf3b51@rorschach.local.home> (raw)
In-Reply-To: <e7554530-a1a5-216f-9a17-7cf763ee6a9d@oracle.com>
On Mon, 21 Aug 2023 21:23:18 +0200
Vegard Nossum <vegard.nossum@oracle.com> wrote:
> Can we maybe adjust the standards of the Reviewed-by: tag to mean that
> the person has looked at the patch (or an earlier version of it) and
> provided comments that show they actually put some effort into it?
> For example, if a patch is changing a function (as patches often do),
> the reviewer should add a line saying "error paths in foo() lgtm"
> and not just tack on their Reviewed-by: line.
>
> This adjustment would make it harder to just slap a Reviewed-by: on a
> patch, but it would also make it easier to get your name in the
> changelog provided that you actually put the effort in.
Note, when I can't do a real review, I just slap an Acked-by tag to it.
That to me means LGTM, but I haven't looked deep into it.
-- Steve
next prev parent reply other threads:[~2023-08-29 12:54 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 18:08 [MAINTAINERS SUMMIT] Maintainer burnout Josef Bacik
2023-08-16 20:14 ` Luis Chamberlain
2023-08-17 9:39 ` Laurent Pinchart
2023-08-17 12:36 ` Andrew Lunn
2023-08-17 15:19 ` Jakub Kicinski
2023-08-17 23:54 ` Alexei Starovoitov
2023-08-18 13:55 ` Linus Walleij
2023-08-18 15:09 ` Jakub Kicinski
2023-08-18 17:07 ` Linus Torvalds
2023-08-19 6:45 ` Leon Romanovsky
2023-08-21 15:35 ` Laurent Pinchart
2023-08-22 7:41 ` Jiri Kosina
2023-08-22 9:05 ` Hannes Reinecke
2023-08-22 10:13 ` Leon Romanovsky
2023-08-22 11:25 ` Laurent Pinchart
2023-08-21 19:23 ` Vegard Nossum
2023-08-22 4:07 ` Dave Airlie
2023-08-22 9:46 ` Jan Kara
2023-08-22 10:10 ` Christian Brauner
2023-08-22 10:20 ` Jan Kara
2023-08-22 11:29 ` Laurent Pinchart
2023-08-22 11:05 ` Leon Romanovsky
2023-08-22 11:32 ` Laurent Pinchart
2023-08-22 13:47 ` Leon Romanovsky
2023-08-22 13:30 ` Jan Kara
2023-08-29 12:54 ` Steven Rostedt [this message]
2023-09-13 9:02 ` Dan Carpenter
2023-08-21 8:50 ` Daniel Vetter
2023-08-21 15:18 ` Jakub Kicinski
2023-08-22 4:12 ` Dave Airlie
2023-08-18 15:26 ` Laurent Pinchart
2023-08-18 15:40 ` Konrad Rzeszutek Wilk
2023-08-18 18:36 ` Mark Brown
2023-08-21 16:13 ` Laurent Pinchart
2023-08-18 16:10 ` Mark Brown
2023-08-21 16:04 ` Laurent Pinchart
2023-08-24 21:30 ` Jonathan Cameron
2023-08-25 7:05 ` Krzysztof Kozlowski
2023-08-17 12:00 ` Jani Nikula
2023-08-17 12:17 ` Mark Brown
2023-08-17 12:42 ` Laurent Pinchart
2023-08-17 13:56 ` Miguel Ojeda
2023-08-17 15:03 ` Laurent Pinchart
2023-08-17 17:41 ` Miguel Ojeda
2023-08-18 15:30 ` Laurent Pinchart
2023-08-18 16:23 ` Mark Brown
2023-08-18 17:17 ` Laurent Pinchart
2023-08-18 18:00 ` Mark Brown
2023-08-17 14:46 ` Mark Brown
2023-08-17 14:22 ` Steven Rostedt
2023-08-17 15:31 ` Jani Nikula
2023-08-17 14:46 ` Steven Rostedt
2023-08-17 15:33 ` Josef Bacik
2023-08-17 17:10 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829085405.5faf3b51@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrew@lunn.ch \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=ksummit@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=leon@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=mcgrof@kernel.org \
--cc=song@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.