* [PATCH] drm/amd: Make fence wait in suballocator uninterruptible
@ 2023-09-01 7:31 Simon Pilkington
0 siblings, 0 replies; 2+ messages in thread
From: Simon Pilkington @ 2023-09-01 7:31 UTC (permalink / raw)
To: amd-gfx; +Cc: Simon Pilkington
Commit c103a23f2f29
("drm/amd: Convert amdgpu to use suballocation helper.")
made the fence wait in amdgpu_sa_bo_new() interruptible but there is no
code to handle an interrupt. This caused the kernel to randomly explode
in high-VRAM-pressure situations so make it uninterruptible again.
Fixes: c103a23f2f29 ("drm/amd: Convert amdgpu to use suballocation helper.")
Signed-off-by: Simon Pilkington <simonp.git@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
index c6b4337eb20c..10df731998b2 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
@@ -81,7 +81,7 @@ int amdgpu_sa_bo_new(struct amdgpu_sa_manager *sa_manager,
unsigned int size)
{
struct drm_suballoc *sa = drm_suballoc_new(&sa_manager->base, size,
- GFP_KERNEL, true, 0);
+ GFP_KERNEL, false, 0);
if (IS_ERR(sa)) {
*sa_bo = NULL;
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] drm/amd: Make fence wait in suballocator uninterruptible
@ 2023-09-01 2:01 Simon Pilkington
0 siblings, 0 replies; 2+ messages in thread
From: Simon Pilkington @ 2023-09-01 2:01 UTC (permalink / raw)
To: amd-gfx; +Cc: Simon Pilkington
c103a23f2f297c6ab2e5e74e39b655439f3524a6 made the fence wait in
amdgpu_sa_bo_new() interruptible but there is no code to handle an interrupt.
This caused the kernel to randomly explode in high-VRAM-pressure situations
so make it uninterruptible again.
Signed-off-by: Simon Pilkington <simonp.git@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
index c6b4337eb20c..10df731998b2 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
@@ -81,7 +81,7 @@ int amdgpu_sa_bo_new(struct amdgpu_sa_manager *sa_manager,
unsigned int size)
{
struct drm_suballoc *sa = drm_suballoc_new(&sa_manager->base, size,
- GFP_KERNEL, true, 0);
+ GFP_KERNEL, false, 0);
if (IS_ERR(sa)) {
*sa_bo = NULL;
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-01 19:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-01 7:31 [PATCH] drm/amd: Make fence wait in suballocator uninterruptible Simon Pilkington
-- strict thread matches above, loose matches on Subject: below --
2023-09-01 2:01 Simon Pilkington
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.