All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Danilo Krummrich <dakr@redhat.com>,
	airlied@gmail.com, daniel@ffwll.ch, matthew.brost@intel.com,
	thomas.hellstrom@linux.intel.com, sarah.walker@imgtec.com,
	donald.robson@imgtec.com, boris.brezillon@collabora.com,
	christian.koenig@amd.com, faith.ekstrand@collabora.com
Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, oe-kbuild-all@lists.linux.dev
Subject: Re: [Nouveau] [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation
Date: Thu, 7 Sep 2023 08:12:58 +0800	[thread overview]
Message-ID: <202309070844.arxMNmRa-lkp@intel.com> (raw)
In-Reply-To: <20230906214723.4393-7-dakr@redhat.com>

Hi Danilo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 6bd3d8da51ca1ec97c724016466606aec7739b9f]

url:    https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-gpuva_mgr-allow-building-as-module/20230907-054931
base:   6bd3d8da51ca1ec97c724016466606aec7739b9f
patch link:    https://lore.kernel.org/r/20230906214723.4393-7-dakr%40redhat.com
patch subject: [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation
config: riscv-defconfig (https://download.01.org/0day-ci/archive/20230907/202309070844.arxMNmRa-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230907/202309070844.arxMNmRa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309070844.arxMNmRa-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_gpuva_mgr.c:998: warning: Function parameter or member 'exec' not described in 'drm_gpuvm_resv_add_fence'


vim +998 drivers/gpu/drm/drm_gpuva_mgr.c

   983	
   984	/**
   985	 * drm_gpuvm_resv_add_fence - add fence to private and all extobj
   986	 * dma-resv
   987	 * @gpuvm: the &drm_gpuvm to add a fence to
   988	 * @fence: fence to add
   989	 * @private_usage: private dma-resv usage
   990	 * @extobj_usage: extobj dma-resv usage
   991	 */
   992	void
   993	drm_gpuvm_resv_add_fence(struct drm_gpuvm *gpuvm,
   994				 struct drm_exec *exec,
   995				 struct dma_fence *fence,
   996				 enum dma_resv_usage private_usage,
   997				 enum dma_resv_usage extobj_usage)
 > 998	{
   999		struct drm_gem_object *obj;
  1000		unsigned long index;
  1001	
  1002		drm_exec_for_each_locked_object(exec, index, obj) {
  1003				dma_resv_assert_held(obj->resv);
  1004				dma_resv_add_fence(obj->resv, fence,
  1005						   drm_gpuvm_is_extobj(gpuvm, obj) ?
  1006						   private_usage : extobj_usage);
  1007		}
  1008	}
  1009	EXPORT_SYMBOL_GPL(drm_gpuvm_resv_add_fence);
  1010	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Danilo Krummrich <dakr@redhat.com>,
	airlied@gmail.com, daniel@ffwll.ch, matthew.brost@intel.com,
	thomas.hellstrom@linux.intel.com, sarah.walker@imgtec.com,
	donald.robson@imgtec.com, boris.brezillon@collabora.com,
	christian.koenig@amd.com, faith.ekstrand@collabora.com
Cc: oe-kbuild-all@lists.linux.dev, nouveau@lists.freedesktop.org,
	Danilo Krummrich <dakr@redhat.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation
Date: Thu, 7 Sep 2023 08:12:58 +0800	[thread overview]
Message-ID: <202309070844.arxMNmRa-lkp@intel.com> (raw)
In-Reply-To: <20230906214723.4393-7-dakr@redhat.com>

Hi Danilo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 6bd3d8da51ca1ec97c724016466606aec7739b9f]

url:    https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-gpuva_mgr-allow-building-as-module/20230907-054931
base:   6bd3d8da51ca1ec97c724016466606aec7739b9f
patch link:    https://lore.kernel.org/r/20230906214723.4393-7-dakr%40redhat.com
patch subject: [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation
config: riscv-defconfig (https://download.01.org/0day-ci/archive/20230907/202309070844.arxMNmRa-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230907/202309070844.arxMNmRa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309070844.arxMNmRa-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_gpuva_mgr.c:998: warning: Function parameter or member 'exec' not described in 'drm_gpuvm_resv_add_fence'


vim +998 drivers/gpu/drm/drm_gpuva_mgr.c

   983	
   984	/**
   985	 * drm_gpuvm_resv_add_fence - add fence to private and all extobj
   986	 * dma-resv
   987	 * @gpuvm: the &drm_gpuvm to add a fence to
   988	 * @fence: fence to add
   989	 * @private_usage: private dma-resv usage
   990	 * @extobj_usage: extobj dma-resv usage
   991	 */
   992	void
   993	drm_gpuvm_resv_add_fence(struct drm_gpuvm *gpuvm,
   994				 struct drm_exec *exec,
   995				 struct dma_fence *fence,
   996				 enum dma_resv_usage private_usage,
   997				 enum dma_resv_usage extobj_usage)
 > 998	{
   999		struct drm_gem_object *obj;
  1000		unsigned long index;
  1001	
  1002		drm_exec_for_each_locked_object(exec, index, obj) {
  1003				dma_resv_assert_held(obj->resv);
  1004				dma_resv_add_fence(obj->resv, fence,
  1005						   drm_gpuvm_is_extobj(gpuvm, obj) ?
  1006						   private_usage : extobj_usage);
  1007		}
  1008	}
  1009	EXPORT_SYMBOL_GPL(drm_gpuvm_resv_add_fence);
  1010	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Danilo Krummrich <dakr@redhat.com>,
	airlied@gmail.com, daniel@ffwll.ch, matthew.brost@intel.com,
	thomas.hellstrom@linux.intel.com, sarah.walker@imgtec.com,
	donald.robson@imgtec.com, boris.brezillon@collabora.com,
	christian.koenig@amd.com, faith.ekstrand@collabora.com
Cc: nouveau@lists.freedesktop.org, Danilo Krummrich <dakr@redhat.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation
Date: Thu, 7 Sep 2023 08:12:58 +0800	[thread overview]
Message-ID: <202309070844.arxMNmRa-lkp@intel.com> (raw)
In-Reply-To: <20230906214723.4393-7-dakr@redhat.com>

Hi Danilo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 6bd3d8da51ca1ec97c724016466606aec7739b9f]

url:    https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-gpuva_mgr-allow-building-as-module/20230907-054931
base:   6bd3d8da51ca1ec97c724016466606aec7739b9f
patch link:    https://lore.kernel.org/r/20230906214723.4393-7-dakr%40redhat.com
patch subject: [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation
config: riscv-defconfig (https://download.01.org/0day-ci/archive/20230907/202309070844.arxMNmRa-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230907/202309070844.arxMNmRa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309070844.arxMNmRa-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_gpuva_mgr.c:998: warning: Function parameter or member 'exec' not described in 'drm_gpuvm_resv_add_fence'


vim +998 drivers/gpu/drm/drm_gpuva_mgr.c

   983	
   984	/**
   985	 * drm_gpuvm_resv_add_fence - add fence to private and all extobj
   986	 * dma-resv
   987	 * @gpuvm: the &drm_gpuvm to add a fence to
   988	 * @fence: fence to add
   989	 * @private_usage: private dma-resv usage
   990	 * @extobj_usage: extobj dma-resv usage
   991	 */
   992	void
   993	drm_gpuvm_resv_add_fence(struct drm_gpuvm *gpuvm,
   994				 struct drm_exec *exec,
   995				 struct dma_fence *fence,
   996				 enum dma_resv_usage private_usage,
   997				 enum dma_resv_usage extobj_usage)
 > 998	{
   999		struct drm_gem_object *obj;
  1000		unsigned long index;
  1001	
  1002		drm_exec_for_each_locked_object(exec, index, obj) {
  1003				dma_resv_assert_held(obj->resv);
  1004				dma_resv_add_fence(obj->resv, fence,
  1005						   drm_gpuvm_is_extobj(gpuvm, obj) ?
  1006						   private_usage : extobj_usage);
  1007		}
  1008	}
  1009	EXPORT_SYMBOL_GPL(drm_gpuvm_resv_add_fence);
  1010	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2023-09-07  0:13 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06 21:47 [Nouveau] [PATCH drm-misc-next v2 0/7] [RFC] DRM GPUVA Manager GPU-VM features Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 1/7] drm: gpuva_mgr: allow building as module Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 2/7] drm/gpuvm: rename struct drm_gpuva_manager to struct drm_gpuvm Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-07  7:56   ` Boris Brezillon
2023-09-07  7:56     ` Boris Brezillon
2023-09-07  8:54     ` [Nouveau] " Danilo Krummrich
2023-09-07  8:54       ` Danilo Krummrich
2023-09-07  8:51   ` [Nouveau] " kernel test robot
2023-09-07  8:51     ` kernel test robot
2023-09-07  8:51     ` kernel test robot
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 3/7] drm/nouveau: uvmm: rename 'umgr' to 'base' Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 4/7] drm/gpuvm: common dma-resv per struct drm_gpuvm Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 5/7] drm/gpuvm: add an abstraction for a VM / BO combination Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-07  8:16   ` Boris Brezillon
2023-09-07  8:16     ` Boris Brezillon
2023-09-07  9:11     ` [Nouveau] " Danilo Krummrich
2023-09-07  9:11       ` Danilo Krummrich
2023-09-07  9:11       ` Danilo Krummrich
2023-09-07  8:42   ` Boris Brezillon
2023-09-07  8:42     ` Boris Brezillon
2023-09-07  9:41     ` [Nouveau] " Danilo Krummrich
2023-09-07  9:41       ` Danilo Krummrich
2023-09-07  9:41       ` Danilo Krummrich
2023-09-07 11:05       ` Boris Brezillon
2023-09-07 11:05         ` Boris Brezillon
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-07  0:12   ` kernel test robot [this message]
2023-09-07  0:12     ` kernel test robot
2023-09-07  0:12     ` kernel test robot
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 7/7] drm/nouveau: GPUVM dma-resv/extobj handling, " Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich
2023-09-06 21:47   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202309070844.arxMNmRa-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=airlied@gmail.com \
    --cc=boris.brezillon@collabora.com \
    --cc=christian.koenig@amd.com \
    --cc=dakr@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=donald.robson@imgtec.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=faith.ekstrand@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=sarah.walker@imgtec.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.