From: Boris Brezillon <boris.brezillon@collabora.com>
To: Danilo Krummrich <dakr@redhat.com>
Cc: matthew.brost@intel.com, thomas.hellstrom@linux.intel.com,
sarah.walker@imgtec.com, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
donald.robson@imgtec.com, christian.koenig@amd.com,
faith.ekstrand@collabora.com
Subject: Re: [PATCH drm-misc-next v2 2/7] drm/gpuvm: rename struct drm_gpuva_manager to struct drm_gpuvm
Date: Thu, 7 Sep 2023 09:56:49 +0200 [thread overview]
Message-ID: <20230907095649.13dbd49c@collabora.com> (raw)
In-Reply-To: <20230906214723.4393-3-dakr@redhat.com>
On Wed, 6 Sep 2023 23:47:10 +0200
Danilo Krummrich <dakr@redhat.com> wrote:
> Rename struct drm_gpuva_manager to struct drm_gpuvm including
> corresponding functions. This way the GPUVA manager's structures align
> very well with the documentation of VM_BIND [1] and VM_BIND locking [2].
>
> It also provides a better foundation for the naming of data structures
> and functions introduced for implementing a common dma-resv per GPU-VM
> including tracking of external and evicted objects in subsequent
> patches.
I'm fine with this rename, but I feel like some bits are missing in
this patch. I see a few functions taking a drm_gpuvm object and still
being prefixed with drm_gpuva_ (I'm not talking about functions that
only manipulate a drm_gpuva object, but those updating the the VM state,
like the sm_map/unmap helpers), and I think it'd be preferable to
rename the source files and the Kconfig option too.
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Danilo Krummrich <dakr@redhat.com>
Cc: airlied@gmail.com, daniel@ffwll.ch, matthew.brost@intel.com,
thomas.hellstrom@linux.intel.com, sarah.walker@imgtec.com,
donald.robson@imgtec.com, christian.koenig@amd.com,
faith.ekstrand@collabora.com, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH drm-misc-next v2 2/7] drm/gpuvm: rename struct drm_gpuva_manager to struct drm_gpuvm
Date: Thu, 7 Sep 2023 09:56:49 +0200 [thread overview]
Message-ID: <20230907095649.13dbd49c@collabora.com> (raw)
In-Reply-To: <20230906214723.4393-3-dakr@redhat.com>
On Wed, 6 Sep 2023 23:47:10 +0200
Danilo Krummrich <dakr@redhat.com> wrote:
> Rename struct drm_gpuva_manager to struct drm_gpuvm including
> corresponding functions. This way the GPUVA manager's structures align
> very well with the documentation of VM_BIND [1] and VM_BIND locking [2].
>
> It also provides a better foundation for the naming of data structures
> and functions introduced for implementing a common dma-resv per GPU-VM
> including tracking of external and evicted objects in subsequent
> patches.
I'm fine with this rename, but I feel like some bits are missing in
this patch. I see a few functions taking a drm_gpuvm object and still
being prefixed with drm_gpuva_ (I'm not talking about functions that
only manipulate a drm_gpuva object, but those updating the the VM state,
like the sm_map/unmap helpers), and I think it'd be preferable to
rename the source files and the Kconfig option too.
next prev parent reply other threads:[~2023-09-07 7:56 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 21:47 [Nouveau] [PATCH drm-misc-next v2 0/7] [RFC] DRM GPUVA Manager GPU-VM features Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 1/7] drm: gpuva_mgr: allow building as module Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 2/7] drm/gpuvm: rename struct drm_gpuva_manager to struct drm_gpuvm Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-07 7:56 ` Boris Brezillon [this message]
2023-09-07 7:56 ` Boris Brezillon
2023-09-07 8:54 ` [Nouveau] " Danilo Krummrich
2023-09-07 8:54 ` Danilo Krummrich
2023-09-07 8:51 ` [Nouveau] " kernel test robot
2023-09-07 8:51 ` kernel test robot
2023-09-07 8:51 ` kernel test robot
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 3/7] drm/nouveau: uvmm: rename 'umgr' to 'base' Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 4/7] drm/gpuvm: common dma-resv per struct drm_gpuvm Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 5/7] drm/gpuvm: add an abstraction for a VM / BO combination Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-07 8:16 ` Boris Brezillon
2023-09-07 8:16 ` Boris Brezillon
2023-09-07 9:11 ` [Nouveau] " Danilo Krummrich
2023-09-07 9:11 ` Danilo Krummrich
2023-09-07 9:11 ` Danilo Krummrich
2023-09-07 8:42 ` Boris Brezillon
2023-09-07 8:42 ` Boris Brezillon
2023-09-07 9:41 ` [Nouveau] " Danilo Krummrich
2023-09-07 9:41 ` Danilo Krummrich
2023-09-07 9:41 ` Danilo Krummrich
2023-09-07 11:05 ` Boris Brezillon
2023-09-07 11:05 ` Boris Brezillon
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-07 0:12 ` [Nouveau] " kernel test robot
2023-09-07 0:12 ` kernel test robot
2023-09-07 0:12 ` kernel test robot
2023-09-06 21:47 ` [Nouveau] [PATCH drm-misc-next v2 7/7] drm/nouveau: GPUVM dma-resv/extobj handling, " Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
2023-09-06 21:47 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907095649.13dbd49c@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dakr@redhat.com \
--cc=donald.robson@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith.ekstrand@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=nouveau@lists.freedesktop.org \
--cc=sarah.walker@imgtec.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.