All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Trevor Woerner <twoerner@gmail.com>
Cc: robertcnelson@gmail.com, drew@beagleboard.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 4/4] ARM: dts: am335x-pocketbeagle: add missing GPIO mux
Date: Tue, 26 Sep 2023 10:25:38 +0300	[thread overview]
Message-ID: <20230926072538.GY5285@atomide.com> (raw)
In-Reply-To: <20230822143051.7640-5-twoerner@gmail.com>

* Trevor Woerner <twoerner@gmail.com> [230822 14:31]:
> Add the default MODE setting of a GPIO pin that was missing from the device
> tree (i.e. P2.20/gpio2_00). This is to ensure the GPIO pins match the
> pocketbeagle wiring expectations.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> index e35d84ca5706..8042917b3b3b 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> @@ -271,6 +271,16 @@ AM33XX_PADCONF(AM335X_PIN_GPMC_AD14, PIN_INPUT_PULLUP, MUX_MODE7)
>  		pinctrl-single,bias-pulldown   = < 0x10  0x00  0x10  0x18>;
>  	};
>  
> +	/* P2_20 (ZCZ ball T13) gpio2_00 0x888 */
> +	P2_20_gpio: P2-20-gpio-pins {
> +		pinctrl-single,pins = <
> +			AM33XX_PADCONF(AM335X_PIN_GPMC_CSN3, PIN_INPUT_PULLUP, MUX_MODE7)
> +		>;
> +		pinctrl-single,bias-pullup   =   < 0x10  0x10  0x00  0x18>;
> +		pinctrl-single,bias-pulldown   = < 0x10  0x00  0x10  0x18>;
> +	};
> +
> +
>  	/* P2_10 (ZCZ ball R14) gpio1_20 0x850 PIN 20 */
>  	P2_10_gpio: P2-10-gpio-pins {
>  		pinctrl-single,pins = <

Thanks applying all four patches into omap-for-v6.7/dt. I left out the extra
line break above though.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Trevor Woerner <twoerner@gmail.com>
Cc: robertcnelson@gmail.com, drew@beagleboard.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 4/4] ARM: dts: am335x-pocketbeagle: add missing GPIO mux
Date: Tue, 26 Sep 2023 10:25:38 +0300	[thread overview]
Message-ID: <20230926072538.GY5285@atomide.com> (raw)
In-Reply-To: <20230822143051.7640-5-twoerner@gmail.com>

* Trevor Woerner <twoerner@gmail.com> [230822 14:31]:
> Add the default MODE setting of a GPIO pin that was missing from the device
> tree (i.e. P2.20/gpio2_00). This is to ensure the GPIO pins match the
> pocketbeagle wiring expectations.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> index e35d84ca5706..8042917b3b3b 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> @@ -271,6 +271,16 @@ AM33XX_PADCONF(AM335X_PIN_GPMC_AD14, PIN_INPUT_PULLUP, MUX_MODE7)
>  		pinctrl-single,bias-pulldown   = < 0x10  0x00  0x10  0x18>;
>  	};
>  
> +	/* P2_20 (ZCZ ball T13) gpio2_00 0x888 */
> +	P2_20_gpio: P2-20-gpio-pins {
> +		pinctrl-single,pins = <
> +			AM33XX_PADCONF(AM335X_PIN_GPMC_CSN3, PIN_INPUT_PULLUP, MUX_MODE7)
> +		>;
> +		pinctrl-single,bias-pullup   =   < 0x10  0x10  0x00  0x18>;
> +		pinctrl-single,bias-pulldown   = < 0x10  0x00  0x10  0x18>;
> +	};
> +
> +
>  	/* P2_10 (ZCZ ball R14) gpio1_20 0x850 PIN 20 */
>  	P2_10_gpio: P2-10-gpio-pins {
>  		pinctrl-single,pins = <

Thanks applying all four patches into omap-for-v6.7/dt. I left out the extra
line break above though.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-26  7:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22 14:30 [PATCH v3 0/4] pocketbeagle device tree updates Trevor Woerner
2023-08-22 14:30 ` Trevor Woerner
2023-08-22 14:30 ` [PATCH v3 1/4] ARM: dts: am335x-pocketbeagle: update LED information Trevor Woerner
2023-08-22 14:30   ` Trevor Woerner
2023-08-22 14:30 ` [PATCH v3 2/4] ARM: dts: am335x-pocketbeagle: remove dependency cycle Trevor Woerner
2023-08-22 14:30   ` Trevor Woerner
2023-08-22 14:30 ` [PATCH v3 3/4] ARM: dts: am335x-pocketbeagle: enable pru Trevor Woerner
2023-08-22 14:30   ` Trevor Woerner
2023-08-22 14:30 ` [PATCH v3 4/4] ARM: dts: am335x-pocketbeagle: add missing GPIO mux Trevor Woerner
2023-08-22 14:30   ` Trevor Woerner
2023-09-26  7:25   ` Tony Lindgren [this message]
2023-09-26  7:25     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926072538.GY5285@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drew@beagleboard.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robertcnelson@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=twoerner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.