From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
Helge Deller <deller@gmx.de>,
dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
kernel@pengutronix.de
Subject: Re: [PATCH v2] backlight: pwm_bl: Disable PWM on shutdown and suspend
Date: Tue, 26 Sep 2023 10:16:59 +0100 [thread overview]
Message-ID: <20230926091659.GF9999@google.com> (raw)
In-Reply-To: <20230926085336.czgrztefbrstzbw7@pengutronix.de>
On Tue, 26 Sep 2023, Uwe Kleine-König wrote:
> On Tue, Sep 26, 2023 at 10:46:12AM +0200, Uwe Kleine-König wrote:
> > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once
> > per backlight toggle") calling pwm_backlight_power_off() doesn't disable
> > the PWM any more. However this is necessary to suspend because PWM
> > drivers usually refuse to suspend if they are still enabled.
> >
> > Also adapt shutdown to disable the PWM for similar reasons.
> >
> > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle")
> > Reported-by: Aisheng Dong <aisheng.dong@nxp.com>
> > Tested-by: Aisheng Dong <asheng.dong@nxp.com>
>
> The two email addresses should actually be identical, the first one is
> the right one. (Failure introduced by
> https://lore.kernel.org/dri-devel/DB9PR04MB8477D4BBF1B31035789DA08680869@DB9PR04MB8477.eurprd04.prod.outlook.com
> and picked up by b4.) Lee, can you fixup or should I resend?
I'll probably forget by the time Daniel gets around to review.
Your call, but probably safer to turn it around yourself.
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
linux-pwm@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
kernel@pengutronix.de
Subject: Re: [PATCH v2] backlight: pwm_bl: Disable PWM on shutdown and suspend
Date: Tue, 26 Sep 2023 10:16:59 +0100 [thread overview]
Message-ID: <20230926091659.GF9999@google.com> (raw)
In-Reply-To: <20230926085336.czgrztefbrstzbw7@pengutronix.de>
On Tue, 26 Sep 2023, Uwe Kleine-König wrote:
> On Tue, Sep 26, 2023 at 10:46:12AM +0200, Uwe Kleine-König wrote:
> > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once
> > per backlight toggle") calling pwm_backlight_power_off() doesn't disable
> > the PWM any more. However this is necessary to suspend because PWM
> > drivers usually refuse to suspend if they are still enabled.
> >
> > Also adapt shutdown to disable the PWM for similar reasons.
> >
> > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle")
> > Reported-by: Aisheng Dong <aisheng.dong@nxp.com>
> > Tested-by: Aisheng Dong <asheng.dong@nxp.com>
>
> The two email addresses should actually be identical, the first one is
> the right one. (Failure introduced by
> https://lore.kernel.org/dri-devel/DB9PR04MB8477D4BBF1B31035789DA08680869@DB9PR04MB8477.eurprd04.prod.outlook.com
> and picked up by b4.) Lee, can you fixup or should I resend?
I'll probably forget by the time Daniel gets around to review.
Your call, but probably safer to turn it around yourself.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-09-26 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 8:46 [PATCH v2] backlight: pwm_bl: Disable PWM on shutdown and suspend Uwe Kleine-König
2023-09-26 8:46 ` Uwe Kleine-König
2023-09-26 8:53 ` Uwe Kleine-König
2023-09-26 9:16 ` Lee Jones [this message]
2023-09-26 9:16 ` Lee Jones
2023-09-26 11:11 ` Daniel Thompson
2023-09-26 11:11 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926091659.GF9999@google.com \
--to=lee@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.