From: Jakub Kicinski <kuba@kernel.org>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Rohan G Thomas <rohan.g.thomas@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling
Date: Mon, 2 Oct 2023 13:55:51 -0700 [thread overview]
Message-ID: <20231002135551.020f180c@kernel.org> (raw)
In-Reply-To: <xwcwjtyy5yx6pruoa3vmssnjzkbeahmfyym4e5lrq2efcwwiym@2upf4ko4mah5>
On Tue, 26 Sep 2023 14:25:56 +0300 Serge Semin wrote:
> On Sat, Sep 23, 2023 at 11:10:31AM +0800, Rohan G Thomas wrote:
> > Enabled the following EST related interrupts:
> > 1) Constant Gate Control Error (CGCE)
> > 2) Head-of-Line Blocking due to Scheduling (HLBS)
> > 3) Head-of-Line Blocking due to Frame Size (HLBF)
> > 4) Base Time Register error (BTRE)
> > 5) Switch to S/W owned list Complete (SWLC)
> > Also, add EST errors into the ethtool statistic.
> >
> > The commit e49aa315cb01 ("net: stmmac: EST interrupts handling and
> > error reporting") and commit 9f298959191b ("net: stmmac: Add EST
> > errors into ethtool statistic") add EST interrupts handling and error
> > reporting support to DWMAC4 core. This patch enables the same support
> > for XGMAC.
>
> So, this is basically a copy of what was done for the DW QoS Eth
> IP-core (DW GMAC v4.x/v5.x). IMO it would be better to factor it out
> into a separate module together with the rest of the setup methods
> like it's done for TC or PTP. But since it implies some much more work
> I guess we can leave it as is for now...
I think we can push back a little harder. At the very least we should
get a clear explanation why this copy'n'paste is needed, i.e. what are
the major differences. No?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Rohan G Thomas <rohan.g.thomas@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling
Date: Mon, 2 Oct 2023 13:55:51 -0700 [thread overview]
Message-ID: <20231002135551.020f180c@kernel.org> (raw)
In-Reply-To: <xwcwjtyy5yx6pruoa3vmssnjzkbeahmfyym4e5lrq2efcwwiym@2upf4ko4mah5>
On Tue, 26 Sep 2023 14:25:56 +0300 Serge Semin wrote:
> On Sat, Sep 23, 2023 at 11:10:31AM +0800, Rohan G Thomas wrote:
> > Enabled the following EST related interrupts:
> > 1) Constant Gate Control Error (CGCE)
> > 2) Head-of-Line Blocking due to Scheduling (HLBS)
> > 3) Head-of-Line Blocking due to Frame Size (HLBF)
> > 4) Base Time Register error (BTRE)
> > 5) Switch to S/W owned list Complete (SWLC)
> > Also, add EST errors into the ethtool statistic.
> >
> > The commit e49aa315cb01 ("net: stmmac: EST interrupts handling and
> > error reporting") and commit 9f298959191b ("net: stmmac: Add EST
> > errors into ethtool statistic") add EST interrupts handling and error
> > reporting support to DWMAC4 core. This patch enables the same support
> > for XGMAC.
>
> So, this is basically a copy of what was done for the DW QoS Eth
> IP-core (DW GMAC v4.x/v5.x). IMO it would be better to factor it out
> into a separate module together with the rest of the setup methods
> like it's done for TC or PTP. But since it implies some much more work
> I guess we can leave it as is for now...
I think we can push back a little harder. At the very least we should
get a clear explanation why this copy'n'paste is needed, i.e. what are
the major differences. No?
next prev parent reply other threads:[~2023-10-02 20:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 3:10 [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling Rohan G Thomas
2023-09-23 3:10 ` Rohan G Thomas
2023-09-26 11:25 ` Serge Semin
2023-09-26 11:25 ` Serge Semin
2023-10-02 20:55 ` Jakub Kicinski [this message]
2023-10-02 20:55 ` Jakub Kicinski
2023-10-03 11:12 ` Serge Semin
2023-10-03 11:12 ` Serge Semin
2023-10-04 16:26 ` Jakub Kicinski
2023-10-04 16:26 ` Jakub Kicinski
2023-10-05 12:14 ` Rohan G Thomas
2023-10-05 12:14 ` Rohan G Thomas
2023-10-05 14:05 ` Jakub Kicinski
2023-10-05 14:05 ` Jakub Kicinski
2023-10-06 7:23 ` Rohan G Thomas
2023-10-06 7:23 ` Rohan G Thomas
2023-10-06 10:08 ` Serge Semin
2023-10-06 10:08 ` Serge Semin
2023-10-06 13:35 ` Jakub Kicinski
2023-10-06 13:35 ` Jakub Kicinski
2023-12-01 6:49 ` Rohan G Thomas
2023-12-01 6:49 ` Rohan G Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002135551.020f180c@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rohan.g.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.