From: Nishanth Menon <nm@ti.com>
To: Ayush Singh <ayushdevel1325@gmail.com>
Cc: <greybus-dev@lists.linaro.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<vaishnav@beagleboard.org>, <jkridner@beagleboard.org>,
<krzysztof.kozlowski+dt@linaro.org>, <vigneshr@ti.com>,
<kristo@kernel.org>, <robh+dt@kernel.org>, <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 1/3] dt-bindings: Add beaglecc1352
Date: Tue, 3 Oct 2023 08:05:56 -0500 [thread overview]
Message-ID: <20231003130556.ateaoj7der45dml6@huddle> (raw)
In-Reply-To: <706a8f30-847c-2641-aeee-6c4d4692e573@gmail.com>
On 18:17-20231003, Ayush Singh wrote:
> > > +
> > > + reset-gpios:
> > > + maxItems: 1
> > > +
> > > + power-gpios:
> > > + maxItems: 3
> > > + description:
> > > + The device has three power rails that are exposed on external pins VDDS,
> > > + VDDR and DCOUPL.
> > Shouldn't these be regulators? The power rails are input to the MCU,
> > correct?
> > The properties should be something like:
> > vdds-supply
> > vddr-supply
> > dcoupl-supply ? (not sure what dcoupl is, but description should provide
> > that info).
> >
> > the gpio controls for those can be modelled by regulator-gpio ?
>
> I picked up power lines from "CC13xx/CC26xx Hardware Configuration and PCB
> Design Considerations Application Report" present under "8.14 Network
> Processor" of CC1352P7 data sheet.
>
> But now looking closer, it doesn't seem like DCOUPL can be supplied
> externally for CC1352P7 and thus should probably be removed.
>
> Also, it seems like for CC1352P7, VDDR must always be supplied internally
> (The data sheet states: "Internal supply, must be powered from the internal
> DC/DC converter or the internal LDO"). Thus, it should be safe to remove
> VDDR as well.
From Figure 3-1. CC1312R 7x7 RF Part Schematic Overview (app report you
point out below)
Typical usage is vdds-supply supplying:
VDDS (pin 44)
VDDS2 (pin 13)
VDDS3 (pin 22)
VDDS_DCDC (pin 34)
And DCDC_SW (pin 33) supplies vddr supplying:
VDDR(pin 45)
VDDR_RF (Pin 48)
>
>
> That means only VDDS needs to be present for power line.
I agree that that would be the typical supply model. So, just
vdds-supply
>
>
> CC13xx/CC26xx Hardware Configuration and PCB Design Considerations
> Application Report: https://www.ti.com/lit/pdf/swra640
>
> CC1352P7 Data sheet: https://www.ti.com/lit/gpn/CC1352P7
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Ayush Singh <ayushdevel1325@gmail.com>
Cc: <greybus-dev@lists.linaro.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<vaishnav@beagleboard.org>, <jkridner@beagleboard.org>,
<krzysztof.kozlowski+dt@linaro.org>, <vigneshr@ti.com>,
<kristo@kernel.org>, <robh+dt@kernel.org>, <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 1/3] dt-bindings: Add beaglecc1352
Date: Tue, 3 Oct 2023 08:05:56 -0500 [thread overview]
Message-ID: <20231003130556.ateaoj7der45dml6@huddle> (raw)
In-Reply-To: <706a8f30-847c-2641-aeee-6c4d4692e573@gmail.com>
On 18:17-20231003, Ayush Singh wrote:
> > > +
> > > + reset-gpios:
> > > + maxItems: 1
> > > +
> > > + power-gpios:
> > > + maxItems: 3
> > > + description:
> > > + The device has three power rails that are exposed on external pins VDDS,
> > > + VDDR and DCOUPL.
> > Shouldn't these be regulators? The power rails are input to the MCU,
> > correct?
> > The properties should be something like:
> > vdds-supply
> > vddr-supply
> > dcoupl-supply ? (not sure what dcoupl is, but description should provide
> > that info).
> >
> > the gpio controls for those can be modelled by regulator-gpio ?
>
> I picked up power lines from "CC13xx/CC26xx Hardware Configuration and PCB
> Design Considerations Application Report" present under "8.14 Network
> Processor" of CC1352P7 data sheet.
>
> But now looking closer, it doesn't seem like DCOUPL can be supplied
> externally for CC1352P7 and thus should probably be removed.
>
> Also, it seems like for CC1352P7, VDDR must always be supplied internally
> (The data sheet states: "Internal supply, must be powered from the internal
> DC/DC converter or the internal LDO"). Thus, it should be safe to remove
> VDDR as well.
From Figure 3-1. CC1312R 7x7 RF Part Schematic Overview (app report you
point out below)
Typical usage is vdds-supply supplying:
VDDS (pin 44)
VDDS2 (pin 13)
VDDS3 (pin 22)
VDDS_DCDC (pin 34)
And DCDC_SW (pin 33) supplies vddr supplying:
VDDR(pin 45)
VDDR_RF (Pin 48)
>
>
> That means only VDDS needs to be present for power line.
I agree that that would be the typical supply model. So, just
vdds-supply
>
>
> CC13xx/CC26xx Hardware Configuration and PCB Design Considerations
> Application Report: https://www.ti.com/lit/pdf/swra640
>
> CC1352P7 Data sheet: https://www.ti.com/lit/gpn/CC1352P7
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2023-10-03 13:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 18:24 [PATCH v6 0/3] greybus: Add BeaglePlay Greybus Driver Ayush Singh
2023-10-02 18:24 ` [PATCH v6 1/3] dt-bindings: Add beaglecc1352 Ayush Singh
2023-10-02 18:24 ` Ayush Singh
2023-10-03 8:21 ` Krzysztof Kozlowski
2023-10-03 8:21 ` Krzysztof Kozlowski
2023-10-03 12:09 ` Ayush Singh
2023-10-03 12:09 ` Ayush Singh
2023-10-03 13:07 ` Nishanth Menon
2023-10-03 13:07 ` Nishanth Menon
2023-10-03 11:30 ` Nishanth Menon
2023-10-03 11:30 ` Nishanth Menon
2023-10-03 12:47 ` Ayush Singh
2023-10-03 12:47 ` Ayush Singh
2023-10-03 13:05 ` Nishanth Menon [this message]
2023-10-03 13:05 ` Nishanth Menon
2023-10-02 18:24 ` [PATCH v6 2/3] greybus: Add BeaglePlay Linux Driver Ayush Singh
2023-10-03 7:40 ` kernel test robot
2023-10-03 8:25 ` Krzysztof Kozlowski
2023-10-02 18:24 ` [PATCH v6 3/3] dts: ti: k3-am625-beagleplay: Add beaglecc1352 Ayush Singh
2023-10-02 18:24 ` Ayush Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003130556.ateaoj7der45dml6@huddle \
--to=nm@ti.com \
--cc=ayushdevel1325@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jkridner@beagleboard.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vaishnav@beagleboard.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.