From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Harry Wentland <harry.wentland@amd.com>
Cc: "Tianci Yin" <tianci.yin@amd.com>, "Leo Li" <sunpeng.li@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
amd-gfx@lists.freedesktop.org,
"Peter Zijlstra" <peterz@infradead.org>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
dri-devel@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"David Airlie" <airlied@gmail.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/5] drm/amd/display: Remove migrate_en/dis from dc_fpu_begin().
Date: Wed, 4 Oct 2023 10:53:25 +0200 [thread overview]
Message-ID: <20231004085325.PandDs8m@linutronix.de> (raw)
In-Reply-To: <ad5179f7-d2f6-4306-b70e-f0ae5cefcff6@amd.com>
On 2023-10-03 15:53:41 [-0400], Harry Wentland wrote:
> On 2023-09-21 10:15, Sebastian Andrzej Siewior wrote:
> > This is a revert of the commit mentioned below while it is not wrong, as
> > in the kernel will explode, having migrate_disable() here it is
> > complete waste of resources.
> >
> > Additionally commit message is plain wrong the review tag does not make
>
> Not sure I follow what's unhelpful about the review tag with
> 0c316556d1249 ("drm/amd/display: Disable migration to ensure consistency of per-CPU variable")
I explained it below with two points what the reviewer should have
noticed why reading the commit message even if he does not know what
migrate_disable() itself does.
> I do wish the original patch showed the splat it's attempting
> to fix. It apparently made a difference for something, whether
> inadvertently or not. I wish I knew what that "something" was.
As far as I can tell the patch does make a difference.
> Harry
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Harry Wentland <harry.wentland@amd.com>
Cc: "Tianci Yin" <tianci.yin@amd.com>, "Leo Li" <sunpeng.li@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
amd-gfx@lists.freedesktop.org,
"Peter Zijlstra" <peterz@infradead.org>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/5] drm/amd/display: Remove migrate_en/dis from dc_fpu_begin().
Date: Wed, 4 Oct 2023 10:53:25 +0200 [thread overview]
Message-ID: <20231004085325.PandDs8m@linutronix.de> (raw)
In-Reply-To: <ad5179f7-d2f6-4306-b70e-f0ae5cefcff6@amd.com>
On 2023-10-03 15:53:41 [-0400], Harry Wentland wrote:
> On 2023-09-21 10:15, Sebastian Andrzej Siewior wrote:
> > This is a revert of the commit mentioned below while it is not wrong, as
> > in the kernel will explode, having migrate_disable() here it is
> > complete waste of resources.
> >
> > Additionally commit message is plain wrong the review tag does not make
>
> Not sure I follow what's unhelpful about the review tag with
> 0c316556d1249 ("drm/amd/display: Disable migration to ensure consistency of per-CPU variable")
I explained it below with two points what the reviewer should have
noticed why reading the commit message even if he does not know what
migrate_disable() itself does.
> I do wish the original patch showed the splat it's attempting
> to fix. It apparently made a difference for something, whether
> inadvertently or not. I wish I knew what that "something" was.
As far as I can tell the patch does make a difference.
> Harry
Sebastian
next prev parent reply other threads:[~2023-10-04 13:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 14:15 [PATCH 0/5] drm/amd/display: Remove migrate-disable and move memory allocation Sebastian Andrzej Siewior
2023-09-21 14:15 ` Sebastian Andrzej Siewior
2023-09-21 14:15 ` [PATCH 1/5] drm/amd/display: Remove migrate_en/dis from dc_fpu_begin() Sebastian Andrzej Siewior
2023-09-21 14:15 ` Sebastian Andrzej Siewior
2023-10-03 19:53 ` Harry Wentland
2023-10-03 19:53 ` Harry Wentland
2023-10-04 8:53 ` Sebastian Andrzej Siewior [this message]
2023-10-04 8:53 ` Sebastian Andrzej Siewior
2023-10-04 12:10 ` Hamza Mahfooz
2023-10-05 12:10 ` Sebastian Andrzej Siewior
2023-10-05 12:10 ` Sebastian Andrzej Siewior
2023-09-21 14:15 ` [PATCH 2/5] drm/amd/display: Simplify the per-CPU usage Sebastian Andrzej Siewior
2023-09-21 14:15 ` Sebastian Andrzej Siewior
2023-09-21 14:15 ` [PATCH 3/5] drm/amd/display: Add a warning if the FPU is used outside from task context Sebastian Andrzej Siewior
2023-09-21 14:15 ` Sebastian Andrzej Siewior
2023-09-21 14:15 ` [PATCH 4/5] drm/amd/display: Move the memory allocation out of dcn21_validate_bandwidth_fp() Sebastian Andrzej Siewior
2023-09-21 14:15 ` Sebastian Andrzej Siewior
2023-09-21 14:15 ` [PATCH 5/5] drm/amd/display: Move the memory allocation out of dcn20_validate_bandwidth_fp() Sebastian Andrzej Siewior
2023-09-21 14:15 ` Sebastian Andrzej Siewior
2023-09-22 5:33 ` [PATCH 0/5] drm/amd/display: Remove migrate-disable and move memory allocation Christian König
2023-09-22 5:33 ` Christian König
2023-10-02 10:58 ` Sebastian Andrzej Siewior
2023-10-02 10:58 ` Sebastian Andrzej Siewior
2023-10-03 19:54 ` Harry Wentland
2023-10-03 19:54 ` Harry Wentland
2023-10-04 8:49 ` Sebastian Andrzej Siewior
2023-10-04 8:49 ` Sebastian Andrzej Siewior
2023-10-04 12:44 ` Harry Wentland
2023-10-04 12:44 ` Harry Wentland
2023-10-05 12:11 ` Sebastian Andrzej Siewior
2023-10-05 12:11 ` Sebastian Andrzej Siewior
2023-10-04 21:00 ` Rodrigo Siqueira Jordao
2023-10-04 21:00 ` Rodrigo Siqueira Jordao
2023-10-04 21:13 ` Hamza Mahfooz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004085325.PandDs8m@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=peterz@infradead.org \
--cc=sunpeng.li@amd.com \
--cc=tglx@linutronix.de \
--cc=tianci.yin@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.