From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Chandan Babu R <chandanbabu@kernel.org>, Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <djwong@kernel.org>,
viro@zeniv.linux.org.uk, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, dchinner@fromorbit.com,
Christoph Hellwig <hch@lst.de>
Subject: Re: [BUG REPORT] next-20231102: generic/311 fails on XFS with external log
Date: Fri, 3 Nov 2023 09:14:05 +0100 [thread overview]
Message-ID: <20231103081405.GC16854@lst.de> (raw)
In-Reply-To: <20231102-teich-absender-47a27e86e78f@brauner>
On Thu, Nov 02, 2023 at 03:54:48PM +0100, Christian Brauner wrote:
> So you'll see EBUSY because the superblock was already frozen when the
> main block device was frozen. I was somewhat expecting that we may run
> into such issues.
>
> I think we just need to figure out what we want to do in cases the
> superblock is frozen via multiple devices. It would probably be correct
> to keep it frozen as long as any of the devices is frozen?
As dave pointed out I think we need to bring back / keep the freeze
count.
next prev parent reply other threads:[~2023-11-03 8:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 12:36 [BUG REPORT] next-20231102: generic/311 fails on XFS with external log Chandan Babu R
2023-11-02 14:54 ` Christian Brauner
2023-11-02 20:48 ` Dave Chinner
2023-11-03 8:14 ` Christoph Hellwig [this message]
2023-11-03 8:35 ` Christian Brauner
2023-11-03 13:52 ` [PATCH] fs: handle freezing from multiple devices Christian Brauner
2023-11-03 14:19 ` Christoph Hellwig
2023-11-03 15:10 ` Christian Brauner
2023-11-03 15:43 ` Jan Kara
2023-11-03 16:49 ` Christian Brauner
2023-11-06 7:21 ` Christoph Hellwig
2023-11-04 14:00 ` [PATCH v2 0/2] Handle multi device freezing Christian Brauner
2023-11-06 8:21 ` Chandan Babu R
2023-11-06 12:49 ` Christian Brauner
2023-11-04 14:00 ` [PATCH v2 1/2] fs: remove dead check Christian Brauner
2023-11-06 7:29 ` Christoph Hellwig
2023-11-06 10:39 ` Jan Kara
2023-11-04 14:00 ` [PATCH v2 2/2] fs: handle freezing from multiple devices Christian Brauner
2023-11-06 7:30 ` Christoph Hellwig
2023-11-06 11:30 ` Jan Kara
2023-11-06 12:44 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103081405.GC16854@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chandanbabu@kernel.org \
--cc=dchinner@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.