From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-fsdevel@vger.kernel.org,
Chandan Babu R <chandanbabu@kernel.org>
Subject: Re: [PATCH] fs: handle freezing from multiple devices
Date: Mon, 6 Nov 2023 08:21:37 +0100 [thread overview]
Message-ID: <20231106072137.GA17374@lst.de> (raw)
In-Reply-To: <20231103-herzform-fabelhaft-3a46cbe7de83@brauner>
On Fri, Nov 03, 2023 at 05:49:17PM +0100, Christian Brauner wrote:
> > > > Is there a good reason to not just refcount the freezes in general?
> > >
> > > If we start counting freezes in general we break userspace as
> > > freeze_super() is called from ioctl_fsfreeze() and that expects to
> > > return EBUSY on an already frozen filesystem. xfs scrub might be another
> > > user that might break if we change that.
> >
> > I guess Christoph meant that we'd count all the sb freezes into the
> > refcount (what is now bdev_count) but without HOLDER_BDEV flag we will
>
> Ah, sorry I didn't get that from the message.
That's also not what I meant :) Jan's suggestion makes a little
more sense than mine, which I think would have been a good idea
when we started from scratch, but does indeed feel dangerous now.
next prev parent reply other threads:[~2023-11-06 7:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 12:36 [BUG REPORT] next-20231102: generic/311 fails on XFS with external log Chandan Babu R
2023-11-02 14:54 ` Christian Brauner
2023-11-02 20:48 ` Dave Chinner
2023-11-03 8:14 ` Christoph Hellwig
2023-11-03 8:35 ` Christian Brauner
2023-11-03 13:52 ` [PATCH] fs: handle freezing from multiple devices Christian Brauner
2023-11-03 14:19 ` Christoph Hellwig
2023-11-03 15:10 ` Christian Brauner
2023-11-03 15:43 ` Jan Kara
2023-11-03 16:49 ` Christian Brauner
2023-11-06 7:21 ` Christoph Hellwig [this message]
2023-11-04 14:00 ` [PATCH v2 0/2] Handle multi device freezing Christian Brauner
2023-11-06 8:21 ` Chandan Babu R
2023-11-06 12:49 ` Christian Brauner
2023-11-04 14:00 ` [PATCH v2 1/2] fs: remove dead check Christian Brauner
2023-11-06 7:29 ` Christoph Hellwig
2023-11-06 10:39 ` Jan Kara
2023-11-04 14:00 ` [PATCH v2 2/2] fs: handle freezing from multiple devices Christian Brauner
2023-11-06 7:30 ` Christoph Hellwig
2023-11-06 11:30 ` Jan Kara
2023-11-06 12:44 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106072137.GA17374@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=chandanbabu@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.