From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Dave Chinner <dchinner@redhat.com>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] fs: remove dead check
Date: Mon, 6 Nov 2023 08:29:57 +0100 [thread overview]
Message-ID: <20231106072957.GA17547@lst.de> (raw)
In-Reply-To: <20231104-vfs-multi-device-freeze-v2-1-5b5b69626eac@kernel.org>
On Sat, Nov 04, 2023 at 03:00:12PM +0100, Christian Brauner wrote:
> Above we call super_lock_excl() which waits until the superblock is
> SB_BORN and since SB_BORN is never unset once set this check can never
> fire. Plus, we also hold an active reference at this point already so
> this superblock can't even be shutdown.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-11-06 7:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 12:36 [BUG REPORT] next-20231102: generic/311 fails on XFS with external log Chandan Babu R
2023-11-02 14:54 ` Christian Brauner
2023-11-02 20:48 ` Dave Chinner
2023-11-03 8:14 ` Christoph Hellwig
2023-11-03 8:35 ` Christian Brauner
2023-11-03 13:52 ` [PATCH] fs: handle freezing from multiple devices Christian Brauner
2023-11-03 14:19 ` Christoph Hellwig
2023-11-03 15:10 ` Christian Brauner
2023-11-03 15:43 ` Jan Kara
2023-11-03 16:49 ` Christian Brauner
2023-11-06 7:21 ` Christoph Hellwig
2023-11-04 14:00 ` [PATCH v2 0/2] Handle multi device freezing Christian Brauner
2023-11-06 8:21 ` Chandan Babu R
2023-11-06 12:49 ` Christian Brauner
2023-11-04 14:00 ` [PATCH v2 1/2] fs: remove dead check Christian Brauner
2023-11-06 7:29 ` Christoph Hellwig [this message]
2023-11-06 10:39 ` Jan Kara
2023-11-04 14:00 ` [PATCH v2 2/2] fs: handle freezing from multiple devices Christian Brauner
2023-11-06 7:30 ` Christoph Hellwig
2023-11-06 11:30 ` Jan Kara
2023-11-06 12:44 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106072957.GA17547@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.