From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables 1/4] arptables-nft: use ARPT_INV flags consistently
Date: Fri, 3 Nov 2023 17:35:19 +0100 [thread overview]
Message-ID: <20231103163519.GE8035@breakpoint.cc> (raw)
In-Reply-To: <ZUUdXyKzjKzIYae/@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> Indeed, I broke the checks for ARPT_INV_ARPHLN in there. That needs a
> fix either way.
>
> The ARPT_INV_* defines are part of UAPI. They can't be removed without
> breaking (or also converting?) legacy arptables.
Its just a cached header.
> Either way, we're
> breaking third-party arptables DSOs using them. Right now, they are only
> broken with arptables-nft. No idea if such DSOs exist, but if
> compatibility is to be taken seriously, there's no way around reverting
> above commit (and reintroducing do_commandarp() or at least a wrapper
> around the shared do_parse()).
arptables-legacy doesn't support runtime extension loading.
I'll post a patch to convert libarpt_mangle.c.
next prev parent reply other threads:[~2023-11-03 16:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 10:23 [PATCH iptables 0/4] add arptables-translate Florian Westphal
2023-11-03 10:23 ` [PATCH iptables 1/4] arptables-nft: use ARPT_INV flags consistently Florian Westphal
2023-11-03 15:56 ` Phil Sutter
2023-11-03 16:01 ` Florian Westphal
2023-11-03 16:18 ` Phil Sutter
2023-11-03 16:35 ` Florian Westphal [this message]
2023-11-03 16:33 ` [PATCH iptables] arptables-nft: remove ARPT_INV flags usage Florian Westphal
2023-11-03 20:48 ` Phil Sutter
2023-11-03 16:55 ` [PATCH iptables 1/4] arptables-nft: use ARPT_INV flags consistently Phil Sutter
2023-11-03 10:23 ` [PATCH iptables 2/4] nft-arp: add missing mask support Florian Westphal
2023-11-03 20:49 ` Phil Sutter
2023-11-03 21:05 ` Phil Sutter
2023-11-03 10:23 ` [PATCH iptables 3/4] nft-arp: add arptables-translate Florian Westphal
2023-11-03 20:55 ` Phil Sutter
2023-11-03 10:23 ` [PATCH iptables 4/4] arptables-txlate: add test cases Florian Westphal
2023-11-03 11:43 ` [PATCH iptables 0/4] add arptables-translate Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103163519.GE8035@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.