From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables 2/4] nft-arp: add missing mask support
Date: Fri, 3 Nov 2023 22:05:25 +0100 [thread overview]
Message-ID: <ZUVglaiD3ZXuK3XM@orbyte.nwl.cc> (raw)
In-Reply-To: <ZUVcznVHvRjyooEm@orbyte.nwl.cc>
On Fri, Nov 03, 2023 at 09:49:18PM +0100, Phil Sutter wrote:
> On Fri, Nov 03, 2023 at 11:23:24AM +0100, Florian Westphal wrote:
> > arptables-legacy supports masks for --h-type, --opcode
> > and --proto-type, but arptables-nft did not.
> >
> > Add this.
> >
> > Signed-off-by: Florian Westphal <fw@strlen.de>
>
> This does not apply without patch 1. Could you please rebase?
A test would be good, too. Something like:
| --h-length=6/0xffff --opcode=1/255 --h-type=1/0x00ff --proto-type=0x800/0xff00;--h-length=6/65535 --opcode=1/255 --h-type=1/255 --proto-type=0x800/0xff00=;OK
appended to extensions/libarpt_standard.t?
I notice that number bases expected on input and used on output don't
match, this could be a problem in 'arptables-save | arptables-restore'.
Cheers, Phil
next prev parent reply other threads:[~2023-11-03 21:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 10:23 [PATCH iptables 0/4] add arptables-translate Florian Westphal
2023-11-03 10:23 ` [PATCH iptables 1/4] arptables-nft: use ARPT_INV flags consistently Florian Westphal
2023-11-03 15:56 ` Phil Sutter
2023-11-03 16:01 ` Florian Westphal
2023-11-03 16:18 ` Phil Sutter
2023-11-03 16:35 ` Florian Westphal
2023-11-03 16:33 ` [PATCH iptables] arptables-nft: remove ARPT_INV flags usage Florian Westphal
2023-11-03 20:48 ` Phil Sutter
2023-11-03 16:55 ` [PATCH iptables 1/4] arptables-nft: use ARPT_INV flags consistently Phil Sutter
2023-11-03 10:23 ` [PATCH iptables 2/4] nft-arp: add missing mask support Florian Westphal
2023-11-03 20:49 ` Phil Sutter
2023-11-03 21:05 ` Phil Sutter [this message]
2023-11-03 10:23 ` [PATCH iptables 3/4] nft-arp: add arptables-translate Florian Westphal
2023-11-03 20:55 ` Phil Sutter
2023-11-03 10:23 ` [PATCH iptables 4/4] arptables-txlate: add test cases Florian Westphal
2023-11-03 11:43 ` [PATCH iptables 0/4] add arptables-translate Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUVglaiD3ZXuK3XM@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.