From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH iptables] arptables-nft: remove ARPT_INV flags usage
Date: Fri, 3 Nov 2023 21:48:16 +0100 [thread overview]
Message-ID: <ZUVckMM4c0Nb/dk1@orbyte.nwl.cc> (raw)
In-Reply-To: <20231103163548.27178-1-fw@strlen.de>
On Fri, Nov 03, 2023 at 05:33:22PM +0100, Florian Westphal wrote:
> ARPT_ and IPT_INV flags are not interchangeable, e.g.:
> define IPT_INV_SRCDEVADDR 0x0080
> define ARPT_INV_SRCDEVADDR 0x0010
>
> as these flags can be tested by libarp_foo.so such checks can yield
> incorrect results.
>
> Because arptables-nft uses existing code, e.g. xt_mark, it makes
> sense to unify this completely by converting the last users of
> ARPT_INV_ constants.
>
> Note that arptables-legacy does not do run-time module loading via
> dlopen(). Functionaliy implemented by "extensions" in the
> arptables-legacy git tree are built-in, so this doesn't break
> arptables-legacy binaries.
>
> Fixes: 44457c080590 ("xtables-arp: Don't use ARPT_INV_*")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Patch applied, thanks!
next prev parent reply other threads:[~2023-11-03 20:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 10:23 [PATCH iptables 0/4] add arptables-translate Florian Westphal
2023-11-03 10:23 ` [PATCH iptables 1/4] arptables-nft: use ARPT_INV flags consistently Florian Westphal
2023-11-03 15:56 ` Phil Sutter
2023-11-03 16:01 ` Florian Westphal
2023-11-03 16:18 ` Phil Sutter
2023-11-03 16:35 ` Florian Westphal
2023-11-03 16:33 ` [PATCH iptables] arptables-nft: remove ARPT_INV flags usage Florian Westphal
2023-11-03 20:48 ` Phil Sutter [this message]
2023-11-03 16:55 ` [PATCH iptables 1/4] arptables-nft: use ARPT_INV flags consistently Phil Sutter
2023-11-03 10:23 ` [PATCH iptables 2/4] nft-arp: add missing mask support Florian Westphal
2023-11-03 20:49 ` Phil Sutter
2023-11-03 21:05 ` Phil Sutter
2023-11-03 10:23 ` [PATCH iptables 3/4] nft-arp: add arptables-translate Florian Westphal
2023-11-03 20:55 ` Phil Sutter
2023-11-03 10:23 ` [PATCH iptables 4/4] arptables-txlate: add test cases Florian Westphal
2023-11-03 11:43 ` [PATCH iptables 0/4] add arptables-translate Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUVckMM4c0Nb/dk1@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.