All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] Brotli: fix build failed if the path includes "-static"
@ 2023-11-03  5:29 Jamin Lin
  0 siblings, 0 replies; 5+ messages in thread
From: Jamin Lin @ 2023-11-03  5:29 UTC (permalink / raw)
  To: openembedded-devel

It would like to remove "-static" in the name of statice library
at the do_install task. For example: replace libbrotlicommon-static.a
with ibbrotlicommon-static.a However, if the patch of
this statice library includes "-static", it would build failed.
(ex: set my build directory "build-static")
Change to remove "-static" in the base name of static library
to fix this build failed.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 meta-oe/recipes-extended/brotli/brotli_1.0.9.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
index 4e2813dde..6492b1943 100644
--- a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
+++ b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
@@ -16,7 +16,8 @@ inherit cmake lib_package
 
 do_install:append () {
 	for lib in $(ls ${D}${libdir}/*-static.a); do
-		mv -v "${lib}" "$(echo ${lib} | sed s/-static//)"
+		basename=$(basename ${lib})
+		mv -v "${lib}" "${D}${libdir}$(echo ${basename} | sed s/-static//)"
 	done
 }
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v1 1/1] Brotli: fix build failed if the path includes "-static"
@ 2023-11-03 10:02 Jamin Lin
  0 siblings, 0 replies; 5+ messages in thread
From: Jamin Lin @ 2023-11-03 10:02 UTC (permalink / raw)
  To: openembedded-devel

It would like to remove "-static" in the name of statice library
at the do_install task. For example: replace libbrotlicommon-static.a
with ibbrotlicommon-static.a However, if the patch of
this statice library includes "-static", it would build failed.
(ex: set my build directory "build-static")
Change to remove "-static" in the base name of static library
to fix this build failed.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 meta-oe/recipes-extended/brotli/brotli_1.0.9.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
index 4e2813dde..6492b1943 100644
--- a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
+++ b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
@@ -16,7 +16,8 @@ inherit cmake lib_package
 
 do_install:append () {
 	for lib in $(ls ${D}${libdir}/*-static.a); do
-		mv -v "${lib}" "$(echo ${lib} | sed s/-static//)"
+		basename=$(basename ${lib})
+		mv -v "${lib}" "${D}${libdir}$(echo ${basename} | sed s/-static//)"
 	done
 }
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 1/1] Brotli: fix build failed if the path includes "-static"
  2023-11-03 16:29 [oe] " Khem Raj
@ 2023-11-06  8:18 ` Jamin Lin
  0 siblings, 0 replies; 5+ messages in thread
From: Jamin Lin @ 2023-11-06  8:18 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 26 bytes --]

Thanks review.
Will fix

[-- Attachment #2: Type: text/html, Size: 30 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v1 0/1] fix build failed if the path includes "-static"
@ 2023-11-06  9:02 Jamin Lin
  2023-11-06  9:02 ` [PATCH v1 1/1] Brotli: " Jamin Lin
  0 siblings, 1 reply; 5+ messages in thread
From: Jamin Lin @ 2023-11-06  9:02 UTC (permalink / raw)
  To: openembedded-devel

v0: fix build failed if the path includes "-static"
v1: add a sepator in path

Jamin Lin (1):
  Brotli: fix build failed if the path includes "-static"

 meta-oe/recipes-extended/brotli/brotli_1.0.9.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.34.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v1 1/1] Brotli: fix build failed if the path includes "-static"
  2023-11-06  9:02 [PATCH v1 0/1] fix build failed if the path includes "-static" Jamin Lin
@ 2023-11-06  9:02 ` Jamin Lin
  0 siblings, 0 replies; 5+ messages in thread
From: Jamin Lin @ 2023-11-06  9:02 UTC (permalink / raw)
  To: openembedded-devel

It would like to remove "-static" in the name of statice library
at the do_install task. For example: replace libbrotlicommon-static.a
with ibbrotlicommon-static.a However, if the patch of
this statice library includes "-static", it would build failed.
(ex: set my build directory "build-static")
Change to remove "-static" in the base name of static library
to fix this build failed.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 meta-oe/recipes-extended/brotli/brotli_1.0.9.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
index 4e2813dde..708c1c194 100644
--- a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
+++ b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
@@ -16,7 +16,8 @@ inherit cmake lib_package
 
 do_install:append () {
 	for lib in $(ls ${D}${libdir}/*-static.a); do
-		mv -v "${lib}" "$(echo ${lib} | sed s/-static//)"
+		basename=$(basename ${lib})
+		mv -v "${lib}" "${D}${libdir}/$(echo ${basename} | sed s/-static//)"
 	done
 }
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-11-06  9:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-06  9:02 [PATCH v1 0/1] fix build failed if the path includes "-static" Jamin Lin
2023-11-06  9:02 ` [PATCH v1 1/1] Brotli: " Jamin Lin
  -- strict thread matches above, loose matches on Subject: below --
2023-11-03 16:29 [oe] " Khem Raj
2023-11-06  8:18 ` Jamin Lin
2023-11-03 10:02 Jamin Lin
2023-11-03  5:29 Jamin Lin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.