[PATCH v1 0/1] fix build failed if the path includes "-static"

[PATCH v1 0/1] fix build failed if the path includes "-static"

[Jamin Lin]

v0: fix build failed if the path includes "-static"
v1: add a sepator in path

Jamin Lin (1):
  Brotli: fix build failed if the path includes "-static"

 meta-oe/recipes-extended/brotli/brotli_1.0.9.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.34.1

[PATCH v1 1/1] Brotli: fix build failed if the path includes "-static"

[Jamin Lin]

It would like to remove "-static" in the name of statice library
at the do_install task. For example: replace libbrotlicommon-static.a
with ibbrotlicommon-static.a However, if the patch of
this statice library includes "-static", it would build failed.
(ex: set my build directory "build-static")
Change to remove "-static" in the base name of static library
to fix this build failed.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 meta-oe/recipes-extended/brotli/brotli_1.0.9.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
index 4e2813dde..708c1c194 100644
--- a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
+++ b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
@@ -16,7 +16,8 @@ inherit cmake lib_package
 
 do_install:append () {
 	for lib in $(ls ${D}${libdir}/*-static.a); do
-		mv -v "${lib}" "$(echo ${lib} | sed s/-static//)"
+		basename=$(basename ${lib})
+		mv -v "${lib}" "${D}${libdir}/$(echo ${basename} | sed s/-static//)"
 	done
 }
 
-- 
2.34.1

Re: [oe] [PATCH v1 1/1] Brotli: fix build failed if the path includes "-static"

[Khem Raj]

On Fri, Nov 3, 2023 at 4:37 AM Jamin Lin via lists.openembedded.org
<jamin_lin=aspeedtech.com@lists.openembedded.org> wrote:
>
> It would like to remove "-static" in the name of statice library
> at the do_install task. For example: replace libbrotlicommon-static.a
> with ibbrotlicommon-static.a However, if the patch of
> this statice library includes "-static", it would build failed.
> (ex: set my build directory "build-static")
> Change to remove "-static" in the base name of static library
> to fix this build failed.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>  meta-oe/recipes-extended/brotli/brotli_1.0.9.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
> index 4e2813dde..6492b1943 100644
> --- a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
> +++ b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
> @@ -16,7 +16,8 @@ inherit cmake lib_package
>
>  do_install:append () {
>         for lib in $(ls ${D}${libdir}/*-static.a); do
> -               mv -v "${lib}" "$(echo ${lib} | sed s/-static//)"
> +               basename=$(basename ${lib})
> +               mv -v "${lib}" "${D}${libdir}$(echo ${basename} | sed s/-static//)"

This results in path without a sepator.

ERROR: brotli-1.0.9-r0 do_package: QA Issue: brotli: Files/directories
were installed but not shipped in any package:
  /usr/liblibbrotlienc.a
  /usr/liblibbrotlicommon.a
  /usr/liblibbrotlidec.a

>         done
>  }
>
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#105854): https://lists.openembedded.org/g/openembedded-devel/message/105854
> Mute This Topic: https://lists.openembedded.org/mt/102360862/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [PATCH v1 1/1] Brotli: fix build failed if the path includes "-static"

[Jamin Lin]

[-- Attachment #1: Type: text/plain, Size: 26 bytes --]

Thanks review.
Will fix

[-- Attachment #2: Type: text/html, Size: 30 bytes --]

[PATCH v1 1/1] Brotli: fix build failed if the path includes "-static"

[Jamin Lin]

It would like to remove "-static" in the name of statice library
at the do_install task. For example: replace libbrotlicommon-static.a
with ibbrotlicommon-static.a However, if the patch of
this statice library includes "-static", it would build failed.
(ex: set my build directory "build-static")
Change to remove "-static" in the base name of static library
to fix this build failed.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 meta-oe/recipes-extended/brotli/brotli_1.0.9.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
index 4e2813dde..6492b1943 100644
--- a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
+++ b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
@@ -16,7 +16,8 @@ inherit cmake lib_package
 
 do_install:append () {
 	for lib in $(ls ${D}${libdir}/*-static.a); do
-		mv -v "${lib}" "$(echo ${lib} | sed s/-static//)"
+		basename=$(basename ${lib})
+		mv -v "${lib}" "${D}${libdir}$(echo ${basename} | sed s/-static//)"
 	done
 }
 
-- 
2.34.1

[PATCH v1 1/1] Brotli: fix build failed if the path includes "-static"

[Jamin Lin]

It would like to remove "-static" in the name of statice library
at the do_install task. For example: replace libbrotlicommon-static.a
with ibbrotlicommon-static.a However, if the patch of
this statice library includes "-static", it would build failed.
(ex: set my build directory "build-static")
Change to remove "-static" in the base name of static library
to fix this build failed.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 meta-oe/recipes-extended/brotli/brotli_1.0.9.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
index 4e2813dde..6492b1943 100644
--- a/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
+++ b/meta-oe/recipes-extended/brotli/brotli_1.0.9.bb
@@ -16,7 +16,8 @@ inherit cmake lib_package
 
 do_install:append () {
 	for lib in $(ls ${D}${libdir}/*-static.a); do
-		mv -v "${lib}" "$(echo ${lib} | sed s/-static//)"
+		basename=$(basename ${lib})
+		mv -v "${lib}" "${D}${libdir}$(echo ${basename} | sed s/-static//)"
 	done
 }
 
-- 
2.34.1