Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

From: jrodrigues <jrodrigues@ubimet.com>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)
Date: Thu, 9 Nov 2023 09:49:30 +0100	[thread overview]
Message-ID: <20231109094930.635cf59a@pcn112> (raw)
In-Reply-To: <CAH+2xPBdpYiNRzPP+0Diqrc+GfdJYbiTDheD6n2fb42w65LNFg@mail.gmail.com>

On Wed, 8 Nov 2023 23:51:11 +0100
Bruno Thomsen <bruno.thomsen@gmail.com> wrote:

> Den fre. 3. nov. 2023 kl. 22.07 skrev Fabio Estevam
> <festevam@gmail.com>:
> >
> > [Adding Bruno and Alexander]
> >
> > On Thu, Nov 2, 2023 at 7:12 PM João Rodrigues
> > <jrodrigues@ubimet.com> wrote:  
> > >
> > > From: João Rodrigues <jrodrigues@ubimet.com>
> > >
> > > TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
> > > The two sensors use different I2C addresses, so we can set both
> > > sensors simultaneously.  
> 
> Hi João,
> 
> Looks correct to me and an elegant way of adding support for rev 01xx
> boards.
> 
> Reviewed-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> 
> After this change the imx7d-flex-concentrator.dts needs to be updated
> as it uses TQMa7d rev 02xx boards with something like this:
> 
> /* TQMa7d 02xx */
> &se97b {
>         status = "okay";
> };
> 
> I can send a follow up patch when this change lands.
> 
> /Bruno
> 

Hi Bruno,

Thank you for the review.
Taking the status out was a request from Krzysztof in the initial version of
the patch, since the default for status is "okay". I have also tested (and
confirmed) this works as expected, with the appropriate temperature sensor
being recognised by the kernel.

Kind regards,
João

> > >
> > > Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> > > ---
> > >  arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 +++++++--
> > >  1 file changed, 7 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi index
> > > fe42b0a4683..3fc3130f9de 100644 ---
> > > a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi +++
> > > b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi @@ -128,11 +128,16 @@
> > > vgen6_reg: vldo4 { };
> > >         };
> > >
> > > -       /* NXP SE97BTP with temperature sensor + eeprom */
> > > +       /* LM75A temperature sensor, TQMa7x 01xx */
> > > +       lm75a: temperature-sensor@48 {
> > > +               compatible = "national,lm75a";
> > > +               reg = <0x48>;
> > > +       };
> > > +
> > > +       /* NXP SE97BTP with temperature sensor + eeprom, TQMa7x
> > > 02xx */ se97b: temperature-sensor-eeprom@1e {
> > >                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
> > >                 reg = <0x1e>;
> > > -               status = "okay";
> > >         };
> > >
> > >         /* ST M24C64 */
> > > --
> > > 2.25.1
> > >  

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel