All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: kunwu.chan@hotmail.com, netdev@vger.kernel.org,
	jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
	edumazet@google.com, anthony.l.nguyen@intel.com,
	jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
	kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net,
	shannon.nelson@amd.com
Subject: Re: [Intel-wired-lan] [PATCH] i40e: Use correct buffer size
Date: Mon, 13 Nov 2023 09:31:12 +0000	[thread overview]
Message-ID: <20231113093112.GL705326@kernel.org> (raw)
In-Reply-To: <20231112110146.3879030-1-chentao@kylinos.cn>

On Sun, Nov 12, 2023 at 07:01:46PM +0800, Kunwu Chan wrote:
> The size of "i40e_dbg_command_buf" is 256, the size of "name" is
> at most 256, plus a null character and the format size,
> the total size should be 516.

Hi Kunwu Chan,

Thanks for your patch.

I'm slightly confused as to why name is at most 256 bytes.
I see that name is IFNAMSIZ = 16 bytes.

In any case, perhaps we could make buf_size dependent on it's
constituent variables, to make things a bit clearer and
a bit more robust.

Something like this (completely untested!):

	int buf_size = IFNAMSIZ + sizeof(i40e_dbg_command_buf) + 4;

Also, I'm not clear if this addresses a problem that can manifest in
practice. Which affects if it it should be treated as a fix for iwl-net
with a fixes tag, or as a feature for iwl-next without a fixes tag.

In either case, if you repost, please designate the target tree in the
Subject line. Something like this:

	Subject: [PATCH iwl-next] ...

Lastly, when reposting patches, please allow 24h to elapse since
the previous posting.

Link: https://docs.kernel.org/process/maintainer-netdev.html

...
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, jeffrey.t.kirsher@intel.com,
	shannon.nelson@amd.com, kunwu.chan@hotmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH] i40e: Use correct buffer size
Date: Mon, 13 Nov 2023 09:31:12 +0000	[thread overview]
Message-ID: <20231113093112.GL705326@kernel.org> (raw)
In-Reply-To: <20231112110146.3879030-1-chentao@kylinos.cn>

On Sun, Nov 12, 2023 at 07:01:46PM +0800, Kunwu Chan wrote:
> The size of "i40e_dbg_command_buf" is 256, the size of "name" is
> at most 256, plus a null character and the format size,
> the total size should be 516.

Hi Kunwu Chan,

Thanks for your patch.

I'm slightly confused as to why name is at most 256 bytes.
I see that name is IFNAMSIZ = 16 bytes.

In any case, perhaps we could make buf_size dependent on it's
constituent variables, to make things a bit clearer and
a bit more robust.

Something like this (completely untested!):

	int buf_size = IFNAMSIZ + sizeof(i40e_dbg_command_buf) + 4;

Also, I'm not clear if this addresses a problem that can manifest in
practice. Which affects if it it should be treated as a fix for iwl-net
with a fixes tag, or as a feature for iwl-next without a fixes tag.

In either case, if you repost, please designate the target tree in the
Subject line. Something like this:

	Subject: [PATCH iwl-next] ...

Lastly, when reposting patches, please allow 24h to elapse since
the previous posting.

Link: https://docs.kernel.org/process/maintainer-netdev.html

...

  reply	other threads:[~2023-11-13  9:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-12 11:01 [Intel-wired-lan] [PATCH] i40e: Use correct buffer size Kunwu Chan
2023-11-12 11:01 ` Kunwu Chan
2023-11-13  9:31 ` Simon Horman [this message]
2023-11-13  9:31   ` Simon Horman
2023-11-15  3:10   ` [Intel-wired-lan] " Kunwu Chan
2023-11-15  3:10     ` Kunwu Chan
2023-11-15  3:14   ` [Intel-wired-lan] [PATCH iwl-next] " Kunwu Chan
2023-11-15  3:14     ` Kunwu Chan
2023-11-15  9:21     ` [Intel-wired-lan] " Simon Horman
2023-11-15  9:21       ` Simon Horman
2023-11-15 15:39     ` [Intel-wired-lan] " Alexander Lobakin
2023-11-15 15:39       ` Alexander Lobakin
2023-11-19 15:12       ` [Intel-wired-lan] " Kunwu Chan
2023-11-19 15:12         ` Kunwu Chan
2023-11-20 11:41         ` [Intel-wired-lan] " Alexander Lobakin
2023-11-20 11:41           ` Alexander Lobakin
2023-11-21  2:12           ` [Intel-wired-lan] " Kunwu Chan
2023-11-21  2:12             ` Kunwu Chan
2023-11-21 11:15             ` [Intel-wired-lan] " Alexander Lobakin
2023-11-21 11:15               ` Alexander Lobakin
2023-11-22  6:57               ` [Intel-wired-lan] " Kunwu Chan
2023-11-22  6:57                 ` Kunwu Chan
  -- strict thread matches above, loose matches on Subject: below --
2023-11-12 10:57 [Intel-wired-lan] [PATCH] " Kunwu Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231113093112.GL705326@kernel.org \
    --to=horms@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=chentao@kylinos.cn \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=kunwu.chan@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shannon.nelson@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.