From: Simon Horman <horms@kernel.org>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: kunwu.chan@hotmail.com, netdev@vger.kernel.org,
jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
edumazet@google.com, intel-wired-lan@lists.osuosl.org,
jeffrey.t.kirsher@intel.com, kuba@kernel.org,
anthony.l.nguyen@intel.com, pabeni@redhat.com,
davem@davemloft.net, shannon.nelson@amd.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Use correct buffer size
Date: Wed, 15 Nov 2023 09:21:23 +0000 [thread overview]
Message-ID: <20231115092123.GI74656@kernel.org> (raw)
In-Reply-To: <20231115031444.33381-1-chentao@kylinos.cn>
On Wed, Nov 15, 2023 at 11:14:44AM +0800, Kunwu Chan wrote:
> The size of "i40e_dbg_command_buf" is 256, the size of "name"
> depends on "IFNAMSIZ", plus a null character and format size,
> the total size is more than 256, fix it.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> Suggested-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the update.
There is no need to repost because of this, but in future please keep in
mind that revised patches should:
1. have a revision number, e.g. v2
Subject [PATCH v2 iwl-next] ...
2. Have some of revision information below the scissors (---)
v2
- Updated size calculation to use IFNAMSIZ and izeof(i40e_dbg_command_buf)
3. Be a new thread, as opposed to a reply to an existing thread.
Link: https://docs.kernel.org/process/maintainer-netdev.html#changes-requested
The above notwithstanding, this patch looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: anthony.l.nguyen@intel.com, davem@davemloft.net,
edumazet@google.com, intel-wired-lan@lists.osuosl.org,
jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
kuba@kernel.org, kunwu.chan@hotmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, shannon.nelson@amd.com
Subject: Re: [PATCH iwl-next] i40e: Use correct buffer size
Date: Wed, 15 Nov 2023 09:21:23 +0000 [thread overview]
Message-ID: <20231115092123.GI74656@kernel.org> (raw)
In-Reply-To: <20231115031444.33381-1-chentao@kylinos.cn>
On Wed, Nov 15, 2023 at 11:14:44AM +0800, Kunwu Chan wrote:
> The size of "i40e_dbg_command_buf" is 256, the size of "name"
> depends on "IFNAMSIZ", plus a null character and format size,
> the total size is more than 256, fix it.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> Suggested-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the update.
There is no need to repost because of this, but in future please keep in
mind that revised patches should:
1. have a revision number, e.g. v2
Subject [PATCH v2 iwl-next] ...
2. Have some of revision information below the scissors (---)
v2
- Updated size calculation to use IFNAMSIZ and izeof(i40e_dbg_command_buf)
3. Be a new thread, as opposed to a reply to an existing thread.
Link: https://docs.kernel.org/process/maintainer-netdev.html#changes-requested
The above notwithstanding, this patch looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-11-15 9:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 11:01 [Intel-wired-lan] [PATCH] i40e: Use correct buffer size Kunwu Chan
2023-11-12 11:01 ` Kunwu Chan
2023-11-13 9:31 ` [Intel-wired-lan] " Simon Horman
2023-11-13 9:31 ` Simon Horman
2023-11-15 3:10 ` [Intel-wired-lan] " Kunwu Chan
2023-11-15 3:10 ` Kunwu Chan
2023-11-15 3:14 ` [Intel-wired-lan] [PATCH iwl-next] " Kunwu Chan
2023-11-15 3:14 ` Kunwu Chan
2023-11-15 9:21 ` Simon Horman [this message]
2023-11-15 9:21 ` Simon Horman
2023-11-15 15:39 ` [Intel-wired-lan] " Alexander Lobakin
2023-11-15 15:39 ` Alexander Lobakin
2023-11-19 15:12 ` [Intel-wired-lan] " Kunwu Chan
2023-11-19 15:12 ` Kunwu Chan
2023-11-20 11:41 ` [Intel-wired-lan] " Alexander Lobakin
2023-11-20 11:41 ` Alexander Lobakin
2023-11-21 2:12 ` [Intel-wired-lan] " Kunwu Chan
2023-11-21 2:12 ` Kunwu Chan
2023-11-21 11:15 ` [Intel-wired-lan] " Alexander Lobakin
2023-11-21 11:15 ` Alexander Lobakin
2023-11-22 6:57 ` [Intel-wired-lan] " Kunwu Chan
2023-11-22 6:57 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115092123.GI74656@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=chentao@kylinos.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kunwu.chan@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.