From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Harry Wentland <harry.wentland@amd.com>
Cc: "Leo Li" <sunpeng.li@amd.com>,
dri-devel@lists.freedesktop.org, "Pan,
Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-i2c@vger.kernel.org, "Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: [PATCH v2 03/20] drm/amd/display: remove I2C_CLASS_DDC support
Date: Sat, 18 Nov 2023 18:42:03 +0100 [thread overview]
Message-ID: <20231118174221.851-4-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com>
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- adjust tag in commit subject
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 6f99f6754..ae1edc6ab 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service,
if (!i2c)
return NULL;
i2c->base.owner = THIS_MODULE;
- i2c->base.class = I2C_CLASS_DDC;
i2c->base.dev.parent = &adev->pdev->dev;
i2c->base.algo = &amdgpu_dm_i2c_algo;
snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);
WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Harry Wentland <harry.wentland@amd.com>
Cc: linux-i2c@vger.kernel.org,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 03/20] drm/amd/display: remove I2C_CLASS_DDC support
Date: Sat, 18 Nov 2023 18:42:03 +0100 [thread overview]
Message-ID: <20231118174221.851-4-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com>
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- adjust tag in commit subject
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 6f99f6754..ae1edc6ab 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service,
if (!i2c)
return NULL;
i2c->base.owner = THIS_MODULE;
- i2c->base.class = I2C_CLASS_DDC;
i2c->base.dev.parent = &adev->pdev->dev;
i2c->base.algo = &amdgpu_dm_i2c_algo;
snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);
WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Harry Wentland <harry.wentland@amd.com>
Cc: "Leo Li" <sunpeng.li@amd.com>,
dri-devel@lists.freedesktop.org, "Pan,
Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-i2c@vger.kernel.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: [PATCH v2 03/20] drm/amd/display: remove I2C_CLASS_DDC support
Date: Sat, 18 Nov 2023 18:42:03 +0100 [thread overview]
Message-ID: <20231118174221.851-4-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com>
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- adjust tag in commit subject
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 6f99f6754..ae1edc6ab 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service,
if (!i2c)
return NULL;
i2c->base.owner = THIS_MODULE;
- i2c->base.class = I2C_CLASS_DDC;
i2c->base.dev.parent = &adev->pdev->dev;
i2c->base.algo = &amdgpu_dm_i2c_algo;
snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);
next prev parent reply other threads:[~2023-11-20 15:40 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 17:42 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [Intel-gfx] " Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit [this message]
2023-11-18 17:42 ` [PATCH v2 03/20] drm/amd/display: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 21:49 ` Jernej Škrabec
2023-11-18 21:49 ` Jernej Škrabec
2023-11-18 21:49 ` Jernej Škrabec
2023-11-18 17:42 ` [PATCH v2 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-19 4:46 ` kernel test robot
2023-11-19 4:46 ` kernel test robot
2023-11-18 17:42 ` [PATCH v2 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [Intel-gfx] [PATCH v2 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 19/20] drivers/gpu/drm/display: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 20/20] include/linux/i2c.h: " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231118174221.851-4-hkallweit1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.