From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Alex Deucher <alexander.deucher@amd.com>
Cc: dri-devel@lists.freedesktop.org, "Pan,
Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-i2c@vger.kernel.org, "Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: [PATCH v2 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support
Date: Sat, 18 Nov 2023 18:42:07 +0100 [thread overview]
Message-ID: <20231118174221.851-8-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com>
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
index 82608df43..d79cb13e1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
@@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev,
i2c->rec = *rec;
i2c->adapter.owner = THIS_MODULE;
- i2c->adapter.class = I2C_CLASS_DDC;
i2c->adapter.dev.parent = dev->dev;
i2c->dev = dev;
i2c_set_adapdata(&i2c->adapter, i2c);
diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
index 314d066e6..3d174390a 100644
--- a/drivers/gpu/drm/radeon/radeon_i2c.c
+++ b/drivers/gpu/drm/radeon/radeon_i2c.c
@@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
i2c->rec = *rec;
i2c->adapter.owner = THIS_MODULE;
- i2c->adapter.class = I2C_CLASS_DDC;
i2c->adapter.dev.parent = dev->dev;
i2c->dev = dev;
i2c_set_adapdata(&i2c->adapter, i2c);
WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Alex Deucher <alexander.deucher@amd.com>
Cc: linux-i2c@vger.kernel.org,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support
Date: Sat, 18 Nov 2023 18:42:07 +0100 [thread overview]
Message-ID: <20231118174221.851-8-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com>
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
index 82608df43..d79cb13e1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
@@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev,
i2c->rec = *rec;
i2c->adapter.owner = THIS_MODULE;
- i2c->adapter.class = I2C_CLASS_DDC;
i2c->adapter.dev.parent = dev->dev;
i2c->dev = dev;
i2c_set_adapdata(&i2c->adapter, i2c);
diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
index 314d066e6..3d174390a 100644
--- a/drivers/gpu/drm/radeon/radeon_i2c.c
+++ b/drivers/gpu/drm/radeon/radeon_i2c.c
@@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
i2c->rec = *rec;
i2c->adapter.owner = THIS_MODULE;
- i2c->adapter.class = I2C_CLASS_DDC;
i2c->adapter.dev.parent = dev->dev;
i2c->dev = dev;
i2c_set_adapdata(&i2c->adapter, i2c);
WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Alex Deucher <alexander.deucher@amd.com>
Cc: dri-devel@lists.freedesktop.org, "Pan,
Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-i2c@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: [PATCH v2 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support
Date: Sat, 18 Nov 2023 18:42:07 +0100 [thread overview]
Message-ID: <20231118174221.851-8-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com>
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
index 82608df43..d79cb13e1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
@@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev,
i2c->rec = *rec;
i2c->adapter.owner = THIS_MODULE;
- i2c->adapter.class = I2C_CLASS_DDC;
i2c->adapter.dev.parent = dev->dev;
i2c->dev = dev;
i2c_set_adapdata(&i2c->adapter, i2c);
diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
index 314d066e6..3d174390a 100644
--- a/drivers/gpu/drm/radeon/radeon_i2c.c
+++ b/drivers/gpu/drm/radeon/radeon_i2c.c
@@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
i2c->rec = *rec;
i2c->adapter.owner = THIS_MODULE;
- i2c->adapter.class = I2C_CLASS_DDC;
i2c->adapter.dev.parent = dev->dev;
i2c->dev = dev;
i2c_set_adapdata(&i2c->adapter, i2c);
next prev parent reply other threads:[~2023-11-20 15:40 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 17:42 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [Intel-gfx] " Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 03/20] drm/amd/display: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 21:49 ` Jernej Škrabec
2023-11-18 21:49 ` Jernej Škrabec
2023-11-18 21:49 ` Jernej Škrabec
2023-11-18 17:42 ` [PATCH v2 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-19 4:46 ` kernel test robot
2023-11-19 4:46 ` kernel test robot
2023-11-18 17:42 ` [PATCH v2 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit [this message]
2023-11-18 17:42 ` [PATCH v2 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [Intel-gfx] [PATCH v2 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 19/20] drivers/gpu/drm/display: " Heiner Kallweit
2023-11-18 17:42 ` Heiner Kallweit
2023-11-18 17:42 ` [PATCH v2 20/20] include/linux/i2c.h: " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231118174221.851-8-hkallweit1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.