From: Al Viro <viro@zeniv.linux.org.uk>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: brauner@kernel.org, tytso@mit.edu, ebiggers@kernel.org,
jaegeuk@kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [PATCH v6 3/9] fs: Expose name under lookup to d_revalidate hooks
Date: Wed, 22 Nov 2023 20:59:26 +0000 [thread overview]
Message-ID: <20231122205926.GH38156@ZenIV> (raw)
In-Reply-To: <20230816050803.15660-4-krisman@suse.de>
On Wed, Aug 16, 2023 at 01:07:57AM -0400, Gabriel Krisman Bertazi wrote:
> From: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> Negative dentries support on case-insensitive ext4/f2fs will require
> access to the name under lookup to ensure it matches the dentry. This
> adds the information on d_revalidate and updates its implementation.
There's actually one hell of a stronger reason for that particular change;
uses of ->d_name in ->d_revalidate() instances are often racy.
So IMO this is the right way to go, regardless of c-i stuff, except that
it ought to be followed by making individual ->d_revalidate() instances use
the damn argument, now that they have it in stable form.
Said followups don't need to be in the same series, obviously.
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: brauner@kernel.org, tytso@mit.edu,
linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org,
linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [PATCH v6 3/9] fs: Expose name under lookup to d_revalidate hooks
Date: Wed, 22 Nov 2023 20:59:26 +0000 [thread overview]
Message-ID: <20231122205926.GH38156@ZenIV> (raw)
In-Reply-To: <20230816050803.15660-4-krisman@suse.de>
On Wed, Aug 16, 2023 at 01:07:57AM -0400, Gabriel Krisman Bertazi wrote:
> From: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> Negative dentries support on case-insensitive ext4/f2fs will require
> access to the name under lookup to ensure it matches the dentry. This
> adds the information on d_revalidate and updates its implementation.
There's actually one hell of a stronger reason for that particular change;
uses of ->d_name in ->d_revalidate() instances are often racy.
So IMO this is the right way to go, regardless of c-i stuff, except that
it ought to be followed by making individual ->d_revalidate() instances use
the damn argument, now that they have it in stable form.
Said followups don't need to be in the same series, obviously.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-11-22 20:59 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 5:07 [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs Gabriel Krisman Bertazi
2023-08-16 5:07 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-16 5:07 ` [PATCH v6 1/9] ecryptfs: Reject casefold directory inodes Gabriel Krisman Bertazi
2023-08-16 5:07 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-16 5:07 ` [PATCH v6 2/9] 9p: Split ->weak_revalidate from ->revalidate Gabriel Krisman Bertazi
2023-08-16 5:07 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-16 5:07 ` [PATCH v6 3/9] fs: Expose name under lookup to d_revalidate hooks Gabriel Krisman Bertazi
2023-08-16 5:07 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-11-22 20:59 ` Al Viro [this message]
2023-11-22 20:59 ` Al Viro
2023-08-16 5:07 ` [PATCH v6 4/9] fs: Add DCACHE_CASEFOLDED_NAME flag Gabriel Krisman Bertazi
2023-08-16 5:07 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-11-22 20:32 ` Al Viro
2023-11-22 20:32 ` [f2fs-dev] " Al Viro
2023-08-16 5:07 ` [PATCH v6 5/9] libfs: Validate negative dentries in case-insensitive directories Gabriel Krisman Bertazi
2023-08-16 5:07 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-11-22 20:20 ` Al Viro
2023-11-22 20:20 ` [f2fs-dev] " Al Viro
2023-08-16 5:08 ` [PATCH v6 6/9] libfs: Chain encryption checks after case-insensitive revalidation Gabriel Krisman Bertazi
2023-08-16 5:08 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-16 5:08 ` [PATCH v6 7/9] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops Gabriel Krisman Bertazi
2023-08-16 5:08 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-16 5:08 ` [PATCH v6 8/9] ext4: Enable negative dentries on case-insensitive lookup Gabriel Krisman Bertazi
2023-08-16 5:08 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-16 5:08 ` [PATCH v6 9/9] f2fs: " Gabriel Krisman Bertazi
2023-08-16 5:08 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-17 17:06 ` [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs Eric Biggers
2023-08-17 17:06 ` [f2fs-dev] " Eric Biggers
2023-08-21 15:52 ` Christian Brauner
2023-08-21 15:52 ` [f2fs-dev] " Christian Brauner
2023-08-21 18:53 ` Gabriel Krisman Bertazi
2023-08-21 18:53 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-22 9:03 ` Christian Brauner
2023-08-22 9:03 ` [f2fs-dev] " Christian Brauner
2023-10-24 22:20 ` Gabriel Krisman Bertazi
2023-10-24 22:20 ` Gabriel Krisman Bertazi
2023-10-25 13:32 ` Christian Brauner
2023-10-25 13:32 ` [f2fs-dev] " Christian Brauner
2023-10-25 15:19 ` Gabriel Krisman Bertazi
2023-10-25 15:19 ` Gabriel Krisman Bertazi
2023-11-19 23:11 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-11-19 23:11 ` Gabriel Krisman Bertazi
[not found] ` <655a9634.630a0220.d50d7.5063SMTPIN_ADDED_BROKEN@mx.google.com>
2023-11-20 15:06 ` Christian Brauner
2023-11-20 15:06 ` Christian Brauner
2023-11-20 16:59 ` Gabriel Krisman Bertazi
2023-11-20 16:59 ` Gabriel Krisman Bertazi
2023-11-20 18:07 ` Linus Torvalds
2023-11-20 18:07 ` Linus Torvalds
2023-11-21 2:02 ` Theodore Ts'o
2023-11-21 2:02 ` Theodore Ts'o
2023-11-21 2:29 ` Linus Torvalds
2023-11-21 2:29 ` Linus Torvalds
2023-11-21 3:03 ` Linus Torvalds
2023-11-21 3:03 ` Linus Torvalds
2023-11-21 5:12 ` Theodore Ts'o
2023-11-21 5:12 ` Theodore Ts'o
2023-11-22 21:04 ` Al Viro
2023-11-22 21:04 ` Al Viro
2023-11-21 2:27 ` Al Viro
2023-11-21 2:27 ` Al Viro
2023-11-22 21:19 ` Al Viro
2023-11-22 21:19 ` Al Viro
2023-11-23 0:18 ` Linus Torvalds
2023-11-23 0:18 ` Linus Torvalds
2023-11-23 5:09 ` Al Viro
2023-11-23 5:09 ` Al Viro
2023-11-23 15:57 ` Gabriel Krisman Bertazi
2023-11-23 15:57 ` Gabriel Krisman Bertazi
2023-11-23 17:12 ` Al Viro
2023-11-23 17:12 ` Al Viro
2023-11-23 17:37 ` Gabriel Krisman Bertazi
2023-11-23 17:37 ` Gabriel Krisman Bertazi
2023-11-23 18:24 ` Al Viro
2023-11-23 18:24 ` Al Viro
2023-11-23 19:06 ` Gabriel Krisman Bertazi
2023-11-23 19:06 ` Gabriel Krisman Bertazi
2023-11-23 19:53 ` Al Viro
2023-11-23 19:53 ` Al Viro
2023-11-23 20:15 ` Al Viro
2023-11-23 20:15 ` Al Viro
2023-11-24 15:20 ` Gabriel Krisman Bertazi
2023-11-24 15:20 ` Gabriel Krisman Bertazi
2023-11-28 0:02 ` Al Viro
2023-11-28 0:02 ` Al Viro
2023-11-23 21:52 ` Al Viro
2023-11-23 21:52 ` Al Viro
2023-11-24 15:22 ` Gabriel Krisman Bertazi
2023-11-24 15:22 ` Gabriel Krisman Bertazi
2023-11-25 22:01 ` Al Viro
2023-11-25 22:01 ` Al Viro
2023-11-26 4:52 ` Al Viro
2023-11-26 4:52 ` Al Viro
2023-11-26 18:41 ` fun with d_invalidate() vs. d_splice_alias() was " Al Viro
2023-11-26 18:41 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Al Viro
2023-11-27 6:38 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Al Viro
2023-11-27 6:38 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Al Viro
2023-11-27 15:47 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Eric W. Biederman
2023-11-27 15:47 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Eric W. Biederman
2023-11-27 16:01 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Eric W. Biederman
2023-11-27 16:01 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Eric W. Biederman
2023-11-27 17:25 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Al Viro
2023-11-27 17:25 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Al Viro
2023-11-27 18:26 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Al Viro
2023-11-27 18:26 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Al Viro
2023-11-27 16:03 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Al Viro
2023-11-27 16:03 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Al Viro
2023-11-27 16:14 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Al Viro
2023-11-27 16:14 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Al Viro
2023-11-27 18:19 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Eric W. Biederman
2023-11-27 18:19 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Eric W. Biederman
2023-11-27 18:43 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Al Viro
2023-11-27 18:43 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Al Viro
2023-11-27 16:33 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Christian Brauner
2023-11-27 16:33 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Christian Brauner
2023-11-29 4:53 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Al Viro
2023-11-29 4:53 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Al Viro
2023-11-29 10:21 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Christian Brauner
2023-11-29 10:21 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Christian Brauner
2023-11-29 15:19 ` fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] " Eric W. Biederman
2023-11-29 15:19 ` [f2fs-dev] fun with d_invalidate() vs. d_splice_alias() was " Eric W. Biederman
[not found] ` <655f7665.df0a0220.58a21.e84fSMTPIN_ADDED_BROKEN@mx.google.com>
2023-11-23 16:41 ` [f2fs-dev] " Linus Torvalds
2023-11-23 16:41 ` Linus Torvalds
2023-11-23 1:12 ` Al Viro
2023-11-23 1:12 ` Al Viro
2023-11-23 1:22 ` Al Viro
2023-11-23 1:22 ` Al Viro
2023-11-22 3:30 ` Gabriel Krisman Bertazi
2023-11-22 3:30 ` Gabriel Krisman Bertazi
2024-01-16 19:02 ` patchwork-bot+f2fs
2024-01-16 19:02 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122205926.GH38156@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=krisman@collabora.com \
--cc=krisman@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.