All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Andrzej Hajda <andrzej.hajda@intel.com>
Cc: linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support
Date: Thu, 23 Nov 2023 10:40:31 +0100	[thread overview]
Message-ID: <20231123094040.592-12-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com>

After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.

Preferably this series should be applied via the i2c tree.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 52d91a0df..aca5bb086 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi)
 	init_completion(&i2c->cmp);
 
 	adap = &i2c->adap;
-	adap->class = I2C_CLASS_DDC;
 	adap->owner = THIS_MODULE;
 	adap->dev.parent = hdmi->dev;
 	adap->algo = &dw_hdmi_algorithm;


WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Maxime Ripard <mripard@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	linux-i2c@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: [PATCH v5 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support
Date: Thu, 23 Nov 2023 10:40:31 +0100	[thread overview]
Message-ID: <20231123094040.592-12-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com>

After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.

Preferably this series should be applied via the i2c tree.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 52d91a0df..aca5bb086 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi)
 	init_completion(&i2c->cmp);
 
 	adap = &i2c->adap;
-	adap->class = I2C_CLASS_DDC;
 	adap->owner = THIS_MODULE;
 	adap->dev.parent = hdmi->dev;
 	adap->algo = &dw_hdmi_algorithm;


  parent reply	other threads:[~2023-11-23  9:40 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-23  9:40 [PATCH v5 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-23  9:40 ` Heiner Kallweit
2023-11-23  9:40 ` Heiner Kallweit
2023-11-23  9:40 ` Heiner Kallweit
2023-11-23  9:40 ` [Intel-gfx] " Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 03/20] drm/amd/display: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-24  7:37   ` Sui Jingfeng
2023-11-24  7:37     ` Sui Jingfeng
2023-11-23  9:40 ` [PATCH v5 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` Heiner Kallweit [this message]
2023-11-23  9:40   ` [PATCH v5 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [Intel-gfx] [PATCH v5 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23 11:14   ` [Intel-gfx] " Andi Shyti
2023-11-23 11:14     ` Andi Shyti
2023-11-23 11:14     ` Andi Shyti
2023-11-23  9:40 ` [PATCH v5 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 19/20] drivers/gpu/drm/display: " Heiner Kallweit
2023-11-23  9:40   ` Heiner Kallweit
2023-11-23  9:40 ` [PATCH v5 20/20] include/linux/i2c.h: " Heiner Kallweit
2023-11-23 21:33 ` [PATCH v5 00/20] " Wolfram Sang
2023-11-23 21:33   ` Wolfram Sang
2023-11-23 21:33   ` Wolfram Sang
2023-11-23 21:33   ` Wolfram Sang
2023-11-23 21:33   ` [Intel-gfx] " Wolfram Sang
2023-12-19 12:13   ` Wolfram Sang
2023-12-19 12:13     ` Wolfram Sang
2023-12-19 12:13     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231123094040.592-12-hkallweit1@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.