From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Maik Broemme <mbroemme@libmpq.org>
Cc: linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Helge Deller <deller@gmx.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v5 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support
Date: Thu, 23 Nov 2023 10:40:33 +0100 [thread overview]
Message-ID: <20231123094040.592-14-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com>
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Helge Deller <deller@gmx.de>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c
index 3300bd31d..f24c7cb4c 100644
--- a/drivers/video/fbdev/intelfb/intelfb_i2c.c
+++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c
@@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data)
static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo,
struct intelfb_i2c_chan *chan,
- const u32 reg, const char *name,
- int class)
+ const u32 reg, const char *name)
{
int rc;
@@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo,
chan->reg = reg;
snprintf(chan->adapter.name, sizeof(chan->adapter.name),
"intelfb %s", name);
- chan->adapter.class = class;
chan->adapter.owner = THIS_MODULE;
chan->adapter.algo_data = &chan->algo;
chan->adapter.dev.parent = &chan->dinfo->pdev->dev;
@@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo)
dinfo->output[i].type = INTELFB_OUTPUT_ANALOG;
/* setup the DDC bus for analog output */
- intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA,
- "CRTDDC_A", I2C_CLASS_DDC);
+ intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A");
i++;
/* need to add the output busses for each device
@@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo)
case INTEL_855GM:
case INTEL_865G:
dinfo->output[i].type = INTELFB_OUTPUT_DVO;
- intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus,
- GPIOD, "DVODDC_D", I2C_CLASS_DDC);
- intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus,
- GPIOE, "DVOI2C_E", 0);
+ intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D");
+ intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E");
i++;
break;
case INTEL_915G:
@@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo)
/* SDVO ports have a single control bus - 2 devices */
dinfo->output[i].type = INTELFB_OUTPUT_SDVO;
intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus,
- GPIOE, "SDVOCTRL_E", 0);
+ GPIOE, "SDVOCTRL_E");
/* TODO: initialize the SDVO */
/* I830SDVOInit(pScrn, i, DVOB); */
i++;
WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Maik Broemme <mbroemme@libmpq.org>
Cc: linux-fbdev@vger.kernel.org, Helge Deller <deller@gmx.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-i2c@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: [PATCH v5 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support
Date: Thu, 23 Nov 2023 10:40:33 +0100 [thread overview]
Message-ID: <20231123094040.592-14-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com>
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Helge Deller <deller@gmx.de>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c
index 3300bd31d..f24c7cb4c 100644
--- a/drivers/video/fbdev/intelfb/intelfb_i2c.c
+++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c
@@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data)
static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo,
struct intelfb_i2c_chan *chan,
- const u32 reg, const char *name,
- int class)
+ const u32 reg, const char *name)
{
int rc;
@@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo,
chan->reg = reg;
snprintf(chan->adapter.name, sizeof(chan->adapter.name),
"intelfb %s", name);
- chan->adapter.class = class;
chan->adapter.owner = THIS_MODULE;
chan->adapter.algo_data = &chan->algo;
chan->adapter.dev.parent = &chan->dinfo->pdev->dev;
@@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo)
dinfo->output[i].type = INTELFB_OUTPUT_ANALOG;
/* setup the DDC bus for analog output */
- intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA,
- "CRTDDC_A", I2C_CLASS_DDC);
+ intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A");
i++;
/* need to add the output busses for each device
@@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo)
case INTEL_855GM:
case INTEL_865G:
dinfo->output[i].type = INTELFB_OUTPUT_DVO;
- intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus,
- GPIOD, "DVODDC_D", I2C_CLASS_DDC);
- intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus,
- GPIOE, "DVOI2C_E", 0);
+ intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D");
+ intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E");
i++;
break;
case INTEL_915G:
@@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo)
/* SDVO ports have a single control bus - 2 devices */
dinfo->output[i].type = INTELFB_OUTPUT_SDVO;
intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus,
- GPIOE, "SDVOCTRL_E", 0);
+ GPIOE, "SDVOCTRL_E");
/* TODO: initialize the SDVO */
/* I830SDVOInit(pScrn, i, DVOB); */
i++;
next prev parent reply other threads:[~2023-11-23 9:40 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 9:40 [PATCH v5 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [Intel-gfx] " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 03/20] drm/amd/display: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-24 7:37 ` Sui Jingfeng
2023-11-24 7:37 ` Sui Jingfeng
2023-11-23 9:40 ` [PATCH v5 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit [this message]
2023-11-23 9:40 ` [PATCH v5 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [Intel-gfx] [PATCH v5 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 11:14 ` [Intel-gfx] " Andi Shyti
2023-11-23 11:14 ` Andi Shyti
2023-11-23 11:14 ` Andi Shyti
2023-11-23 9:40 ` [PATCH v5 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 19/20] drivers/gpu/drm/display: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 20/20] include/linux/i2c.h: " Heiner Kallweit
2023-11-23 21:33 ` [PATCH v5 00/20] " Wolfram Sang
2023-11-23 21:33 ` Wolfram Sang
2023-11-23 21:33 ` Wolfram Sang
2023-11-23 21:33 ` Wolfram Sang
2023-11-23 21:33 ` [Intel-gfx] " Wolfram Sang
2023-12-19 12:13 ` Wolfram Sang
2023-12-19 12:13 ` Wolfram Sang
2023-12-19 12:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123094040.592-14-hkallweit1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroemme@libmpq.org \
--cc=tzimmermann@suse.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.