Re: [PATCH 00/18] mfd: Convert to platform remove callback returning void

From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	chrome-platform@lists.linux.dev,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	linux-arm-msm@vger.kernel.org,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 00/18] mfd: Convert to platform remove callback returning void
Date: Thu, 23 Nov 2023 14:24:41 +0000	[thread overview]
Message-ID: <20231123142441.GA1354538@google.com> (raw)
In-Reply-To: <20231106171708.3892347-1-u.kleine-koenig@pengutronix.de>

On Mon, 06 Nov 2023, Uwe Kleine-König wrote:

> Hello,
> 
> this series converts all platform drivers below drivers/mfd to use
> .remove_new(). Compared to the traditional .remove() callback
> .remove_new() returns no value. This is a good thing because the driver
> core doesn't (and cannot) cope for errors during remove. The only effect
> of a non-zero return value in .remove() is that the driver core emits a
> warning. The device is removed anyhow and an early return from .remove()
> usually yields resource leaks and/or use-after-free bugs.
> 
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
> 
> All drivers converted here already returned zero unconditionally in
> .remove(), so they are converted here trivially.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (18):
>   mfd: ab8500-sysctrl: Convert to platform remove callback returning
>     void
>   mfd: cros_ec_dev: Convert to platform remove callback returning void
>   mfd: exynos-lpass: Convert to platform remove callback returning void
>   mfd: fsl-imx25-tsadc: Convert to platform remove callback returning
>     void
>   mfd: hi655x-pmic: Convert to platform remove callback returning void
>   mfd: intel-lpss-acpi: Convert to platform remove callback returning
>     void
>   mfd: kempld-core: Convert to platform remove callback returning void
>   mfd: mcp-sa11x0: Convert to platform remove callback returning void
>   mfd: mxs-lradc: Convert to platform remove callback returning void
>   mfd: omap-usb-host: Convert to platform remove callback returning void
>   mfd: omap-usb-tll: Convert to platform remove callback returning void
>   mfd: pcf50633-adc: Convert to platform remove callback returning void
>   mfd: qcom-pm8xxx: Convert to platform remove callback returning void
>   mfd: sm501: Convert to platform remove callback returning void
>   mfd: stm32-timers: Convert to platform remove callback returning void
>   mfd: ti_am335x_tscadc: Convert to platform remove callback returning
>     void
>   mfd: tps65911-comparator: Convert to platform remove callback
>     returning void
>   mfd: twl4030-audio: Convert to platform remove callback returning void

Looks like you missed the mailing list on a bunch of these.

I'm going to remove this set for now.

Could you please resubmit it and Cc: LKML?

>  drivers/mfd/ab8500-sysctrl.c      | 6 ++----
>  drivers/mfd/cros_ec_dev.c         | 5 ++---
>  drivers/mfd/exynos-lpass.c        | 6 ++----
>  drivers/mfd/fsl-imx25-tsadc.c     | 6 ++----
>  drivers/mfd/hi655x-pmic.c         | 5 ++---
>  drivers/mfd/intel-lpss-acpi.c     | 6 ++----
>  drivers/mfd/kempld-core.c         | 6 ++----
>  drivers/mfd/mcp-sa11x0.c          | 6 ++----
>  drivers/mfd/mxs-lradc.c           | 6 ++----
>  drivers/mfd/omap-usb-host.c       | 5 ++---
>  drivers/mfd/omap-usb-tll.c        | 5 ++---
>  drivers/mfd/pcf50633-adc.c        | 6 ++----
>  drivers/mfd/qcom-pm8xxx.c         | 6 ++----
>  drivers/mfd/sm501.c               | 6 ++----
>  drivers/mfd/stm32-timers.c        | 6 ++----
>  drivers/mfd/ti_am335x_tscadc.c    | 6 ++----
>  drivers/mfd/tps65911-comparator.c | 6 ++----
>  drivers/mfd/twl4030-audio.c       | 6 ++----
>  18 files changed, 36 insertions(+), 68 deletions(-)
> 
> base-commit: 3ff7a5781ceee3befb9224d29cef6e6a4766c5fe
> -- 
> 2.42.0
> 

-- 
Lee Jones [李琼斯]