All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Jerry Shih <jerry.shih@sifive.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, herbert@gondor.apana.org.au,
	davem@davemloft.net, conor.dooley@microchip.com,
	ebiggers@kernel.org, ardb@kernel.org, heiko@sntech.de,
	phoebe.chen@sifive.com, hongrong.hsu@sifive.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 04/13] RISC-V: crypto: add Zvkned accelerated AES implementation
Date: Tue, 28 Nov 2023 17:54:49 +0000	[thread overview]
Message-ID: <20231128-await-tipper-2094715466f2@spud> (raw)
In-Reply-To: <20231127070703.1697-5-jerry.shih@sifive.com>

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

> +static inline bool check_aes_ext(void)
> +{
> +	return riscv_isa_extension_available(NULL, ZVKNED) &&
> +	       riscv_vector_vlen() >= 128;
> +}

I'm not keen on this construct, where you are checking vlen greater than
128 and the presence of Zvkned without checking for the presence of V
itself. Can you use "has_vector()" in any places where you depend on the
presence of vector please?

Also, there are potentially a lot of places in this drivers where you
can replace "riscv_isa_extension_available()" with
"riscv_has_extension_likely()". The latter is optimised with
alternatives, so in places that are going to be evaluated frequently it
may be beneficial for you.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Jerry Shih <jerry.shih@sifive.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, herbert@gondor.apana.org.au,
	davem@davemloft.net, conor.dooley@microchip.com,
	ebiggers@kernel.org, ardb@kernel.org, heiko@sntech.de,
	phoebe.chen@sifive.com, hongrong.hsu@sifive.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 04/13] RISC-V: crypto: add Zvkned accelerated AES implementation
Date: Tue, 28 Nov 2023 17:54:49 +0000	[thread overview]
Message-ID: <20231128-await-tipper-2094715466f2@spud> (raw)
In-Reply-To: <20231127070703.1697-5-jerry.shih@sifive.com>


[-- Attachment #1.1: Type: text/plain, Size: 691 bytes --]

> +static inline bool check_aes_ext(void)
> +{
> +	return riscv_isa_extension_available(NULL, ZVKNED) &&
> +	       riscv_vector_vlen() >= 128;
> +}

I'm not keen on this construct, where you are checking vlen greater than
128 and the presence of Zvkned without checking for the presence of V
itself. Can you use "has_vector()" in any places where you depend on the
presence of vector please?

Also, there are potentially a lot of places in this drivers where you
can replace "riscv_isa_extension_available()" with
"riscv_has_extension_likely()". The latter is optimised with
alternatives, so in places that are going to be evaluated frequently it
may be beneficial for you.

Cheers,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2023-11-28 17:54 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27  7:06 [PATCH v2 00/13] RISC-V: provide some accelerated cryptography implementations using vector extensions Jerry Shih
2023-11-27  7:06 ` Jerry Shih
2023-11-27  7:06 ` [PATCH v2 01/13] RISC-V: add helper function to read the vector VLEN Jerry Shih
2023-11-27  7:06   ` Jerry Shih
2023-11-28  3:45   ` Eric Biggers
2023-11-28  3:45     ` Eric Biggers
2023-11-27  7:06 ` [PATCH v2 02/13] RISC-V: hook new crypto subdir into build-system Jerry Shih
2023-11-27  7:06   ` Jerry Shih
2023-11-28  3:45   ` Eric Biggers
2023-11-28  3:45     ` Eric Biggers
2023-11-27  7:06 ` [PATCH v2 03/13] RISC-V: crypto: add OpenSSL perl module for vector instructions Jerry Shih
2023-11-27  7:06   ` Jerry Shih
2023-11-27  7:06 ` [PATCH v2 04/13] RISC-V: crypto: add Zvkned accelerated AES implementation Jerry Shih
2023-11-27  7:06   ` Jerry Shih
2023-11-28  3:56   ` Eric Biggers
2023-11-28  3:56     ` Eric Biggers
2023-11-28  4:22     ` Jerry Shih
2023-11-28  4:22       ` Jerry Shih
2023-11-28  4:38       ` Eric Biggers
2023-11-28  4:38         ` Eric Biggers
2023-11-28 17:54   ` Conor Dooley [this message]
2023-11-28 17:54     ` Conor Dooley
2023-11-28 20:12     ` Eric Biggers
2023-11-28 20:12       ` Eric Biggers
2023-11-29  2:39       ` Jerry Shih
2023-11-29  2:39         ` Jerry Shih
2023-11-29 11:12         ` Conor Dooley
2023-11-29 11:12           ` Conor Dooley
2023-11-29 20:26           ` Eric Biggers
2023-11-29 20:26             ` Eric Biggers
2023-11-27  7:06 ` [PATCH v2 05/13] crypto: simd - Update `walksize` in simd skcipher Jerry Shih
2023-11-27  7:06   ` Jerry Shih
2023-11-28  3:58   ` Eric Biggers
2023-11-28  3:58     ` Eric Biggers
2023-11-28  5:38     ` Jerry Shih
2023-11-28  5:38       ` Jerry Shih
2023-11-28 17:22       ` Eric Biggers
2023-11-28 17:22         ` Eric Biggers
2023-12-01  2:09         ` Jerry Shih
2023-12-01  2:09           ` Jerry Shih
2023-12-08  4:05   ` Herbert Xu
2023-12-08  4:05     ` Herbert Xu
2023-12-08  4:18     ` Jerry Shih
2023-12-08  4:18       ` Jerry Shih
2023-11-27  7:06 ` [PATCH v2 06/13] crypto: scatterwalk - Add scatterwalk_next() to get the next scatterlist in scatter_walk Jerry Shih
2023-11-27  7:06   ` Jerry Shih
2023-11-27  7:06 ` [PATCH v2 07/13] RISC-V: crypto: add accelerated AES-CBC/CTR/ECB/XTS implementations Jerry Shih
2023-11-27  7:06   ` Jerry Shih
2023-11-28  4:07   ` Eric Biggers
2023-11-28  4:07     ` Eric Biggers
2023-11-29  7:57     ` Jerry Shih
2023-11-29  7:57       ` Jerry Shih
2023-11-29 20:16       ` Eric Biggers
2023-11-29 20:16         ` Eric Biggers
2023-12-02 13:20         ` Jerry Shih
2023-12-02 13:20           ` Jerry Shih
2023-11-27  7:06 ` [PATCH v2 08/13] RISC-V: crypto: add Zvkg accelerated GCM GHASH implementation Jerry Shih
2023-11-27  7:06   ` Jerry Shih
2023-11-27  7:06 ` [PATCH v2 09/13] RISC-V: crypto: add Zvknha/b accelerated SHA224/256 implementations Jerry Shih
2023-11-27  7:06   ` Jerry Shih
2023-11-28  4:12   ` Eric Biggers
2023-11-28  4:12     ` Eric Biggers
2023-11-28  7:16     ` Jerry Shih
2023-11-28  7:16       ` Jerry Shih
2023-11-28 17:23       ` Eric Biggers
2023-11-28 17:23         ` Eric Biggers
2023-11-27  7:07 ` [PATCH v2 10/13] RISC-V: crypto: add Zvknhb accelerated SHA384/512 implementations Jerry Shih
2023-11-27  7:07   ` Jerry Shih
2023-11-27  7:07 ` [PATCH v2 11/13] RISC-V: crypto: add Zvksed accelerated SM4 implementation Jerry Shih
2023-11-27  7:07   ` Jerry Shih
2023-11-27  7:07 ` [PATCH v2 12/13] RISC-V: crypto: add Zvksh accelerated SM3 implementation Jerry Shih
2023-11-27  7:07   ` Jerry Shih
2023-11-28  4:13   ` Eric Biggers
2023-11-28  4:13     ` Eric Biggers
2023-11-29  5:32     ` Jerry Shih
2023-11-29  5:32       ` Jerry Shih
2023-11-27  7:07 ` [PATCH v2 13/13] RISC-V: crypto: add Zvkb accelerated ChaCha20 implementation Jerry Shih
2023-11-27  7:07   ` Jerry Shih
2023-11-28  4:25   ` Eric Biggers
2023-11-28  4:25     ` Eric Biggers
2023-11-28  8:57     ` Jerry Shih
2023-11-28  8:57       ` Jerry Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231128-await-tipper-2094715466f2@spud \
    --to=conor@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=ardb@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=davem@davemloft.net \
    --cc=ebiggers@kernel.org \
    --cc=heiko@sntech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=hongrong.hsu@sifive.com \
    --cc=jerry.shih@sifive.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=phoebe.chen@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.