From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, sboyd@kernel.org,
mturquette@baylibre.com, tzimmermann@suse.de, mripard@kernel.org,
maarten.lankhorst@linux.intel.com, daniel@ffwll.ch,
airlied@gmail.com, sam@ravnborg.org, quic_jesszhan@quicinc.com,
neil.armstrong@linaro.org, javierm@redhat.com, heiko@sntech.de,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH 7/9] clk: rockchip: Mark pclk_usb as critical on rk3568
Date: Thu, 30 Nov 2023 09:56:22 -0600 [thread overview]
Message-ID: <20231130155624.405575-8-macroalpha82@gmail.com> (raw)
In-Reply-To: <20231130155624.405575-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
In the reference manual under "2.8.6 NIU Clock gating reliance"
it is stated that pclk_usb_niu has a dependency on hclk_usb_niu.
While the manual does not state that this is a bi-directional
relationship it was noted that the sdmmc2 failed to operate for me in
mmc mode if the pclk_usb was not marked as critical. The parent clock
of the hclk_sdmmc2 is hclk_usb.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/clk/rockchip/clk-rk3568.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
index a8457b17bc41..0e0b7b396682 100644
--- a/drivers/clk/rockchip/clk-rk3568.c
+++ b/drivers/clk/rockchip/clk-rk3568.c
@@ -1596,6 +1596,7 @@ static const char *const rk3568_cru_critical_clocks[] __initconst = {
"pclk_php",
"hclk_usb",
"hclk_vo",
+ "pclk_usb",
};
static const char *const rk3568_pmucru_critical_clocks[] __initconst = {
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, sboyd@kernel.org,
mturquette@baylibre.com, tzimmermann@suse.de, mripard@kernel.org,
maarten.lankhorst@linux.intel.com, daniel@ffwll.ch,
airlied@gmail.com, sam@ravnborg.org, quic_jesszhan@quicinc.com,
neil.armstrong@linaro.org, javierm@redhat.com, heiko@sntech.de,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH 7/9] clk: rockchip: Mark pclk_usb as critical on rk3568
Date: Thu, 30 Nov 2023 09:56:22 -0600 [thread overview]
Message-ID: <20231130155624.405575-8-macroalpha82@gmail.com> (raw)
In-Reply-To: <20231130155624.405575-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
In the reference manual under "2.8.6 NIU Clock gating reliance"
it is stated that pclk_usb_niu has a dependency on hclk_usb_niu.
While the manual does not state that this is a bi-directional
relationship it was noted that the sdmmc2 failed to operate for me in
mmc mode if the pclk_usb was not marked as critical. The parent clock
of the hclk_sdmmc2 is hclk_usb.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/clk/rockchip/clk-rk3568.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
index a8457b17bc41..0e0b7b396682 100644
--- a/drivers/clk/rockchip/clk-rk3568.c
+++ b/drivers/clk/rockchip/clk-rk3568.c
@@ -1596,6 +1596,7 @@ static const char *const rk3568_cru_critical_clocks[] __initconst = {
"pclk_php",
"hclk_usb",
"hclk_vo",
+ "pclk_usb",
};
static const char *const rk3568_pmucru_critical_clocks[] __initconst = {
--
2.34.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
Chris Morgan <macromorgan@hotmail.com>,
krzysztof.kozlowski+dt@linaro.org, neil.armstrong@linaro.org,
sboyd@kernel.org, sam@ravnborg.org, mturquette@baylibre.com,
javierm@redhat.com, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, mripard@kernel.org, tzimmermann@suse.de,
quic_jesszhan@quicinc.com, linux-clk@vger.kernel.org
Subject: [PATCH 7/9] clk: rockchip: Mark pclk_usb as critical on rk3568
Date: Thu, 30 Nov 2023 09:56:22 -0600 [thread overview]
Message-ID: <20231130155624.405575-8-macroalpha82@gmail.com> (raw)
In-Reply-To: <20231130155624.405575-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
In the reference manual under "2.8.6 NIU Clock gating reliance"
it is stated that pclk_usb_niu has a dependency on hclk_usb_niu.
While the manual does not state that this is a bi-directional
relationship it was noted that the sdmmc2 failed to operate for me in
mmc mode if the pclk_usb was not marked as critical. The parent clock
of the hclk_sdmmc2 is hclk_usb.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/clk/rockchip/clk-rk3568.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
index a8457b17bc41..0e0b7b396682 100644
--- a/drivers/clk/rockchip/clk-rk3568.c
+++ b/drivers/clk/rockchip/clk-rk3568.c
@@ -1596,6 +1596,7 @@ static const char *const rk3568_cru_critical_clocks[] __initconst = {
"pclk_php",
"hclk_usb",
"hclk_vo",
+ "pclk_usb",
};
static const char *const rk3568_pmucru_critical_clocks[] __initconst = {
--
2.34.1
next prev parent reply other threads:[~2023-11-30 15:56 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 15:56 [PATCH 0/9] rockchip: Add Powkiddy X55 Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` [PATCH 1/9] drm/panel: himax-hx8394: Drop prepare/unprepare tracking Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` [PATCH 2/9] drm/panel: himax-hx8394: Drop shutdown logic Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` [PATCH 3/9] dt-bindings: display: Document Himax HX8394 panel rotation Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-12-01 8:40 ` Krzysztof Kozlowski
2023-12-01 8:40 ` Krzysztof Kozlowski
2023-12-01 8:40 ` Krzysztof Kozlowski
2023-11-30 15:56 ` [PATCH 4/9] drm/panel: himax-hx8394: Add Panel Rotation Support Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` [PATCH 5/9] dt-bindings: display: himax-hx8394: Add Powkiddy X55 panel Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-12-01 8:40 ` Krzysztof Kozlowski
2023-12-01 8:40 ` Krzysztof Kozlowski
2023-12-01 8:40 ` Krzysztof Kozlowski
2023-11-30 15:56 ` [PATCH 6/9] drm/panel: himax-hx8394: Add Support for " Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-12-01 3:19 ` Kendrick Curry
2023-12-01 3:19 ` Kendrick Curry
2023-12-01 3:19 ` Kendrick Curry
2023-12-01 17:18 ` Chris Morgan
2023-12-01 17:18 ` Chris Morgan
2023-12-01 17:18 ` Chris Morgan
2023-11-30 15:56 ` Chris Morgan [this message]
2023-11-30 15:56 ` [PATCH 7/9] clk: rockchip: Mark pclk_usb as critical on rk3568 Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` [PATCH 8/9] dt-bindings: arm: rockchip: Add Powkiddy X55 Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-12-01 8:40 ` Krzysztof Kozlowski
2023-12-01 8:40 ` Krzysztof Kozlowski
2023-12-01 8:40 ` Krzysztof Kozlowski
2023-11-30 15:56 ` [PATCH 9/9] arm64: dts: " Chris Morgan
2023-11-30 15:56 ` Chris Morgan
2023-11-30 15:56 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130155624.405575-8-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=macromorgan@hotmail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.