* [ti:ti-linux-6.1.y-wip 13/22] drivers/net/can/m_can/m_can.c:1890:60: sparse: sparse: dubious: !x & y
@ 2023-11-26 13:22 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-11-26 13:22 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "low confidence static check warning: drivers/net/can/m_can/m_can.c:1890:60: sparse: sparse: dubious: !x & y"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: vigneshr@ti.com
CC: nm@ti.com
CC: Praneeth Bajjuri <praneeth@ti.com>
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-6.1.y-wip
head: 07cbd0efc06ffff69b2b0c3d7d607b35829340c3
commit: a82817238831b72570a3135027ba3bc52becabb7 [13/22] can: m_can: Map WoL to device_set_wakeup_enable
:::::: branch date: 2 days ago
:::::: commit date: 10 days ago
config: mips-randconfig-r121-20231126 (https://download.01.org/0day-ci/archive/20231126/202311262053.57NKWxyU-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231126/202311262053.57NKWxyU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202311262053.57NKWxyU-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/net/can/m_can/m_can.c:1890:60: sparse: sparse: dubious: !x & y
drivers/net/can/m_can/m_can.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...):
include/linux/page-flags.h:248:46: sparse: sparse: self-comparison always evaluates to false
vim +1890 drivers/net/can/m_can/m_can.c
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1882
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1883 static int m_can_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1884 {
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1885 struct m_can_classdev *cdev = netdev_priv(dev);
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1886
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1887 if ((wol->wolopts & WAKE_PHY) != wol->wolopts)
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1888 return -EINVAL;
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1889
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 @1890 device_set_wakeup_enable(cdev->dev, !!wol->wolopts & WAKE_PHY);
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1891
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1892 return 0;
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1893 }
a82817238831b7 Markus Schneider-Pargmann 2023-11-16 1894
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [ti:ti-linux-6.1.y-wip 13/22] drivers/net/can/m_can/m_can.c:1890:60: sparse: sparse: dubious: !x & y
@ 2023-12-14 17:46 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-12-14 17:46 UTC (permalink / raw)
Cc: oe-kbuild-all, vigneshr, nm, Praneeth Bajjuri
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-6.1.y-wip
head: 247b2535b24894d5ac7f3d8cfc3b48edb7214cc0
commit: a82817238831b72570a3135027ba3bc52becabb7 [13/22] can: m_can: Map WoL to device_set_wakeup_enable
config: mips-randconfig-r121-20231126 (https://download.01.org/0day-ci/archive/20231215/202312150119.f50Lh0Xf-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231215/202312150119.f50Lh0Xf-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312150119.f50Lh0Xf-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/net/can/m_can/m_can.c:1890:60: sparse: sparse: dubious: !x & y
drivers/net/can/m_can/m_can.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...):
include/linux/page-flags.h:248:46: sparse: sparse: self-comparison always evaluates to false
vim +1890 drivers/net/can/m_can/m_can.c
1882
1883 static int m_can_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
1884 {
1885 struct m_can_classdev *cdev = netdev_priv(dev);
1886
1887 if ((wol->wolopts & WAKE_PHY) != wol->wolopts)
1888 return -EINVAL;
1889
> 1890 device_set_wakeup_enable(cdev->dev, !!wol->wolopts & WAKE_PHY);
1891
1892 return 0;
1893 }
1894
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-14 17:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-14 17:46 [ti:ti-linux-6.1.y-wip 13/22] drivers/net/can/m_can/m_can.c:1890:60: sparse: sparse: dubious: !x & y kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-11-26 13:22 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.