From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org,
sboyd@kernel.org, mturquette@baylibre.com,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 01/16] dt-bindings: phy: qmp-ufs: Fix PHY clocks
Date: Mon, 18 Dec 2023 17:18:58 +0530 [thread overview]
Message-ID: <20231218114858.GA2900@thinkpad> (raw)
In-Reply-To: <20231214172051.GA611674-robh@kernel.org>
On Thu, Dec 14, 2023 at 11:20:51AM -0600, Rob Herring wrote:
> On Thu, Dec 14, 2023 at 02:40:46PM +0530, Manivannan Sadhasivam wrote:
> > All QMP UFS PHYs except MSM8996 require 3 clocks:
> >
> > * ref - 19.2MHz reference clock from RPMh
> > * ref_aux - Auxiliary reference clock from GCC
> > * qref - QREF clock from GCC or TCSR (since SM8550)
> >
> > MSM8996 only requires 'ref' and 'qref' clocks. Hence, fix the binding to
> > reflect the actual clock topology.
>
> Breaking the ABI is okay because...? Please explain in the commit msg.
>
I will update the commit message in v2.
- Mani
> Rob
>
--
மணிவண்ணன் சதாசிவம்
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org,
sboyd@kernel.org, mturquette@baylibre.com,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 01/16] dt-bindings: phy: qmp-ufs: Fix PHY clocks
Date: Mon, 18 Dec 2023 17:18:58 +0530 [thread overview]
Message-ID: <20231218114858.GA2900@thinkpad> (raw)
In-Reply-To: <20231214172051.GA611674-robh@kernel.org>
On Thu, Dec 14, 2023 at 11:20:51AM -0600, Rob Herring wrote:
> On Thu, Dec 14, 2023 at 02:40:46PM +0530, Manivannan Sadhasivam wrote:
> > All QMP UFS PHYs except MSM8996 require 3 clocks:
> >
> > * ref - 19.2MHz reference clock from RPMh
> > * ref_aux - Auxiliary reference clock from GCC
> > * qref - QREF clock from GCC or TCSR (since SM8550)
> >
> > MSM8996 only requires 'ref' and 'qref' clocks. Hence, fix the binding to
> > reflect the actual clock topology.
>
> Breaking the ABI is okay because...? Please explain in the commit msg.
>
I will update the commit message in v2.
- Mani
> Rob
>
--
மணிவண்ணன் சதாசிவம்
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-12-18 11:49 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 9:10 [PATCH 00/16] Fix Qcom UFS PHY clocks Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 01/16] dt-bindings: phy: qmp-ufs: Fix " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 15:55 ` Conor Dooley
2023-12-14 15:55 ` Conor Dooley
2023-12-14 17:20 ` Rob Herring
2023-12-14 17:20 ` Rob Herring
2023-12-18 11:48 ` Manivannan Sadhasivam [this message]
2023-12-18 11:48 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 02/16] phy: qcom-qmp-ufs: Switch to devm_clk_bulk_get_all() API Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 03/16] dt-bindings: clock: qcom: Add missing UFS QREF clocks Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 15:44 ` Conor Dooley
2023-12-14 15:44 ` Conor Dooley
2023-12-14 9:10 ` [PATCH 04/16] clk: qcom: gcc-sc8180x: " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 05/16] arm64: dts: qcom: msm8996: Fix UFS PHY clocks Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 06/16] arm64: dts: qcom: msm8998: " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 07/16] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 08/16] arm64: dts: qcom: sm6115: " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 09/16] arm64: dts: qcom: sm6125: " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 10/16] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 11/16] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 12/16] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 13/16] arm64: dts: qcom: sc8180x: " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:10 ` [PATCH 14/16] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
2023-12-14 9:10 ` Manivannan Sadhasivam
2023-12-14 9:11 ` [PATCH 15/16] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
2023-12-14 9:11 ` Manivannan Sadhasivam
2023-12-14 9:11 ` [PATCH 16/16] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
2023-12-14 9:11 ` Manivannan Sadhasivam
2023-12-14 10:15 ` [PATCH 00/16] Fix Qcom " Johan Hovold
2023-12-14 10:15 ` Johan Hovold
2023-12-14 10:39 ` Manivannan Sadhasivam
2023-12-14 10:39 ` Manivannan Sadhasivam
2023-12-14 11:00 ` Johan Hovold
2023-12-14 11:00 ` Johan Hovold
2023-12-14 11:14 ` Manivannan Sadhasivam
2023-12-14 11:14 ` Manivannan Sadhasivam
2023-12-14 11:30 ` Johan Hovold
2023-12-14 11:30 ` Johan Hovold
2023-12-14 11:49 ` Manivannan Sadhasivam
2023-12-14 11:49 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218114858.GA2900@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.