From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>,
Dharma Balasubiramani <dharma.b@microchip.com>
Cc: linux4microchip@microchip.com, linux-pwm@vger.kernel.org,
alexandre.belloni@bootlin.com, dri-devel@lists.freedesktop.org,
nicolas.ferre@microchip.com, conor.dooley@microchip.com,
thierry.reding@gmail.com, krzysztof.kozlowski+dt@linaro.org,
claudiu.beznea@tuxon.dev, airlied@gmail.com, lee@kernel.org,
Dharma Balasubiramani <dharma.b@microchip.com>,
u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org,
conor+dt@kernel.org, tzimmermann@suse.de, mripard@kernel.org,
linux-arm-kernel@lists.infradead.org, bbrezillon@kernel.org,
linux-kernel@vger.kernel.org, daniel@ffwll.ch
Subject: Re: [PATCH v3 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema
Date: Sat, 20 Jan 2024 14:23:56 +0100 [thread overview]
Message-ID: <20240120132356.GA345206@ravnborg.org> (raw)
In-Reply-To: <20240119195151.GB938671-robh@kernel.org>
Hi Dharma & Rob.
> > To make the DT binding backward compatible you likely need to add a few
> > compatible that otherwise would have been left out - but that should do
> > the trick.
> >
> > The current atmel hlcdc driver that is split in three is IMO an
> > over-engineering, and the driver could benefit merging it all in one.
> > And the binding should not prevent this.
>
> I agree on all this, but a conversion is not really the time to redesign
> things. Trust me, I've wanted to on lots of conversions. It should be
> possible to simplify the driver side while keeping the DT as-is. Just
> make the display driver bind to the MFD node instead. After that, then
> one could look at flattening everything to 1 node.
Understood and thinking a bit about it fully agreed as well.
Dharma - please see my comments only as ideas for the future, and
ignore them in this fine rewrite you do.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>,
Dharma Balasubiramani <dharma.b@microchip.com>
Cc: conor+dt@kernel.org, linux-pwm@vger.kernel.org,
linux4microchip@microchip.com, tzimmermann@suse.de,
devicetree@vger.kernel.org, daniel@ffwll.ch,
linux-kernel@vger.kernel.org, lee@kernel.org,
Dharma Balasubiramani <dharma.b@microchip.com>,
alexandre.belloni@bootlin.com, dri-devel@lists.freedesktop.org,
conor.dooley@microchip.com, thierry.reding@gmail.com,
mripard@kernel.org, krzysztof.kozlowski+dt@linaro.org,
claudiu.beznea@tuxon.dev, u.kleine-koenig@pengutronix.de,
airlied@gmail.com, linux-arm-kernel@lists.infradead.org,
bbrezillon@kernel.org
Subject: Re: [PATCH v3 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema
Date: Sat, 20 Jan 2024 14:23:56 +0100 [thread overview]
Message-ID: <20240120132356.GA345206@ravnborg.org> (raw)
In-Reply-To: <20240119195151.GB938671-robh@kernel.org>
Hi Dharma & Rob.
> > To make the DT binding backward compatible you likely need to add a few
> > compatible that otherwise would have been left out - but that should do
> > the trick.
> >
> > The current atmel hlcdc driver that is split in three is IMO an
> > over-engineering, and the driver could benefit merging it all in one.
> > And the binding should not prevent this.
>
> I agree on all this, but a conversion is not really the time to redesign
> things. Trust me, I've wanted to on lots of conversions. It should be
> possible to simplify the driver side while keeping the DT as-is. Just
> make the display driver bind to the MFD node instead. After that, then
> one could look at flattening everything to 1 node.
Understood and thinking a bit about it fully agreed as well.
Dharma - please see my comments only as ideas for the future, and
ignore them in this fine rewrite you do.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>,
Dharma Balasubiramani <dharma.b@microchip.com>
Cc: conor+dt@kernel.org, linux-pwm@vger.kernel.org,
linux4microchip@microchip.com, tzimmermann@suse.de,
devicetree@vger.kernel.org, daniel@ffwll.ch,
linux-kernel@vger.kernel.org, lee@kernel.org,
Dharma Balasubiramani <dharma.b@microchip.com>,
alexandre.belloni@bootlin.com, dri-devel@lists.freedesktop.org,
nicolas.ferre@microchip.com, conor.dooley@microchip.com,
thierry.reding@gmail.com, mripard@kernel.org,
krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@tuxon.dev,
u.kleine-koenig@pengutronix.de, airlied@gmail.com,
linux-arm-kernel@lists.infradead.org, bbrezillon@kernel.org
Subject: Re: [PATCH v3 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema
Date: Sat, 20 Jan 2024 14:23:56 +0100 [thread overview]
Message-ID: <20240120132356.GA345206@ravnborg.org> (raw)
In-Reply-To: <20240119195151.GB938671-robh@kernel.org>
Hi Dharma & Rob.
> > To make the DT binding backward compatible you likely need to add a few
> > compatible that otherwise would have been left out - but that should do
> > the trick.
> >
> > The current atmel hlcdc driver that is split in three is IMO an
> > over-engineering, and the driver could benefit merging it all in one.
> > And the binding should not prevent this.
>
> I agree on all this, but a conversion is not really the time to redesign
> things. Trust me, I've wanted to on lots of conversions. It should be
> possible to simplify the driver side while keeping the DT as-is. Just
> make the display driver bind to the MFD node instead. After that, then
> one could look at flattening everything to 1 node.
Understood and thinking a bit about it fully agreed as well.
Dharma - please see my comments only as ideas for the future, and
ignore them in this fine rewrite you do.
Sam
next prev parent reply other threads:[~2024-01-20 13:25 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 9:26 [PATCH v3 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema Dharma Balasubiramani
2024-01-18 9:26 ` Dharma Balasubiramani
2024-01-18 9:26 ` Dharma Balasubiramani
2024-01-18 9:26 ` [PATCH v3 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema Dharma Balasubiramani
2024-01-18 9:26 ` Dharma Balasubiramani
2024-01-18 9:26 ` Dharma Balasubiramani
2024-01-18 15:31 ` Conor Dooley
2024-01-18 15:31 ` Conor Dooley
2024-01-18 15:31 ` Conor Dooley
2024-01-19 2:51 ` Dharma.B
2024-01-19 2:51 ` Dharma.B
2024-01-19 2:51 ` Dharma.B
2024-01-18 9:26 ` [PATCH v3 2/3] dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema Dharma Balasubiramani
2024-01-18 9:26 ` [PATCH v3 2/3] dt-bindings: atmel, hlcdc: " Dharma Balasubiramani
2024-01-18 9:26 ` [PATCH v3 2/3] dt-bindings: atmel,hlcdc: " Dharma Balasubiramani
2024-01-18 10:16 ` Uwe Kleine-König
2024-01-18 10:16 ` [PATCH v3 2/3] dt-bindings: atmel, hlcdc: " Uwe Kleine-König
2024-01-18 10:16 ` [PATCH v3 2/3] dt-bindings: atmel,hlcdc: " Uwe Kleine-König
2024-01-20 10:03 ` Uwe Kleine-König
2024-01-20 10:03 ` [PATCH v3 2/3] dt-bindings: atmel, hlcdc: " Uwe Kleine-König
2024-01-20 10:03 ` [PATCH v3 2/3] dt-bindings: atmel,hlcdc: " Uwe Kleine-König
2024-01-19 19:45 ` Rob Herring
2024-01-19 19:45 ` [PATCH v3 2/3] dt-bindings: atmel, hlcdc: " Rob Herring
2024-01-19 19:45 ` [PATCH v3 2/3] dt-bindings: atmel,hlcdc: " Rob Herring
2024-01-24 9:58 ` Dharma.B
2024-01-24 9:58 ` [PATCH v3 2/3] dt-bindings: atmel, hlcdc: " Dharma.B
2024-01-24 9:58 ` [PATCH v3 2/3] dt-bindings: atmel,hlcdc: " Dharma.B
2024-01-18 9:26 ` [PATCH v3 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format Dharma Balasubiramani
2024-01-18 9:26 ` [PATCH v3 3/3] dt-bindings: mfd: atmel, hlcdc: " Dharma Balasubiramani
2024-01-18 9:26 ` [PATCH v3 3/3] dt-bindings: mfd: atmel,hlcdc: " Dharma Balasubiramani
2024-01-18 15:40 ` Conor Dooley
2024-01-18 15:40 ` Conor Dooley
2024-01-18 15:40 ` Conor Dooley
2024-01-19 3:32 ` Dharma.B
2024-01-19 3:32 ` Dharma.B
2024-01-19 3:32 ` Dharma.B
2024-01-19 12:03 ` Conor Dooley
2024-01-19 12:03 ` Conor Dooley
2024-01-19 12:03 ` Conor Dooley
2024-01-22 3:38 ` Dharma.B
2024-01-22 3:38 ` Dharma.B
2024-01-22 3:38 ` Dharma.B
2024-01-22 9:16 ` Conor Dooley
2024-01-22 9:16 ` Conor Dooley
2024-01-22 9:16 ` Conor Dooley
2024-01-24 5:18 ` Dharma.B
2024-01-24 5:18 ` Dharma.B
2024-01-24 5:18 ` Dharma.B
2024-01-24 16:39 ` Conor Dooley
2024-01-24 16:39 ` Conor Dooley
2024-01-24 16:39 ` Conor Dooley
2024-01-25 6:47 ` Dharma.B
2024-01-25 6:47 ` Dharma.B
2024-01-25 6:47 ` Dharma.B
2024-01-25 8:27 ` Conor Dooley
2024-01-25 8:27 ` Conor Dooley
2024-01-25 8:27 ` Conor Dooley
2024-01-26 14:22 ` Dharma.B
2024-01-26 14:22 ` Dharma.B
2024-01-26 14:22 ` Dharma.B
2024-01-26 15:33 ` Conor Dooley
2024-01-26 15:33 ` Conor Dooley
2024-01-26 15:33 ` Conor Dooley
2024-01-29 3:41 ` Dharma.B
2024-01-29 3:41 ` Dharma.B
2024-01-29 3:41 ` Dharma.B
2024-01-29 17:14 ` Conor Dooley
2024-01-29 17:14 ` Conor Dooley
2024-01-29 17:14 ` Conor Dooley
2024-01-18 19:30 ` [PATCH v3 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema Sam Ravnborg
2024-01-18 19:30 ` Sam Ravnborg
2024-01-18 19:30 ` Sam Ravnborg
2024-01-19 8:41 ` Dharma.B
2024-01-19 8:41 ` Dharma.B
2024-01-19 8:41 ` Dharma.B
2024-01-19 21:33 ` Sam Ravnborg
2024-01-19 21:33 ` Sam Ravnborg
2024-01-19 21:33 ` Sam Ravnborg
2024-01-19 19:51 ` Rob Herring
2024-01-19 19:51 ` Rob Herring
2024-01-19 19:51 ` Rob Herring
2024-01-20 13:23 ` Sam Ravnborg [this message]
2024-01-20 13:23 ` Sam Ravnborg
2024-01-20 13:23 ` Sam Ravnborg
2024-01-22 3:52 ` Dharma.B
2024-01-22 3:52 ` Dharma.B
2024-01-22 3:52 ` Dharma.B
2024-01-22 16:02 ` Sam Ravnborg
2024-01-22 16:02 ` Sam Ravnborg
2024-01-22 16:02 ` Sam Ravnborg
2024-01-22 16:04 ` Sam Ravnborg
2024-01-22 16:04 ` Sam Ravnborg
2024-01-22 16:04 ` Sam Ravnborg
2024-01-24 8:55 ` Dharma.B
2024-01-24 8:55 ` Dharma.B
2024-01-24 8:55 ` Dharma.B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240120132356.GA345206@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dharma.b@microchip.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux4microchip@microchip.com \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.