From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Frederic Weisbecker <frederic@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/5] s390/irq,nmi: do not include <linux/vtime.h> header
Date: Mon, 29 Jan 2024 10:51:44 +0100 [thread overview]
Message-ID: <20240129095144.6722-A-hca@linux.ibm.com> (raw)
In-Reply-To: <966148629217b56139f40c38ffbb45ca229bd489.1706470223.git.agordeev@linux.ibm.com>
On Sun, Jan 28, 2024 at 08:58:53PM +0100, Alexander Gordeev wrote:
> update_timer_sys() and update_timer_mcck() are inlines used for
> CPU time accounting from the interrupt and machine-check handlers.
> These routines are specific to s390 architecture, but declared
> via <linux/vtime.h> header, which in turn inludes <asm/vtime.h>.
> Avoid the extra loop and include <asm/vtime.h> header directly.
>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> ---
> arch/s390/kernel/irq.c | 1 +
> arch/s390/kernel/nmi.c | 1 +
> 2 files changed, 2 insertions(+)
...
> +++ b/arch/s390/kernel/irq.c
> +#include <asm/vtime.h>
...
> +++ b/arch/s390/kernel/nmi.c
> +#include <asm/vtime.h>
It is confusing when the patch subject is "do not include.." and all
what this patch is doing is to add two includes. I see what this is
doing: getting rid of the implicit include of asm/vtime.h most likely
via linux/hardirq.h, but that's not very obvious.
Anyway:
Acked-by: Heiko Carstens <hca@linux.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Frederic Weisbecker <frederic@kernel.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 4/5] s390/irq,nmi: do not include <linux/vtime.h> header
Date: Mon, 29 Jan 2024 10:51:44 +0100 [thread overview]
Message-ID: <20240129095144.6722-A-hca@linux.ibm.com> (raw)
In-Reply-To: <966148629217b56139f40c38ffbb45ca229bd489.1706470223.git.agordeev@linux.ibm.com>
On Sun, Jan 28, 2024 at 08:58:53PM +0100, Alexander Gordeev wrote:
> update_timer_sys() and update_timer_mcck() are inlines used for
> CPU time accounting from the interrupt and machine-check handlers.
> These routines are specific to s390 architecture, but declared
> via <linux/vtime.h> header, which in turn inludes <asm/vtime.h>.
> Avoid the extra loop and include <asm/vtime.h> header directly.
>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> ---
> arch/s390/kernel/irq.c | 1 +
> arch/s390/kernel/nmi.c | 1 +
> 2 files changed, 2 insertions(+)
...
> +++ b/arch/s390/kernel/irq.c
> +#include <asm/vtime.h>
...
> +++ b/arch/s390/kernel/nmi.c
> +#include <asm/vtime.h>
It is confusing when the patch subject is "do not include.." and all
what this patch is doing is to add two includes. I see what this is
doing: getting rid of the implicit include of asm/vtime.h most likely
via linux/hardirq.h, but that's not very obvious.
Anyway:
Acked-by: Heiko Carstens <hca@linux.ibm.com>
next prev parent reply other threads:[~2024-01-29 9:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 19:58 [PATCH 0/5] sched/vtime: vtime.h headers cleanup Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-01-28 19:58 ` [PATCH 1/5] sched/vtime: remove confusing arch_vtime_task_switch() declaration Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-02-06 22:06 ` Frederic Weisbecker
2024-02-06 22:06 ` Frederic Weisbecker
2024-01-28 19:58 ` [PATCH 2/5] sched/vtime: get rid of generic vtime_task_switch() implementation Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-02-06 23:20 ` Frederic Weisbecker
2024-02-06 23:20 ` Frederic Weisbecker
2024-01-28 19:58 ` [PATCH 3/5] s390/vtime: remove unused __ARCH_HAS_VTIME_TASK_SWITCH leftover Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-01-29 9:51 ` Heiko Carstens
2024-01-29 9:51 ` Heiko Carstens
2024-02-06 23:21 ` Frederic Weisbecker
2024-02-06 23:21 ` Frederic Weisbecker
2024-01-28 19:58 ` [PATCH 4/5] s390/irq,nmi: do not include <linux/vtime.h> header Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-01-29 9:51 ` Heiko Carstens [this message]
2024-01-29 9:51 ` Heiko Carstens
2024-02-07 14:14 ` Alexander Gordeev
2024-02-07 14:14 ` Alexander Gordeev
2024-01-28 19:58 ` [PATCH 5/5] sched/vtime: do not include <asm/vtime.h> header Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-01-29 9:52 ` Heiko Carstens
2024-01-29 9:52 ` Heiko Carstens
2024-02-06 23:30 ` Frederic Weisbecker
2024-02-06 23:30 ` Frederic Weisbecker
2024-02-07 14:12 ` Alexander Gordeev
2024-02-07 14:12 ` Alexander Gordeev
2024-02-07 14:28 ` Frederic Weisbecker
2024-02-07 14:28 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129095144.6722-A-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=frederic@kernel.org \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.