From: Frederic Weisbecker <frederic@kernel.org>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/5] sched/vtime: get rid of generic vtime_task_switch() implementation
Date: Wed, 7 Feb 2024 00:20:36 +0100 [thread overview]
Message-ID: <ZcK-xETH4ny8zMbW@localhost.localdomain> (raw)
In-Reply-To: <1f519a8c86cf13bc4acd18ed5d8d1705d1554083.1706470223.git.agordeev@linux.ibm.com>
Le Sun, Jan 28, 2024 at 08:58:51PM +0100, Alexander Gordeev a écrit :
> The generic vtime_task_switch() implementation gets built only
> if __ARCH_HAS_VTIME_TASK_SWITCH is not defined, but requires an
> architecture to implement arch_vtime_task_switch() callback at
> the same time, which is confusing.
>
> Further, arch_vtime_task_switch() is implemented for 32-bit PowerPC
> architecture only and vtime_task_switch() generic variant is rather
> superfluous.
>
> Simplify the whole vtime_task_switch() wiring by moving the existing
> generic implementation to PowerPC.
>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Frederic Weisbecker <frederic@kernel.org>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 2/5] sched/vtime: get rid of generic vtime_task_switch() implementation
Date: Wed, 7 Feb 2024 00:20:36 +0100 [thread overview]
Message-ID: <ZcK-xETH4ny8zMbW@localhost.localdomain> (raw)
In-Reply-To: <1f519a8c86cf13bc4acd18ed5d8d1705d1554083.1706470223.git.agordeev@linux.ibm.com>
Le Sun, Jan 28, 2024 at 08:58:51PM +0100, Alexander Gordeev a écrit :
> The generic vtime_task_switch() implementation gets built only
> if __ARCH_HAS_VTIME_TASK_SWITCH is not defined, but requires an
> architecture to implement arch_vtime_task_switch() callback at
> the same time, which is confusing.
>
> Further, arch_vtime_task_switch() is implemented for 32-bit PowerPC
> architecture only and vtime_task_switch() generic variant is rather
> superfluous.
>
> Simplify the whole vtime_task_switch() wiring by moving the existing
> generic implementation to PowerPC.
>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
next prev parent reply other threads:[~2024-02-06 23:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 19:58 [PATCH 0/5] sched/vtime: vtime.h headers cleanup Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-01-28 19:58 ` [PATCH 1/5] sched/vtime: remove confusing arch_vtime_task_switch() declaration Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-02-06 22:06 ` Frederic Weisbecker
2024-02-06 22:06 ` Frederic Weisbecker
2024-01-28 19:58 ` [PATCH 2/5] sched/vtime: get rid of generic vtime_task_switch() implementation Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-02-06 23:20 ` Frederic Weisbecker [this message]
2024-02-06 23:20 ` Frederic Weisbecker
2024-01-28 19:58 ` [PATCH 3/5] s390/vtime: remove unused __ARCH_HAS_VTIME_TASK_SWITCH leftover Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-01-29 9:51 ` Heiko Carstens
2024-01-29 9:51 ` Heiko Carstens
2024-02-06 23:21 ` Frederic Weisbecker
2024-02-06 23:21 ` Frederic Weisbecker
2024-01-28 19:58 ` [PATCH 4/5] s390/irq,nmi: do not include <linux/vtime.h> header Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-01-29 9:51 ` Heiko Carstens
2024-01-29 9:51 ` Heiko Carstens
2024-02-07 14:14 ` Alexander Gordeev
2024-02-07 14:14 ` Alexander Gordeev
2024-01-28 19:58 ` [PATCH 5/5] sched/vtime: do not include <asm/vtime.h> header Alexander Gordeev
2024-01-28 19:58 ` Alexander Gordeev
2024-01-29 9:52 ` Heiko Carstens
2024-01-29 9:52 ` Heiko Carstens
2024-02-06 23:30 ` Frederic Weisbecker
2024-02-06 23:30 ` Frederic Weisbecker
2024-02-07 14:12 ` Alexander Gordeev
2024-02-07 14:12 ` Alexander Gordeev
2024-02-07 14:28 ` Frederic Weisbecker
2024-02-07 14:28 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcK-xETH4ny8zMbW@localhost.localdomain \
--to=frederic@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.