Re: [PATCH] riscv/fence: Consolidate fence definitions and define __{mb,rmb,wmb}

From: Conor Dooley <conor.dooley@microchip.com>
To: Eric Chan <ericchancf@google.com>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
	<aou@eecs.berkeley.edu>, <linux-riscv@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv/fence: Consolidate fence definitions and define __{mb,rmb,wmb}
Date: Mon, 12 Feb 2024 08:03:44 +0000	[thread overview]
Message-ID: <20240212-projector-dangle-7815fa2f7415@wendy> (raw)
In-Reply-To: <20240209125048.4078639-1-ericchancf@google.com>

[-- Attachment #1.1: Type: text/plain, Size: 888 bytes --]

On Fri, Feb 09, 2024 at 12:50:48PM +0000, Eric Chan wrote:
> Disparate fence implementations are consolidated into fence.h.
> 
> Introduce __{mb,rmb,wmb}, and rely on the generic definitions
> for {mb,rmb,wmb}. A first consequence is that __{mb,rmb,wmb}
> map to a compiler barrier on !SMP (while their definition remains
> unchanged on SMP).
> 
> Introduce RISCV_FULL_BARRIER and use in arch_atomic* function.
> like RISCV_ACQUIRE_BARRIER and RISCV_RELEASE_BARRIER, The fence
> instruction can be eliminated When SMP is not in use.
> 
> Also clean up the warning with scripts/checkpatch.pl.
> 
> Signed-off-by: Eric Chan <ericchancf@google.com>

In all configs:
../arch/riscv/include/asm/fence.h:7:10: error: expected expression before '__asm__'
https://patchwork.kernel.org/project/linux-riscv/patch/20240209125048.4078639-1-ericchancf@google.com/

Cheers,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv