All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Chan <ericchancf@google.com>
To: conor.dooley@microchip.com
Cc: aou@eecs.berkeley.edu, ericchancf@google.com,
	linux-kernel@vger.kernel.org,  linux-riscv@lists.infradead.org,
	palmer@dabbelt.com, paul.walmsley@sifive.com
Subject: Re: [PATCH] riscv/fence: Consolidate fence definitions and define __{mb,rmb,wmb}
Date: Tue, 13 Feb 2024 15:03:06 +0000	[thread overview]
Message-ID: <20240213150306.2424991-1-ericchancf@google.com> (raw)
In-Reply-To: <20240212-projector-dangle-7815fa2f7415@wendy>

Hi Conor,

  Thank you, I should not have just used defconfig without allesconfig.
  It has been corrected in PATCH v2 [0] as follows.

  v1 -> v2: makes compilation pass with allyesconfig instead of
  defconfig only, also satisfy scripts/checkpatch.pl.
  - (__asm__ __volatile__ (RISCV_FENCE_ASM(p, s) : : : "memory"))
  + ({ __asm__ __volatile__ (RISCV_FENCE_ASM(p, s) : : : "memory"); })

  I've updated patch v3[https://marc.info/?l=linux-kernel&m=170783431129245]
  Please let me know if you have any further questions or suggestions.

  [0] https://lore.kernel.org/lkml/20240212105946.1241100-1-ericchancf@google.com/

Sincerely,
  Eric Chan

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Eric Chan <ericchancf@google.com>
To: conor.dooley@microchip.com
Cc: aou@eecs.berkeley.edu, ericchancf@google.com,
	linux-kernel@vger.kernel.org,  linux-riscv@lists.infradead.org,
	palmer@dabbelt.com, paul.walmsley@sifive.com
Subject: Re: [PATCH] riscv/fence: Consolidate fence definitions and define __{mb,rmb,wmb}
Date: Tue, 13 Feb 2024 15:03:06 +0000	[thread overview]
Message-ID: <20240213150306.2424991-1-ericchancf@google.com> (raw)
In-Reply-To: <20240212-projector-dangle-7815fa2f7415@wendy>

Hi Conor,

  Thank you, I should not have just used defconfig without allesconfig.
  It has been corrected in PATCH v2 [0] as follows.

  v1 -> v2: makes compilation pass with allyesconfig instead of
  defconfig only, also satisfy scripts/checkpatch.pl.
  - (__asm__ __volatile__ (RISCV_FENCE_ASM(p, s) : : : "memory"))
  + ({ __asm__ __volatile__ (RISCV_FENCE_ASM(p, s) : : : "memory"); })

  I've updated patch v3[https://marc.info/?l=linux-kernel&m=170783431129245]
  Please let me know if you have any further questions or suggestions.

  [0] https://lore.kernel.org/lkml/20240212105946.1241100-1-ericchancf@google.com/

Sincerely,
  Eric Chan

  parent reply	other threads:[~2024-02-13 15:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 12:50 [PATCH] riscv/fence: Consolidate fence definitions and define __{mb,rmb,wmb} Eric Chan
2024-02-09 12:50 ` Eric Chan
2024-02-12  8:03 ` Conor Dooley
2024-02-12  8:03   ` Conor Dooley
2024-02-12 10:59   ` [PATCH v2] " Eric Chan
2024-02-12 10:59     ` Eric Chan
2024-02-13 10:38     ` Andrea Parri
2024-02-13 10:38       ` Andrea Parri
2024-02-13 14:57       ` Eric Chan
2024-02-13 14:57         ` Eric Chan
2024-02-13 15:03   ` Eric Chan [this message]
2024-02-13 15:03     ` [PATCH] " Eric Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240213150306.2424991-1-ericchancf@google.com \
    --to=ericchancf@google.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor.dooley@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.